New issue
Advanced search Search tips

Issue 723674 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: new_row.ColumnLogicalHeight() > 0 in LayoutMultiColumnFlowThread.cpp

Project Member Reported by ClusterFuzz, May 17 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5958895444164608

Fuzzer: ifratric-browserfuzzer-v3
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: CHECK failure
Crash Address: 
Crash State:
  new_row.ColumnLogicalHeight() > 0 in LayoutMultiColumnFlowThread.cpp
  blink::LayoutMultiColumnFlowThread::AppendNewFragmentainerGroupIfNeeded
  blink::LayoutMultiColumnFlowThread::LayoutColumns
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=472186:472211

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5958895444164608


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 17 2017

ClusterFuzz has detected this issue as fixed in range 472221:472281.

Detailed report: https://clusterfuzz.com/testcase?key=5958895444164608

Fuzzer: ifratric-browserfuzzer-v3
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: CHECK failure
Crash Address: 
Crash State:
  new_row.ColumnLogicalHeight() > 0 in LayoutMultiColumnFlowThread.cpp
  blink::LayoutMultiColumnFlowThread::AppendNewFragmentainerGroupIfNeeded
  blink::LayoutMultiColumnFlowThread::LayoutColumns
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=472186:472211
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=472221:472281

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5958895444164608


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 2 by ClusterFuzz, May 17 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Untriaged)
ClusterFuzz testcase 5958895444164608 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5bad235c74bffb51fc4c1546747af9a7ff9a3a3

commit b5bad235c74bffb51fc4c1546747af9a7ff9a3a3
Author: Francois Doray <fdoray@chromium.org>
Date: Tue Nov 07 16:35:58 2017

Rename TabManagerObserver to TabLifetimeObserver.

As part of the TabManager refactor, TabManager will be
renamed to LifetimeManager and will have no knowledge of
tabs / WebContents. It will only deal with generic
"LifetimeUnits". In that world, it doesn't make sense
to have a class name "TabManagerObserver" to observe
tab-specific events.

This CL renames TabManagerObserver to TabLifetimeObserver.
In a future CL, TabLifetimeObservers will no longer be
attached to TabManager. They will instead be attached
directly to TabLifetimeUnits.

TBR=lazyboy@chromium.org,

Bug:  723674 
Change-Id: Id9ea1e6583eda3ba8d624c5d2162ba8b36d173f7
Reviewed-on: https://chromium-review.googlesource.com/726019
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514489}
[modify] https://crrev.com/b5bad235c74bffb51fc4c1546747af9a7ff9a3a3/chrome/browser/BUILD.gn
[modify] https://crrev.com/b5bad235c74bffb51fc4c1546747af9a7ff9a3a3/chrome/browser/extensions/api/tabs/tabs_event_router.h
[add] https://crrev.com/b5bad235c74bffb51fc4c1546747af9a7ff9a3a3/chrome/browser/resource_coordinator/tab_lifetime_observer.cc
[add] https://crrev.com/b5bad235c74bffb51fc4c1546747af9a7ff9a3a3/chrome/browser/resource_coordinator/tab_lifetime_observer.h
[rename] https://crrev.com/b5bad235c74bffb51fc4c1546747af9a7ff9a3a3/chrome/browser/resource_coordinator/tab_lifetime_observer_browsertest.cc
[modify] https://crrev.com/b5bad235c74bffb51fc4c1546747af9a7ff9a3a3/chrome/browser/resource_coordinator/tab_manager.cc
[modify] https://crrev.com/b5bad235c74bffb51fc4c1546747af9a7ff9a3a3/chrome/browser/resource_coordinator/tab_manager.h
[delete] https://crrev.com/39ba30acf468daf12b38a2c832dc769fcbff0681/chrome/browser/resource_coordinator/tab_manager_observer.cc
[delete] https://crrev.com/39ba30acf468daf12b38a2c832dc769fcbff0681/chrome/browser/resource_coordinator/tab_manager_observer.h
[modify] https://crrev.com/b5bad235c74bffb51fc4c1546747af9a7ff9a3a3/chrome/test/BUILD.gn

Sign in to add a comment