New issue
Advanced search Search tips

Issue 723653 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

shippingType: "pickup" should use "Pickup" in error messages.

Project Member Reported by rouslan@chromium.org, May 17 2017

Issue description

Chrome Version       : 60.0.3100.0
URLs (if applicable) : https://rsolomakhin.github.io/pr/pickup/

What steps will reproduce the problem?
1. Open https://rsolomakhin.github.io/pr/pickup/ and click "Buy" on the page.
2. Select a non-US address.

What is the expected result?
The error message should be "Cannot pickup from this address."

What happens instead of that?
The error message is "Cannot ship to this address."

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3100.0 Safari/537.36



 
Screenshot from 2017-05-17 10:20:38.png
52.8 KB View Download

Comment 1 by ma...@chromium.org, May 18 2017

Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c1f319d05a01eae5d4a76221ee06e7bc2640eb3

commit 2c1f319d05a01eae5d4a76221ee06e7bc2640eb3
Author: Mathieu Perreault <mathp@chromium.org>
Date: Thu May 18 15:32:51 2017

[Payments] Use the proper error string for unsupported shipping option

Bug:  723653 
Change-Id: I2513d499d97d8aa8133f69acde8c4f2c2da96fa2
Reviewed-on: https://chromium-review.googlesource.com/508474
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#472822}
[modify] https://crrev.com/2c1f319d05a01eae5d4a76221ee06e7bc2640eb3/components/payments/content/payment_request_spec.cc

Comment 3 by ma...@chromium.org, May 18 2017

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment