Billing address dropdown does not select the freshly added billing address. |
||||
Issue descriptionChrome Version : 60.0.3100.0 URLs (if applicable) : https://rsolomakhin.github.io/pr/type/debit/ What steps will reproduce the problem? 1. Add a credit card with no billing address through settings. For example, 4111 1111 1111 1111. 2. Open https://rsolomakhin.github.io/pr/type/debit/ 3. Click "Buy" on page. 4. Click "Choose" in the "Payment" section of the PR UI. 5. Click "Add" button next to the billing address dropdown. 6. Add a valid address and click "Done" in the address editor. 7. Click "Done" in the card editor. What is the expected result? Card editor should close. What happens instead of that? The billing address dropdown is highlighted with a red border, which indicates that the address has not been selected yet. However, the address is selected (see screenshot). It appears that the data model has not been updated to reflect the UI state. Please provide any additional information below. Attach a screenshot if possible. UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3100.0 Safari/537.36 After clicking on the dropdown and re-selecting the same billing address again, the red highlight goes away and the "Done" button works again in the card editor view.
,
May 17 2017
Tentatively sending over to mad, who implemented this feature IIRC. mad, can you please take a look?
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/efe21de9c7770038f4901f7d8fd75570a72e1747 commit efe21de9c7770038f4901f7d8fd75570a72e1747 Author: mad <mad@chromium.org> Date: Thu May 18 13:56:47 2017 Properly update the payment request credit card billing combob box when a new address is added. BUG= 723634 Review-Url: https://codereview.chromium.org/2888203004 Cr-Commit-Position: refs/heads/master@{#472792} [modify] https://crrev.com/efe21de9c7770038f4901f7d8fd75570a72e1747/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc [modify] https://crrev.com/efe21de9c7770038f4901f7d8fd75570a72e1747/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
,
May 18 2017
,
Jun 27 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by anthonyvd@chromium.org
, May 17 2017