New issue
Advanced search Search tips

Issue 723625 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in CPDF_CMap::GetNextChar

Project Member Reported by ClusterFuzz, May 17 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6099078344867840

Fuzzer: ifratric_pdf_generic
Job Type: linux_msan_pdfium
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  CPDF_CMap::GetNextChar
  CPDF_Font::GetStringWidth
  CPDF_TextPage::GetCharWidth
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_pdfium&range=469838:469862

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6099078344867840


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, May 18 2017

Labels: M-60
Project Member

Comment 2 by sheriffbot@chromium.org, May 18 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, May 18 2017

Labels: Pri-1

Comment 4 by wfh@chromium.org, May 18 2017

Cc: dsinclair@chromium.org
Components: Internals>Plugins>PDF
Owner: tsepez@chromium.org
Status: Assigned (was: Untriaged)
quite a lot of changes in this code recently, dsinclair or tsepez could you take a look...?
Cc: npm@chromium.org
Adding npm@ for font fun.

Comment 6 by tsepez@chromium.org, May 19 2017

https://cs.chromium.org/chromium/src/third_party/pdfium/core/fpdfapi/font/fpdf_font_cid.cpp?rcl=76020fc9751e55661d1c01b6cd92dfcb1fd56e6a&l=686

Lines 688 - 690 are inconsistent with themselves.  We want to zero the start of the buffer, not the end of the buffer where we just placed the character.


Comment 7 by tsepez@chromium.org, May 19 2017

And the bonehead award goes to me for introducing this at https://pdfium-review.googlesource.com/c/5012/

Comment 8 by tsepez@chromium.org, May 19 2017

Cc: thestig@chromium.org
Project Member

Comment 9 by ClusterFuzz, May 20 2017

ClusterFuzz has detected this issue as fixed in range 473407:473417.

Detailed report: https://clusterfuzz.com/testcase?key=6099078344867840

Fuzzer: ifratric_pdf_generic
Job Type: linux_msan_pdfium
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  CPDF_CMap::GetNextChar
  CPDF_Font::GetStringWidth
  CPDF_TextPage::GetCharWidth
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_pdfium&range=469838:469862
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_pdfium&range=473407:473417

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6099078344867840


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, May 20 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6099078344867840 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, May 20 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Beta
Project Member

Comment 13 by sheriffbot@chromium.org, Aug 26 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment