New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723622 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Add ranker debug output to snippets_internal

Project Member Reported by vitaliii@chromium.org, May 17 2017

Issue description

Otherwise it is painful to override its parameters with a command line, because it is not clear whether the ranker does not work or the command line.
 
Labels: zine-17-05-15
Status: Started (was: Assigned)
Screenshots


ranker_1.png
388 KB View Download
ranker_2.png
401 KB View Download
Components: UI>Browser>NewTabPage
Project Member

Comment 4 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/147728249280f6259c9143a91d878408b4c8e5a2

commit 147728249280f6259c9143a91d878408b4c8e5a2
Author: vitaliii <vitaliii@chromium.org>
Date: Thu May 18 16:52:59 2017

[NTP::SectionOrder] Add ranker section to snippets internals.

Previously, it was cumbersome to verify whether ranker works (due to
implicity of its effects). This CL adds some ranker debug output to
snippets internals.

The screenshots are in the bug.

BUG= 723622 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2889153003
Cr-Commit-Position: refs/heads/master@{#472847}

[modify] https://crrev.com/147728249280f6259c9143a91d878408b4c8e5a2/chrome/browser/resources/snippets_internals.html
[modify] https://crrev.com/147728249280f6259c9143a91d878408b4c8e5a2/chrome/browser/resources/snippets_internals.js
[modify] https://crrev.com/147728249280f6259c9143a91d878408b4c8e5a2/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/147728249280f6259c9143a91d878408b4c8e5a2/chrome/browser/ui/webui/snippets_internals_message_handler.h
[modify] https://crrev.com/147728249280f6259c9143a91d878408b4c8e5a2/components/ntp_snippets/category_rankers/category_ranker.h
[modify] https://crrev.com/147728249280f6259c9143a91d878408b4c8e5a2/components/ntp_snippets/category_rankers/click_based_category_ranker.cc
[modify] https://crrev.com/147728249280f6259c9143a91d878408b4c8e5a2/components/ntp_snippets/category_rankers/click_based_category_ranker.h
[modify] https://crrev.com/147728249280f6259c9143a91d878408b4c8e5a2/components/ntp_snippets/category_rankers/constant_category_ranker.cc
[modify] https://crrev.com/147728249280f6259c9143a91d878408b4c8e5a2/components/ntp_snippets/category_rankers/constant_category_ranker.h
[modify] https://crrev.com/147728249280f6259c9143a91d878408b4c8e5a2/components/ntp_snippets/category_rankers/fake_category_ranker.cc
[modify] https://crrev.com/147728249280f6259c9143a91d878408b4c8e5a2/components/ntp_snippets/category_rankers/fake_category_ranker.h
[modify] https://crrev.com/147728249280f6259c9143a91d878408b4c8e5a2/components/ntp_snippets/category_rankers/mock_category_ranker.h

Status: Fixed (was: Started)
Cc: ntp-dev+bugs@chromium.org vitaliii@chromium.org
 Issue 675919  has been merged into this issue.

Sign in to add a comment