Previous country state is shown in Payment Request address snippet after changing country to one with not state |
|||||
Issue descriptionCreate an address in a country with a state (either from the Chrome settings or the Payment request UI), e.g., US or Canada. After it's been saved, edit it to change the country to one that has not state (e.g., Germany). Go back to Payment request address list, and notice that the address snippet contains the state from the previous country.
,
Jun 19 2017
,
Jun 27 2017
,
Jul 6 2017
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee7829e4607ec6e4b27efbfdf4212c8e447bde13 commit ee7829e4607ec6e4b27efbfdf4212c8e447bde13 Author: mathp <mathp@chromium.org> Date: Thu Jul 06 22:30:37 2017 [Payments] When saving an edited address in editor, clear data first. The original bug was that some information was wrongfully being retained in the edited profile when saved, because some fields were absent in the newly selected country (say you edited from US to Albania, which has no states). We fix this by clearing all the address fields from the profile being edited, before replacing with the values in the editor. BUG= 723610 TEST=browser_tests Review-Url: https://codereview.chromium.org/2972973002 Cr-Commit-Position: refs/heads/master@{#484756} [modify] https://crrev.com/ee7829e4607ec6e4b27efbfdf4212c8e447bde13/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc [modify] https://crrev.com/ee7829e4607ec6e4b27efbfdf4212c8e447bde13/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc [modify] https://crrev.com/ee7829e4607ec6e4b27efbfdf4212c8e447bde13/components/autofill/core/browser/autofill_profile.cc [modify] https://crrev.com/ee7829e4607ec6e4b27efbfdf4212c8e447bde13/components/autofill/core/browser/autofill_profile.h
,
Jul 7 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rouslan@chromium.org
, Jun 19 2017Status: Assigned (was: Untriaged)