New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 723604 link

Starred by 1 user
Status: Fixed
Owner:
█ wangyix@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
vasilvv@chromium.org
rch@chromium.org
ianswett@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

QUIC_INVALID_CRYPTO_MESSAGE_PARAMETER during handshake

Reported by sslu...@akamai.com, May 17 2017 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/602.3.12 (KHTML, like Gecko) Version/10.0.2 Safari/602.3.12

Steps to reproduce the problem:
1. 
2. 
3. 

What is the expected behavior?

What went wrong?
1.
Client may drop cached certificates during handshake, see method  QuicCryptoClientConfig::CacheNewServerConfig()   and method ClearProof().
If client sends CCRT tag in the first CHLO, drops cached certificates and sends  subsequent CHLOs without CCRT tag, server must throw away cached certificates, too. 

Otherwise  server sends incorrect cert. chain (exploiting cached certificates) , and client closes connection with error QUIC_INVALID_CRYPTO_MESSAGE_PARAMETER (Certificate data invalid).
Possible solution is to drop previously cached client's certificates if CCRT tag is not present in the last CHLO.

2.
I believe that parameters of CertCompressor::CompressChain() are incorrect.

See the attached patch.

Did this work before? N/A 

Chrome version: master  Channel: n/a
OS Version: OS X 10.12.2
Flash Version:
cached_certs.patch
1.2 KB Download

Comment 1 by rsesek@chromium.org, May 17 2017

Components: Internals>Network>QUIC

Comment 2 by rsleevi@chromium.org, May 18 2017

Cc: rch@chromium.org

Comment 3 by jmukthavaram@chromium.org, Jul 13 2017 

Could someone from Network>QUIC team please look into this issue.
Thanks..!!

Comment 4 by zhongyi@chromium.org, Jul 13 2017

Cc: ianswett@google.com
The described code path sounds possible to happen. If the client drops the cert(usually means there's an error), the current behavior is to explode eventually and closes the connection. I wonder whether this is working as we expect or it's a bug. 

ianswett@: Ian, thoughts?

Comment 5 by ianswett@google.com, Jul 13 2017

Cc: vasilvv@chromium.org
That sounds plausible to me as well, but I'm going to add Victor, as I suspect he'll have a better understanding than I do.

Comment 6 by ianswett@google.com, Jul 13 2017 

And can we get a net-internals of this occurring?

Comment 7 by kavvaru@chromium.org, Jul 20 2017

Labels: Needs-Feedback

Comment 8 by svaldez@chromium.org, Aug 3 2017 

If this is still an issue, can you provide a net-log of this occurring as per:

http://dev.chromium.org/for-testers/providing-network-details

Comment 9 by rch@chromium.org, Aug 22 2017

Owner: rch@chromium.org
Status: Started (was: Unconfirmed)
Thanks for the report. Looks like both of these are bugs in the server's handling. I'll make sure we get this fixed.

Comment 10 by rch@chromium.org, Aug 22 2017

Labels: -Needs-Feedback

Comment 11 by rch@chromium.org, Nov 17 2017

Owner: wangyix@chromium.org
wangyix: Can you take a look?
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5

commit fefaf5b1c75275985d1c94aa9c2de30710eaf0c5
Author: Dan Zhang <danzh@chromium.org>
Date: Mon Dec 11 17:06:24 2017

Landing Recent QUIC changes until Thu Dec 7 21:51:21 2017
Limit quic stream length to be 2^62. Protected by FLAGS_quic_reloadable_flag_quic_stream_too_long.

Close connection with error when:
1. The stream length reaches max limit during sending.
2. An endpoint receives stream frame and RST frame with offset larger than the limit.

Fix chromium bug  crbug.com/696887 

Merge internal change: 178165587

https://chromium-review.googlesource.com/c/817388/

Use GetQuic{Reloadable,Restart}Flag for feature flag accesses in QUIC.

Merge internal change: 178158996, 178177777

https://chromium-review.googlesource.com/c/818712

Fix QUIC server cert-chain compression bug and resulting bug where server does not drop client cached certs in 2RTT. Protected by FLAGS_quic_reloadable_flag_quic_2rtt_drop_client_cached_certs.

Fix for  crbug.com/723604 . Fixes a typo in QuicCryptoServerConfig::CompressChain() where incorrect params are passed to CertCompressor::CompressChain(). This fix exposes a bug with QUIC 2RTT: if a client sends its first CHLO with cached cert hashes and sends its second CHLO without cached cert hashes, the server now replies to the second CHLO with a REJ containing cached cert hashes when it shouldn't. This incorrect behavior is not present without fixing the aforementioned typo due to lucky coincidence. This CL fixes both the typo and the bug where the server isn't dropping client cached certs after the second CHLO.

Merge internal change: 178117979

https://chromium-review.googlesource.com/c/818747/

Finish QuicTransportVersion -> ParsedQuicVersion refactor

Merge internal change: 178031031

https://chromium-review.googlesource.com/c/817338

Deprecate FLAGS_quic_reloadable_flag_quic_truncate_long_details

Merge internal change: 177911369

https://chromium-review.googlesource.com/c/817588

Refactor QuicFramer to use ParsedQuicVersion

Merge internal change: 177885369

https://chromium-review.googlesource.com/c/817587/

Clean up dead code.

Merge internal change: 177834407

https://chromium-review.googlesource.com/c/817336/

(n/a) Harden ack handling for QUIC, protected by FLAGS_quic_reloadable_flag_quic_strict_ack_handling.

If FLAGS_quic_reloadable_flag_quic_strict_ack_handling is true:
- At sender, avoid sending empty acks.
- At receiver, close connection when an ack frame's first block length is 0, unless the ack is empty. An ack is empty iff largest_observed, first_block_length, num_ack_blocks are all 0.

Verified with clusterfuzz that this fixes http://crbug/786655.

There are many tests sending empty acks(some doing so directly, not via ScopedPacketFlusher), and setting expectations based on that. That's why I am still allowing empty acks to be received in this CL.

Merge internal change: 177753687

https://chromium-review.googlesource.com/c/818708/

QUIC - add flag count for FLAGS_quic_reloadable_flag_quic_enable_hq_deframer.

Needed to verify the new quic/http fork.

n/a (no functional change)

Merge internal change: 177665632

https://chromium-review.googlesource.com/c/817633/

Set NSTP option on Quartc QUIC connections to suppress STOP_WAITING frames. STOP_WAITING frames are going away anyway.

Merge internal change: 177659629

https://chromium-review.googlesource.com/c/818707/

Add code to QUIC TlsHandshakers to create SSL_CTXs

changes to unused TLS code in QUIC

Merge internal change: 177629057

https://chromium-review.googlesource.com/c/817583/

Set encrypters/decrypters when TLS handshake finishes

changes to unused TLS code in QUIC

Merge internal change: 177614234

https://chromium-review.googlesource.com/c/817955/

Deprecate FLAGS_quic_reloadable_flag_quic_enable_version_41.

Merge internal change: 177505836

https://chromium-review.googlesource.com/c/817480/

Add QUIC_PEER_BUG for logging alarming peer behavior.
These behave identically to DLOG(ERROR).

Merge internal change: 177502844

https://chromium-review.googlesource.com/c/818117/

Add key/IV size accessors to QUIC crypters

Merge internal change: 177501208

https://chromium-review.googlesource.com/c/817692/

Use peer class to access QuicConnection’s private member in PacketSavingConnection instead of declaring friend.

Merge internal change: 177497133

https://chromium-review.googlesource.com/c/818055/

Deprecate FLAGS_quic_reloadable_flag_quic_enable_version_38 and  gfe2_reloadable_flag_quic_enable_version_39.

Merge internal change: 177359603

https://chromium-review.googlesource.com/c/817476/

deprecate FLAGS_quic_reloadable_flag_quic_use_net_byte_order_version_label

Merge internal change: 177350890

https://chromium-review.googlesource.com/c/817689/

Remove 4 booleans and the code they were used in from QUIC's Cubic code because they were always true.

n/a (Remove always true booleans)

Merge internal change: 177319308

https://chromium-review.googlesource.com/c/817688/

Deprecate FLAGS_quic_reloadable_flag_quic_use_tls13_cipher_suites

Merge internal change: 177236310

https://chromium-review.googlesource.com/c/817549/

Move includes/dependencies to where needed.

n/a (build only)

Merge internal change: 177064880

https://chromium-review.googlesource.com/c/817548/

Deprecate FLAGS_quic_reloadable_flag_quic_enable_cubic_fixes.  Also deprecates the associated connection options, because they are now useless.

n/a (Flag deprecation)

Merge internal change: 177058367

https://chromium-review.googlesource.com/c/817680/

Deprecate FLAGS_quic_reloadable_flag_quic_send_reset_token_in_shlo.

Merge internal change: 177012460

https://chromium-review.googlesource.com/c/817578/



R=rch@chromium.org

Bug:  786655 , 723604 , 696887 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I590980fa64d89d37717fa14546b5c8631f6a2b65
Reviewed-on: https://chromium-review.googlesource.com/817496
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Dan Zhang <danzh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523114}
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/components/cronet/android/test/quic_test_server.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/components/domain_reliability/quic_error_mapping.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/components/grpc_support/test/quic_test_server.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/BUILD.gn
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/chromium/quic_chromium_client_session_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/chromium/quic_chromium_client_stream_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/chromium/quic_connection_logger.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/chromium/quic_connection_logger.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/chromium/quic_end_to_end_unittest.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/chromium/quic_http_stream_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/chromium/quic_http_utils.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/chromium/quic_http_utils_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/chromium/quic_proxy_client_socket_unittest.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/chromium/quic_test_packet_maker.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/congestion_control/bbr_sender.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/congestion_control/bbr_sender_test.cc
[delete] https://crrev.com/c77383a50fef36eaa55568379e384ad846066798/net/quic/core/congestion_control/cubic.cc
[delete] https://crrev.com/c77383a50fef36eaa55568379e384ad846066798/net/quic/core/congestion_control/cubic.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/congestion_control/cubic_bytes.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/congestion_control/cubic_bytes.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/congestion_control/cubic_bytes_test.cc
[delete] https://crrev.com/c77383a50fef36eaa55568379e384ad846066798/net/quic/core/congestion_control/cubic_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/congestion_control/general_loss_algorithm.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/congestion_control/general_loss_algorithm_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/congestion_control/send_algorithm_interface.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/congestion_control/send_algorithm_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/congestion_control/tcp_cubic_sender_base.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/congestion_control/tcp_cubic_sender_bytes.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/congestion_control/tcp_cubic_sender_bytes_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/aead_base_decrypter.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/aead_base_decrypter.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/aead_base_encrypter.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/aead_base_encrypter.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/aes_128_gcm_12_decrypter.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/aes_128_gcm_12_decrypter_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/aes_128_gcm_decrypter_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/aes_256_gcm_decrypter_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/chacha20_poly1305_decrypter.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/chacha20_poly1305_decrypter_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/chacha20_poly1305_encrypter_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/chacha20_poly1305_tls_decrypter_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/chacha20_poly1305_tls_encrypter_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/crypto_handshake_message.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/crypto_protocol.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/crypto_server_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/crypto_utils.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/crypto_utils.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/crypto_utils_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/null_decrypter.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/null_decrypter.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/null_encrypter.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/null_encrypter.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/quic_crypto_client_config_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/quic_crypto_server_config.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/quic_decrypter.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/quic_decrypter.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/quic_encrypter.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/crypto/quic_encrypter.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/frames/quic_ack_frame.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/frames/quic_frames_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_config.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_connection.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_connection.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_connection_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_constants.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_crypto_client_handshaker.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_crypto_client_stream_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_crypto_server_handshaker.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_crypto_server_handshaker.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_crypto_server_stream.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_crypto_server_stream_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_error_codes.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_error_codes.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_flags_list.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_framer.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_framer.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_framer_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_headers_stream_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_packet_creator.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_packet_creator.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_packet_creator_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_packet_generator.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_packet_generator.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_packet_generator_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_packets.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_packets.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_sent_packet_manager.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_server_session_base_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_session.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_session_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_spdy_session.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_spdy_stream_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_stream.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_stream_send_buffer_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_stream_sequencer_buffer.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_stream_sequencer_buffer_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_stream_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_version_manager.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_version_manager.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_version_manager_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_versions.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_versions.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/quic_versions_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/tls_client_handshaker.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/tls_client_handshaker.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/tls_handshaker.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/tls_handshaker.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/tls_handshaker_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/tls_server_handshaker.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/core/tls_server_handshaker.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/platform/api/quic_bug_tracker.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/platform/api/quic_flags.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/platform/api/quic_mem_slice_span_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/platform/impl/quic_bug_tracker_impl.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/platform/impl/quic_flags_impl.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/quartc/quartc_factory.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/quartc/quartc_session_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/quartc/quartc_stream_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/test_tools/mock_decrypter.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/test_tools/mock_decrypter.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/test_tools/mock_encrypter.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/test_tools/mock_encrypter.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/test_tools/quic_stream_sequencer_peer.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/test_tools/quic_stream_sequencer_peer.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/test_tools/quic_test_utils.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/test_tools/quic_test_utils.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/test_tools/quic_time_wait_list_manager_peer.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/test_tools/simple_data_producer.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/test_tools/simple_quic_framer.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/test_tools/simple_quic_framer.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/quic/test_tools/simulator/quic_endpoint.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/chlo_extractor.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/chlo_extractor.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/chlo_extractor_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/end_to_end_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_client.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_client.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_client_base.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_client_base.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_client_bin.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_client_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_dispatcher.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_dispatcher.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_dispatcher_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_http_response_cache.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_packet_printer_bin.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_server.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_server.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_server_bin.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_server_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_simple_client.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_simple_client.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_simple_client_bin.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_simple_client_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_simple_dispatcher.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_simple_server.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_simple_server.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_simple_server_bin.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_simple_server_session.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_simple_server_session_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_simple_server_stream_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_simple_server_test.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_spdy_client_base.cc
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_spdy_client_base.h
[modify] https://crrev.com/fefaf5b1c75275985d1c94aa9c2de30710eaf0c5/net/tools/quic/quic_

Comment 13 by wangyix@chromium.org, Jan 8 2018

Status: Fixed (was: Started)
Fixed:

https://critique.corp.google.com/#review/178117979
►

Sign in to add a comment