New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 723602 link

Starred by 1 user
Status: Fixed
Owner:
arthurso...@chromium.org
Closed: May 2017
Cc:
█ mkwst@chromium.org
jam@chromium.org
clamy@chromium.org
█ nasko@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

PlzNavigate: Only one of the CSP is reported when several are infringed.

Project Member Reported by arthurso...@chromium.org, May 17 2017 
With PlzNavigate(--enable-browser-side-navigation), only the first infringed CSP is reported.

There is a regression in:
TEST=external/wpt/content-security-policy/frame-src/frame-src-redirect.html

The fix looks very easy to do. I will work on it.
Project Member

Comment 1 by bugdroid1@chromium.org, May 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/102feab6fd73e6b0510c572165d10e2b3831790c

commit 102feab6fd73e6b0510c572165d10e2b3831790c
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Mon May 22 14:20:27 2017

PlzNavigate: Add webkit layout test TestExpectations.

Several regressions happened with PlzNavigate.
This CL updates the
Webkit/LayoutTests/FlagExpectations/enable-browser-side-navigation file.

BUG= 723595 ,  723602 , 713388,  724989 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel;master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2893563002
Cr-Commit-Position: refs/heads/master@{#473574}

[modify] https://crrev.com/102feab6fd73e6b0510c572165d10e2b3831790c/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation
Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c1e5408c1f8e69ae1891edb22a8502b13880846

commit 2c1e5408c1f8e69ae1891edb22a8502b13880846
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Mon May 22 15:33:50 2017

PlzNavigate: Fix "Only one CSP is reported instead of several".

This CL makes that every infringed policy are reported instead of the
infringed first one. One unit test is added as well.

TEST=external/wpt/content-security-policy/frame-src/frame-src-redirect.html

BUG= 723602 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel;master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2893613002
Cr-Commit-Position: refs/heads/master@{#473580}

[modify] https://crrev.com/2c1e5408c1f8e69ae1891edb22a8502b13880846/content/common/content_security_policy/content_security_policy_unittest.cc
[modify] https://crrev.com/2c1e5408c1f8e69ae1891edb22a8502b13880846/content/common/content_security_policy/csp_context.cc
[modify] https://crrev.com/2c1e5408c1f8e69ae1891edb22a8502b13880846/content/common/content_security_policy/csp_context_unittest.cc
[modify] https://crrev.com/2c1e5408c1f8e69ae1891edb22a8502b13880846/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation

Comment 3 by arthurso...@chromium.org, May 22 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment