PlzNavigate: Missing console warning about new lines in urls. |
||||
Issue descriptionThe following console warning is missing with PlzNavigate (--enable-browser-side-navigation) ``` # CONSOLE WARNING: Resource requests whose URLs contain raw newline characters are deprecated, and may be blocked in M60, around August 2017. Please remove newlines from places like element attribute values in order to continue loading those resources. See https://www.chromestatus.com/features/5735596811091968 for more details. ``` This causes a regression in ~40 webkit layout test: * fast/spatial-navigation/snav-iframe-nested.html * compositing/iframes/iframe-in-composited-layer.html * external/wpt/content-security-policy/frame-src/frame-src-redirect.html * external/wpt/content-security-policy/securitypolicyviolation/upgrade-insecure-requests-reporting.https.html * fast/css/counters/counter-traverse-table-cell.html * fast/dom/Element/offsetLeft-offsetTop-body-quirk.html * fast/dom/Element/offsetLeft-offsetTop-html.html * fast/events/drag-and-drop-autoscroll-inner-frame.html * fast/events/resize-subframe.html * fast/events/touch/gesture/long-press-focuses-frame.html * fast/files/null-origin-string.html * fast/frames/content-opacity-1.html * fast/frames/frameset-style-recalc.html * fast/frames/negative-remaining-length-crash.html * fast/loader/simultaneous-reloads-assert.html * fast/loader/stateobjects/pushstate-in-data-url-denied.html * fast/spatial-navigation/snav-hidden-iframe-zero-size.html * fast/spatial-navigation/snav-hidden-iframe.html * fast/spatial-navigation/snav-iframe-no-focusable-content.html * fast/spatial-navigation/snav-iframe-no-scrollable-content.html * fast/spatial-navigation/snav-iframe-recursive-offset-parent.html * fast/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html * fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html * http/tests/inspector/resource-parameters-ipv6.html * http/tests/inspector/service-workers/service-workers-redundant.html * http/tests/security/contentSecurityPolicy/register-bypassing-scheme-partial.html * http/tests/security/document-all.html * http/tests/security/no-indexeddb-from-sandbox.html * http/tests/security/no-popup-from-sandbox-top.html * http/tests/security/no-popup-from-sandbox.html * http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html * http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html * http/tests/security/popup-allowed-by-sandbox-when-allowed.html * http/tests/security/sandboxed-opener-can-close-window.html * http/tests/security/window-named-proto.html * http/tests/security/window-named-valueOf.html * http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html * plugins/createScriptableObject-before-start.html * printing/subframes-percentage-height.html * svg/custom/g-outside-svg.html
,
May 22 2017
Hi mkwst@, PlzNavigate will launch for M60. Do you think this deprecation message will be removed for M60? In this case, maybe it doesn't worth trying to fix this issue now.
,
May 23 2017
After investigating a little bit more, it looks like fixing this might be a trivial change. I am working on this.
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9115376b363cf621a47d8c434c007b9c9e932b57 commit 9115376b363cf621a47d8c434c007b9c9e932b57 Author: arthursonzogni <arthursonzogni@chromium.org> Date: Wed May 24 11:31:33 2017 PlzNavigate: Fix missing console warning. When PlzNavigate(--enable-browser-side-navigation) is enabled, BaseFetchContext::CanRequestInternal([...]) is not used when the resource to fetch is a frame. This implies that the code part that check whether or not an url contains new lines in it was not used. This CL duplicates this part into the FrameLoader. BUG= 723595 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel Review-Url: https://codereview.chromium.org/2898973002 Cr-Commit-Position: refs/heads/master@{#474250} [modify] https://crrev.com/9115376b363cf621a47d8c434c007b9c9e932b57/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation [modify] https://crrev.com/9115376b363cf621a47d8c434c007b9c9e932b57/third_party/WebKit/Source/core/loader/FrameLoader.cpp
,
May 24 2017
,
May 24 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, May 22 2017