New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723579 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Focus is not seen on 'recent destination' option after toggling to fullscreen mode.

Reported by vku...@etouch.net, May 17 2017

Issue description

Chrome Version:59.0.3071.61 (Official Build) Revision c1eefdc7467469d105724cf083c929496a774919-refs/branch-heads/3071@{#595} (64-bit)
OS:Mac(10.11.6, 10.12.3)


What steps will reproduce the problem?
(1)Launch chrome and open NTP, press cmd+P
(2)Click on change button,hit tab key such that focus appears on 'recent destination' option.
(3)Now press fullscreen icon and observe the focus.

Actual: Focus is not seen on 'recent destination' option after toggling to fullscreen mode.

Expected: Focus should be seen on 'recent destination' option after toggling to fullscreen mode.

This is a regression issue broken in 'M58' and below is the manual regression range
Good Build: 58.0.3006.0 
Bad Build:  58.0.3007.0 
 

Note: Issue not seen on Win & Linux OS.


 
Actual_Result.mov
2.6 MB Download
Expected_Print.mov
2.5 MB Download

Comment 1 by vku...@etouch.net, May 17 2017

Labels: -hasbisect
Cc: jmukthavaram@chromium.org
Labels: -M-59 hasbisect-per-revision M-60
Owner: tkent@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on beta-59.0.3071.47 & latest Canary-60.0.3102.0 .
Manual Bisect:
-------------
Good Build: 58.0.3006.0 -Revision-448862
Bad Build:  58.0.3007.0-Revision-449173

Per Revision Bisect info:
-------------------------
You are probably looking for a change made after 448927 (known good), but no later than 448928 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/a79a95466df9d013721167cf2f0c8ba849214207..1c12127b721f833f37b81553e19b8eb0392da651

tkent@,Could you please take a look & reassign if it is not releated to your change.
Thank you..!!



Comment 3 by tkent@chromium.org, May 19 2017

It was hard to reproduce this reliably.
It seems,
 - Need to click the hamburger menu while progress indicator for "Local Destinations" is animating, AND
 - Need to click the fullscreen button after the progress indicator disappears

Comment 4 by tkent@chromium.org, May 19 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0646d775e805babb8d6949f955071011df709f2

commit a0646d775e805babb8d6949f955071011df709f2
Author: tkent <tkent@chromium.org>
Date: Wed May 24 23:31:38 2017

Print Preview: Mac: Do not blur focused item while opening the hamburger menu.

:focus selector doesn't work if the container page is inactive. We should
check document.activeElement instead.

BUG= 723579 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2896463004
Cr-Commit-Position: refs/heads/master@{#474475}

[modify] https://crrev.com/a0646d775e805babb8d6949f955071011df709f2/chrome/browser/resources/print_preview/search/destination_list.js

Comment 6 by tkent@chromium.org, May 24 2017

Status: Fixed (was: Started)
Labels: TE-Verified-60.0.3112.7 TE-Verified-M60
Tested the issue on Mac 10.12.4 using chrome dev version#60.0.3112.7 with the steps mentioned in comment #0.Observed that the focus is seen on 'recent destination' option after toggling to full screen mode. Hence adding TE-Verified labels.

Please find the attached screen cast for the same.
Thanks!!
723579.mp4
1.1 MB View Download

Sign in to add a comment