Missing accessibility information for images in LabelButtons.
Reported by
a-...@yandex-team.ru,
May 17 2017
|
|||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.137 YaBrowser/17.4.0.2459 Yowser/2.5 Safari/537.36 Steps to reproduce the problem: 1. Show bookmarks panel (not empty). 2. Open the Microsoft Inspect tool. 3. Observe the 'name' listed for the bookmark button (the part of button with picture) in the accessibility inspector. What is the expected behavior? Should list a valid 'name' of bookmark. What went wrong? [null] are listed. Did this work before? No Chrome version: 58.0.3029.110 Channel: n/a OS Version: 10 Pro Flash Version: It is reproduced for any complex views: LabelButtons, MenuButtons etc.
,
May 18 2017
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce2e11f2565db306765cc6f6412cf5bfb158fb70 commit ce2e11f2565db306765cc6f6412cf5bfb158fb70 Author: patricialor <patricialor@chromium.org> Date: Fri May 26 01:25:32 2017 a11y: Exclude children of nested keyboard accessible controls from a11y tree. Currently, children of keyboard accessible controls, such as the Labels inside LabelButtons, are not hidden from the accessibility tree. This is not useful because the user only cares about the element that has focus, not any children inside it, which are implementation details. Set any children of keyboard accessible controls to have ignored roles, which indicates to the OS (works for Windows, Mac, and Linux) that the ignored element should be excluded from the accessibility tree. BUG= 610589 , 723574 TEST=On Mac: Open the XCode Accessibility Inspector. On Windows: Open the Windows SDK 'Inspect.exe' and make sure the icon for 'Watch Focus' is selected. Then (on Mac, hover over; on Windows, focus) a views::LabelButton (e.g. on the HTTP Authentication dialog). It should report an empty set of children and its role ("Type"/"accessibilityRole" on Mac; "Role"/"ControlType" on Windows) should say it is a button. Review-Url: https://codereview.chromium.org/2119413004 Cr-Commit-Position: refs/heads/master@{#474867} [modify] https://crrev.com/ce2e11f2565db306765cc6f6412cf5bfb158fb70/ui/accessibility/platform/ax_platform_node_auralinux.cc [modify] https://crrev.com/ce2e11f2565db306765cc6f6412cf5bfb158fb70/ui/accessibility/platform/ax_platform_node_mac.mm [modify] https://crrev.com/ce2e11f2565db306765cc6f6412cf5bfb158fb70/ui/accessibility/platform/ax_platform_node_win.cc [modify] https://crrev.com/ce2e11f2565db306765cc6f6412cf5bfb158fb70/ui/views/accessibility/native_view_accessibility_base.cc [modify] https://crrev.com/ce2e11f2565db306765cc6f6412cf5bfb158fb70/ui/views/accessibility/native_view_accessibility_unittest.cc [modify] https://crrev.com/ce2e11f2565db306765cc6f6412cf5bfb158fb70/ui/views/view.h [modify] https://crrev.com/ce2e11f2565db306765cc6f6412cf5bfb158fb70/ui/views/widget/native_widget_mac_accessibility_unittest.mm
,
May 30 2017
Thank you for reporting this :)
,
May 30 2017
(To clarify, the solution we implemented for this was to not show the children of complex Views, as opposed to making sure those children have the correct accessibility information, which is what was suggested in the "expected behaviour" section of the bug report. So the bookmark button should show up as a single a11y element, not a button with an image and text inside, with the correct a11y information on the image and text, which was what #c3 implemented.) |
|||
►
Sign in to add a comment |
|||
Comment 1 by ligim...@chromium.org
, May 17 2017