The builder had problem applying the patch, but ignored it and continued with compilation, and turned out green. This has been happening as early as https://luci-milo.appspot.com/buildbot/tryserver.chromium.mac/ios-device/209498 and possibly earlier.
iOS applies the patch by calling bot_update.ensure_checkout. We are not try/excepting it. Why isn't patch failure raising StepFailure and halting the build?
Exactly
Uploaded https://chromium-review.googlesource.com/c/508790/ and https://chromium-review.googlesource.com/c/508697/ . My investigation indicates this regressed in https://chromium-review.googlesource.com/c/475950/ , about a month ago.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/16d2ae8cb05c27956530d8f05a893caec6a488ac commit 16d2ae8cb05c27956530d8f05a893caec6a488ac Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org> Date: Thu May 18 18:16:56 2017 bot_update: fix regression with swallowed exception This was regressed in https://chromium-review.googlesource.com/475950 Downstream regression test added in https://chromium-review.googlesource.com/c/508697/ Bug: 723572 Change-Id: I44dbaf9e4996388b898359141db879bd0a1023d9 Reviewed-on: https://chromium-review.googlesource.com/508790 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Daniel Jacques <dnj@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/16d2ae8cb05c27956530d8f05a893caec6a488ac/recipes/recipe_modules/bot_update/example.expected/tryjob_fail_patch.json [modify] https://crrev.com/16d2ae8cb05c27956530d8f05a893caec6a488ac/recipes/recipe_modules/bot_update/api.py [modify] https://crrev.com/16d2ae8cb05c27956530d8f05a893caec6a488ac/recipes/recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/f347ca1f531aad4cfb60ac6f23b4a8d8426195db commit f347ca1f531aad4cfb60ac6f23b4a8d8426195db Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org> Date: Thu May 18 22:04:37 2017 ios/try: add regression test for patch application failure Bug: 723572 Change-Id: I41d8ab750e53e13dc2444c6cf80cc5c45234ab85 Reviewed-on: https://chromium-review.googlesource.com/508697 Commit-Queue: smut <smut@chromium.org> Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by: smut <smut@chromium.org> [add] https://crrev.com/f347ca1f531aad4cfb60ac6f23b4a8d8426195db/scripts/slave/recipes/ios/try.expected/patch_failure.json [modify] https://crrev.com/f347ca1f531aad4cfb60ac6f23b4a8d8426195db/scripts/slave/recipes/ios/try.py
Comment 1 by s...@google.com
, May 17 2017Owner: phajdan.jr@chromium.org
Status: Assigned (was: Untriaged)