New issue
Advanced search Search tips

Issue 723537 link

Starred by 12 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Chromium-Packagers


Sign in to add a comment

Video not supported after update to the latest Chrome

Reported by daniel.h...@gmail.com, May 17 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36

Example URL:
https://home.hdhome.sk/photo/?t=Albums/album_32303137/album_323031372f30352e30312044726f7a64696b/video_323031372f30352e30312044726f7a64696b_4d56495f353632332e6d7034#Albums/album_32303137/album_323031372f30352e30312044726f7a64696b/video_323031372f30352e30312044726f7a64696b_4d56495f353632332e6d7034

Steps to reproduce the problem:
1. Open provided URL
2. Switch video quality to original - at bottom left
3. 

What is the expected behavior?
Video should be playable as with the older Chrome version 57.x

What went wrong?
Video is not playable.

Did this work before? Yes 57

Is it a problem with Flash or HTML5? HTML5

Does this work in other browsers? Yes

Chrome version: 58.0.3029.110  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

Contents of chrome://gpu: 
Graphics Feature Status
Canvas: Hardware accelerated
Flash: Hardware accelerated
Flash Stage3D: Hardware accelerated
Flash Stage3D Baseline profile: Hardware accelerated
Compositing: Hardware accelerated
Multiple Raster Threads: Enabled
Native GpuMemoryBuffers: Software only. Hardware acceleration disabled
Rasterization: Hardware accelerated
Video Decode: Hardware accelerated
Video Encode: Hardware accelerated
VPx Video Decode: Software only, hardware acceleration unavailable
WebGL: Hardware accelerated
WebGL2: Hardware accelerated
Driver Bug Workarounds
clear_uniforms_before_first_program_use
decode_encode_srgb_for_generatemipmap
disable_direct_composition
disable_discard_framebuffer
disable_dxgi_zero_copy_video
disable_framebuffer_cmaa
exit_on_context_lost
force_cube_complete
msaa_is_slow
scalarize_vec_and_mat_constructor_args
texsubimage_faster_than_teximage
Problems Detected
VPx decoding isn't supported before Windows 10 anniversary update.: 616318
Disabled Features: accelerated_vpx_decode
VPx decoding is too slow on Intel Broadwell, Skylake, and CherryView: 616318
Disabled Features: accelerated_vpx_decode
Accelerated VPx decoding is hanging on some videos.: 654111
Disabled Features: accelerated_vpx_decode
Some drivers are unable to reset the D3D device in the GPU process sandbox
Applied Workarounds: exit_on_context_lost
TexSubImage is faster for full uploads on ANGLE
Applied Workarounds: texsubimage_faster_than_teximage
Clear uniforms before first program use on all platforms: 124764, 349137
Applied Workarounds: clear_uniforms_before_first_program_use
Always rewrite vec/mat constructors to be consistent: 398694
Applied Workarounds: scalarize_vec_and_mat_constructor_args
ANGLE crash on glReadPixels from incomplete cube map texture: 518889
Applied Workarounds: force_cube_complete
On Intel GPUs MSAA performance is not acceptable for GPU rasterization: 527565
Applied Workarounds: msaa_is_slow
Framebuffer discarding can hurt performance on non-tilers: 570897
Applied Workarounds: disable_discard_framebuffer
Direct composition flashes black initially on Win <10: 588588
Applied Workarounds: disable_direct_composition
Zero copy DXGI video hangs on shutdown on Win < 8.1: 621190
Applied Workarounds: disable_dxgi_zero_copy_video
Limited enabling of Chromium GL_INTEL_framebuffer_CMAA: 535198
Applied Workarounds: disable_framebuffer_cmaa
Disable KHR_blend_equation_advanced until cc shaders are updated: 661715
Decode and Encode before generateMipmap for srgb format textures on Windows: 634519
Applied Workarounds: decode_encode_srgb_for_generatemipmap
Native GpuMemoryBuffers have been disabled, either via about:flags or command line.
Disabled Features: native_gpu_memory_buffers
Version Information
Data exported	5/17/2017, 10:38:03 AM
Chrome version	Chrome/58.0.3029.110
Operating system	Windows NT 6.1.7601 SP1
Software rendering list version	12.20
Driver bug list version	9.36
ANGLE commit id	461d9a3060e3
2D graphics backend	Skia/58 4c81ba6ba3a3270db809bf7d4c3bc782694a56a4
Command Line Args	Files (x86)\Google\Chrome\Application\chrome.exe" --flag-switches-begin --flag-switches-end
Driver Information
Initialization time	36
In-process GPU	false
Passthrough Command Decoder	false
Sandboxed	false
GPU0	VENDOR = 0x8086, DEVICE= 0x1912
Optimus	false
Optimus	false
AMD switchable	false
Desktop compositing	Aero Glass
Diagonal Monitor Size of \\.\DISPLAY1	24.0"
Driver vendor	Intel Corporation
Driver version	20.19.15.4474
Driver date	6-13-2016
Pixel shader version	5.0
Vertex shader version	5.0
Max. MSAA samples	16
Machine model name	
Machine model version	
GL_VENDOR	Google Inc.
GL_RENDERER	ANGLE (Intel(R) HD Graphics 530 Direct3D11 vs_5_0 ps_5_0)
GL_VERSION	OpenGL ES 3.0 (ANGLE 2.1.0.461d9a3060e3)
GL_EXTENSIONS	GL_ANGLE_client_arrays GL_ANGLE_depth_texture GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_pack_reverse_row_order GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_float GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc_srgb GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_norm16 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_EGL_image_external_essl3 GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object
Disabled Extensions	GL_KHR_blend_equation_advanced GL_KHR_blend_equation_advanced_coherent
Window system binding vendor	Google Inc. (adapter LUID: 0000000000008751)
Window system binding version	1.4 (ANGLE 2.1.0.461d9a3060e3)
Window system binding extensions	EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_EXT_pixel_format_float EGL_ANGLE_display_texture_share_group EGL_ANGLE_create_context_client_arrays
Direct rendering	Yes
Reset notification strategy	0x8252
GPU process crash count	0
Compositor Information
Tile Update Mode	One-copy
Partial Raster	Enabled
GpuMemoryBuffers Status
ATC	Software only
ATCIA	Software only
DXT1	Software only
DXT5	Software only
ETC1	Software only
R_8	Software only
RG_88	Software only
BGR_565	Software only
RGBA_4444	Software only
RGBX_8888	Software only
RGBA_8888	Software only
BGRX_8888	Software only
BGRA_8888	Software only
YVU_420	Software only
YUV_420_BIPLANAR	Software only
UYVY_422	Software only
Diagnostics
0
b3DAccelerationEnabled	true
b3DAccelerationExists	true
bAGPEnabled	true
bAGPExistenceValid	true
bAGPExists	true
bCanRenderWindow	true
bDDAccelerationEnabled	true
bDriverBeta	false
bDriverDebug	false
bDriverSigned	false
bDriverSignedValid	false
bNoHardware	false
dwBpp	32
dwDDIVersion	11
dwHeight	1200
dwRefreshRate	59
dwWHQLLevel	0
dwWidth	1920
iAdapter	0
lDriverSize	39862352
lMiniVddSize	0
szAGPStatusEnglish	Enabled
szAGPStatusLocalized	Enabled
szChipType	Intel(R) HD Graphics Family
szD3DStatusEnglish	Enabled
szD3DStatusLocalized	Enabled
szDACType	Internal
szDDIVersionEnglish	11
szDDIVersionLocalized	11
szDDStatusEnglish	Enabled
szDDStatusLocalized	Enabled
szDXVAHDEnglish	Supported
szDXVAModes	ModeMPEG2_A ModeMPEG2_C ModeWMV9_C ModeVC1_C
szDescription	Intel(R) HD Graphics 530
szDeviceId	0x1912
szDeviceIdentifier	{D7B78E66-5A52-11CF-E262-B626BAC2D935}
szDeviceName	\\.\DISPLAY1
szDisplayMemoryEnglish	1824 MB
szDisplayMemoryLocalized	1824 MB
szDisplayModeEnglish	1920 x 1200 (32 bit) (59Hz)
szDisplayModeLocalized	1920 x 1200 (32 bit) (59Hz)
szDriverAssemblyVersion	20.19.15.4474
szDriverAttributes	Final Retail
szDriverDateEnglish	6/23/2016 13:05:00
szDriverDateLocalized	23. 6. 2016 13:05:00
szDriverLanguageEnglish	English
szDriverLanguageLocalized	English
szDriverModelEnglish	WDDM 1.1
szDriverModelLocalized	WDDM 1.1
szDriverName	igdumdim64.dll,igd10iumd64.dll,igd10iumd64.dll,igdumdim32,igd10iumd32,igd10iumd32
szDriverNodeStrongName	oem69.inf:IntelGfx.NTamd64.6.1:iSKLD_w7:20.19.15.4474:pci\ven_8086&dev_1912&subsys_06b91028
szDriverSignDate	
szDriverVersion	20.19.0015.4474
szKeyDeviceID	Enum\PCI\VEN_8086&DEV_1912&SUBSYS_06B91028&REV_06
szKeyDeviceKey	\Registry\Machine\System\CurrentControlSet\Control\Video\{B8F0D930-36D5-4BA0-ABA7-C1F5F08DF4CE}\0000
szManufacturer	Intel Corporation
szMiniVdd	n/a
szMiniVddDateEnglish	n/a
szMiniVddDateLocalized	n/a
szMonitorMaxRes	
szMonitorName	Dell U2412M(Digital)
szNotesEnglish	No problems found.
szNotesLocalized	No problems found.
szOverlayEnglish	Supported
szRankOfInstalledDriver	00E60001
szRegHelpText	
szRevision	
szRevisionId	0x0006
szSubSysId	0x06B91028
szTestResultD3D7English	Not run
szTestResultD3D7Localized	Not run
szTestResultD3D8English	Not run
szTestResultD3D8Localized	Not run
szTestResultD3D9English	Not run
szTestResultD3D9Localized	Not run
szTestResultDDEnglish	Not run
szTestResultDDLocalized	Not run
szVdd	n/a
szVendorId	0x8086
Log Messages
GpuProcessHostUIShim: The GPU process exited normally. Everything is okay.
 
PhotoStationError.PNG
1.6 MB View Download
Labels: Needs-Triage-M58
Cc: sande...@chromium.org
Labels: -OS-Windows OS-All
Owner: dalecur...@chromium.org
Status: Assigned (was: Unconfirmed)
Is this video edited or remuxed?

It has negative video timestamps which are invalid. We've stopped silently correcting this recently since it leads to a/v sync issues.
I didn't edited it or touch it. It is straight from the camera. I'm not sure how video timestamp becomes negative. How can I check it? 
chrome://media-internals shows an error "unfixable negative timestamp" when that video is played. If you're familiar with ffmpeg tools, you can see this using "ffprobe -show_packets <video> | less" or a similar command.

That's concerning that it's straight off of a camera, we may have to support this workaround even at the cost of a/v sync then. I wonder if the camera wrote an edit list into the clip which is shifting the time negative or if it's an ffmpeg bug.
I used a Synology application for uploading photos and videos and this application generate thumbnails and low resolution videos with PC power and upload them directly to Synology NAS. Maybe this application made some changes to the video files. I will try to make a short video and check with the command from ffmpeg tools you suggested, but it will take some time as I haven't used it. Or if it helps I can share some video via google drive which comes straight from the camera. Thanks.
I am having the same problem. On Chrome 58 the videos directly from the camera no longer play. After the user uploads them we run them through ffmpeg, and everything works fine. 

Our software lets users preview the file locally before uploading it. This functionality is completely broken with this update. We have had to email all of our customers telling them we no longer support Chrome. 

Below is a link to a video file that was taken directly from a Canon Vixia Video Camera and will not play in the Chrome 58 Browser.
https://videocdn.blob.core.windows.net/videos/nonFormattedMetaData.mp4

Thanks will take a look, it seems like we'll have to silently fixup these videos given the number of reports. This likely means there will be av sync issues. I will take a look and see what we can do here.
I analyzed the metadata of these files, and they are different from  issue 715398  where it was clear that the metadata was wrong.

In these three cases (7001A.mp4, MVI_5623.mp4, and nonFormattedMetaData.mp4), the first frame in presentation order is not the first frame in decode order. The metadata (and edit list in particular) correctly record this. However, FFmpeg is reporting that the first frame in decode order is at time 0 (therefore the first frame in presentation order has a negative timestamp).

Example (MVI_5623.mp4):
  Edit list: start time is 40 ms
  # PTS PTS (after edit) FFmpeg reported PTS
  - --- ---------------- -------------------
  1 120  80                0
  2  40   0              -80
  3  80  40              -40
  4 240 200              120
  5 160 120               40
  6 200 160               80
  7 360 320              240
  8 280 240              160

It seems that there is an actual bug here.
Tracked in ffmpeg by https://trac.ffmpeg.org/ticket/6421
Thanks for looking into this! 

I have tested this with many mp4 files coming directly from different video cameras(all were Canon video cameras), none of these files were playable on Chrome until I re-encoded them using ffmpeg.

Any suggestions for a temporary work around? I have an application with paying clients, that allow users to take a video file directly from the camera, preview them, and upload them. With this bug the application is unusable on Chrome. 

We have sent out communication telling the users to use Firefox, or IE for the time being. However, I am strongly hoping to get this taken care of ASAP. Before this bug we urged all of our users to use Chrome because Chrome has the best file upload performance of all the major browsers. 

Thanks!
The only workaround I am aware of here would be to play back using MSE. It's a simple change if the files are small enough to load into memory on the client size, otherwise it's probably easier to transcode.

(I'm not certain that these files meet the requirements of the MSE spec though, so I can't guarantee reliable results there either.)
Dear Chrome team, Good that you found the bug, but while all the affected parties are fixing the format issue. It would be nice if you can still support the viewing, during the transition period.
We are also experiencing the similar problem with latest Chrome v58 and v59 (beta) for files straight from the camera. As of now, we have requested our customer to refrain from Chrome upgrade.

We would really appreciate if you can please share your plan to release the fix for this issue?
I've pinged the ffmpeg ticket for updates. If I don't hear back today we'll likely proceed with a workaround until a fix is available. Keep in mind any workaround will likely cause av sync issues.
 Issue 728787  has been merged into this issue.
FWIW, disabling edit lists in ffmpeg allows all of these files to play; so it's definitely some error in how the edit lists are being applied causing the problems. I wonder if we should just disable edit lists (first enabled on ~Sep 2016, M57 I think.) 
Any news on an ETA for fix in Chrome?  I see ffmpeg bug tracker posted a fix a few days ago.

Unfortunately the version of ffmpeg we have in Chrome right now doesn't have the capabilities described in the bug. I also don't think we'll be able to merge a fix back to M59 in time for stable, but we'll definitely land a fix for M61/M60 shortly though.
OK, what about disabling edit lists in M59 as an interim workaround?  Based on release history I guess that 60/61 are several weeks away from stable channel, right? 

We can't disable edit lists entirely and Chrome 59 does not have the ability to just disable advanced edit lists; only 60+ will have that code.

So we have to see how big of a patch we need to cherry-pick back to 59 which just went stable and is a bit problematic for a bug like this which doesn't have a lot of affected clients. We're still investigating the options though and will update here as we know more.
 Issue 730243  has been merged into this issue.
Is there any way we can detect when this issue is occurring with Javascript? It would be nice to tell the user what is going on, vs showing a broken video player.
The playback will through an error event when this occurs; so if you add an event listener for that you'll receive the event. You could also check the MediaError message: https://www.chromestatus.com/feature/4996058069336064
Project Member

Comment 24 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/916a8290de5e9e41873282f01e11ffa7606c1531

commit 916a8290de5e9e41873282f01e11ffa7606c1531
Author: John Rummell <jrummell@chromium.org>
Date: Thu Jun 08 04:35:03 2017

Workaround for negative PTS values in video files.

In some videos uploaded from cameras, the first frame in presentation order
is not the first frame in decode order. The metadata correctly records this.
However, FFmpeg is adjusting timestamps so that the first frame in decode
order is at time 0. As a result, the first frame in presentation order has
a negative timestamp, which produces an error.

The workaround is to pass "advanced_editlist=0" in the demuxer options.
This avoids the problem until FFmpeg fixes it properly.

BUG= 723537 
TEST=tested locally with example from comment #6 in the bug

Change-Id: I2b515dff06da2930339592ff4e84ec69da635c91
Reviewed-on: https://chromium-review.googlesource.com/526752
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477887}
[modify] https://crrev.com/916a8290de5e9e41873282f01e11ffa7606c1531/media/filters/ffmpeg_glue.cc

I applied the above workaround on top of Chromium 59.0.3071.86. The example video in this bug report plays fine now, but I'm still seeing playback errors on IMDb. [1]

chrome://media-internals shows the same "unfixable negative timestamp" error. It seems weird that one video works and another doesn't.

If I build Chromium 59.0.3071.86 with its bundled FFmpeg then the IMDb video works; the issue only occurs when using the system FFmpeg (version 3.3.1).

[1] http://www.imdb.com/title/tt5158522/videoplayer/vi327071257
Your system ffmpeg probably isn't new enough to have the option in c#24, that commit came in March 2017:

http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ef71dc7948322254d1f0fa41218b91f2da0279d9
It's not that; we have FFmpeg 3.3.1 in Arch Linux which includes that commit.

Thing is, applying the workaround in Chromium 59 fixes playback for the two example videos in this bug; however, it doesn't fix the IMDb video. I expected that it would, since it shows the same error (and the issue first appeared with Chromium 58).

Are you unable to repro with the example IMDb trailer I linked in my previous comment?
Hmm, that video doesn't trigger a negative timestamp issue in Chrome 58, so it seems like it's failing for some other reason than the root cause of this issue.

We do have a few patches in our mov demuxer that upstream has not taken or fixed:
https://cs.chromium.org/chromium/src/third_party/ffmpeg/chromium/patches/README?l=64

We don't provide support for use_system_ffmpeg, so YMMV with that option unfortunately. The best I can do is to suggest looking over those patches to figure out what the difference is. You might also try building with use_system_ffmpeg and then running media_unittests to track down a more specific failure case.
Fair enough. Just to clarify:

- Chromium 58/59 won't play that IMDb video when using system FFmpeg 3.3+ (haven't tested earlier FFmpeg versions)
- Chromium 58/59 using the bundled FFmpeg has no issue playing the same IMDb video

I will stop commenting now since I understand this issue is about Chrome and the added workaround does fix the test videos on Chromium as well. I guess the IMDb issue I'm seeing is different, even though it results in the same error message.
One more note; the difference seems to be the start time estimates Chrome calculates using internal FFmpeg structures. Problem is, we have to disable that block of code for compiling against the system's FFmpeg. [1]

I have filed  https://crbug.com/731766  if anyone cares to follow up on that.

[1] https://chromium.googlesource.com/chromium/src.git/+/44fbc4d877cf871eb8d736b4c53a05bb11588931%5E%21/
Labels: TE-Verified-M61 TE-Verified-61.0.3128.0
Tested the issue on windows 7, Ubuntu 14.04 and Mac 10.12.6 using chrome version 61.0.3128.0 with the below steps

1. Opened URL https://home.hdhome.sk/photo/?t=Albums/album_32303137/album_323031372f30352e30312044726f7a64696b/video_323031372f30352e30312044726f7a64696b_4d56495f353632332e6d7034#Albums/album_32303137/album_323031372f30352e30312044726f7a64696b/video_323031372f30352e30312044726f7a64696b_4d56495f353632332e6d7034
2.Switched video quality to original
3. Video played fine, not observed any error.

Please find the attached screen cast for the same.
Adding TE-Verified labels.

Thanks, 
723537.mp4
7.9 MB View Download
Cc: dalecur...@chromium.org pbomm...@chromium.org
 Issue 734570  has been merged into this issue.
Project Member

Comment 34 by sheriffbot@chromium.org, Jun 19 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Approved-60
approving merge to M60. 
Project Member

Comment 36 by bugdroid1@chromium.org, Jun 23 2017

Labels: merge-merged-m60-cherry-picks
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/5d4a0ad7502907e15f207a487a4a1e563e5e01b5

commit 5d4a0ad7502907e15f207a487a4a1e563e5e01b5
Author: Chris Cunningham <chcunningham@chromium.org>
Date: Fri Jun 23 21:28:45 2017

lavf/mov.c: Add -advanced_editlist option for mov format.

Adding an MOV format option to turn on/off the editlist supporting code, introduced in https://github.com/FFmpeg/FFmpeg/commit/ca6cae73db207f17a0d5507609de12842d8f0ca3

Signed-off-by: Sasi Inguva <isasi@google.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit ef71dc7948322254d1f0fa41218b91f2da0279d9)
Bug:  723537 
Change-Id: I2723eee5714ab7bc8d956b5f7bbc15ec85cfd496
TBR=dalecurtis@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/547039
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>

[modify] https://crrev.com/5d4a0ad7502907e15f207a487a4a1e563e5e01b5/libavformat/isom.h
[modify] https://crrev.com/5d4a0ad7502907e15f207a487a4a1e563e5e01b5/libavformat/mov.c

Project Member

Comment 37 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/c25e370edd01771ad2815381231c1a3ae564ecc2

commit c25e370edd01771ad2815381231c1a3ae564ecc2
Author: Chris Cunningham <chcunningham@chromium.org>
Date: Fri Jun 23 22:18:38 2017

Project Member

Comment 38 by bugdroid1@chromium.org, Jun 23 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b47983aa200f52f152b3bb7b751ef78833e2bc9

commit 0b47983aa200f52f152b3bb7b751ef78833e2bc9
Author: Chris Cunningham <chcunningham@chromium.org>
Date: Fri Jun 23 22:26:14 2017

Workaround for negative PTS values in video files.

In some videos uploaded from cameras, the first frame in presentation order
is not the first frame in decode order. The metadata correctly records this.
However, FFmpeg is adjusting timestamps so that the first frame in decode
order is at time 0. As a result, the first frame in presentation order has
a negative timestamp, which produces an error.

The workaround is to pass "advanced_editlist=0" in the demuxer options.
This avoids the problem until FFmpeg fixes it properly.

BUG= 723537 
TEST=tested locally with example from comment #6 in the bug

(cherry picked from commit 916a8290de5e9e41873282f01e11ffa7606c1531)
TBR=jrummell@chromium.org

Change-Id: I2b515dff06da2930339592ff4e84ec69da635c91
Reviewed-on: https://chromium-review.googlesource.com/526752
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#477887}
Reviewed-on: https://chromium-review.googlesource.com/546916
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#457}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/0b47983aa200f52f152b3bb7b751ef78833e2bc9/media/filters/ffmpeg_glue.cc

Status: Fixed (was: Assigned)
Workaround merged to m60.
Labels: M-60
Labels: TE-Verified-M60 TE-Verified-60.0.3112.50
Tested the issue on windows 7, Ubuntu 14.04 and Mac 10.12.6 using chrome version 60.0.3112.50 video played fine without any error.

Please find the attached screen cast for the same.
Adding TE-Verified labels.

Thanks, 
723537.mp4
3.4 MB View Download
Just updated to Chrome 60 and everything is back to normal! Thank you for fixing this! We are glad to be able to support Chrome again.

Sign in to add a comment