New issue
Advanced search Search tips

Issue 723502 link

Starred by 1 user
Status: Assigned
Owner:
shimazu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Fix unittests: create ServiceWorkerProviderHost in a correct way when --browser-side-navigation is turned on.

Project Member Reported by shimazu@chromium.org, May 17 2017 
Currently most of unit tests for service workers don't care about the --browser-side-navigation flag when creating ServiceWorkerProviderHost. It might be possible to reduce the test coverage because SWProviderHost should be created in a different way by using PreCreateNavigationHost/CompleteNavigationInitialized when the flag is on.

Comment 1 by shimazu@chromium.org, May 17 2017

Description: Show this description

Comment 2 by shimazu@chromium.org, May 17 2017

Summary: Fix unittests: create ServiceWorkerProviderHost in a correct way when --browser-side-navigation is turned on. (was: Create ServiceWorkerProviderHost in a correct way when --browser-side-navigation is turned on.)

Comment 3 by falken@chromium.org, Aug 3 2017 

shimazu@: Did your browser-side provider host creation patch basically fix this? If not, can you point out specific unit tests to fix?

Comment 4 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Available)
►

Sign in to add a comment