New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723461 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Layout tests failure ; mojo/module-loading(-manual-deps-loading).html

Project Member Reported by peria@chromium.org, May 17 2017

Issue description

Two layout tests mojo/module-loading.html and mojo/module-loading-manual-deps-loading.html are failing (timeout) on all platforms.

e.g.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/52495
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/46241
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/8802
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/1659

yzshen@, your are the only person who touches files under mojo.
Could you take a look? Or please re-assign better owner if you know.
 

Comment 1 by peria@chromium.org, May 17 2017

Status: Fixed (was: Assigned)
Oh, sorry. You already reverted the suspected CL.
https://chromium.googlesource.com/chromium/src/+/02e69c4cd874078942ece36ee76383c1d6965f4b

Comment 2 by kolos@chromium.org, May 17 2017

Cc: xhw...@chromium.org
Status: Available (was: Fixed)
mojo/module-loading(-manual-deps-loading).html still fail. 

Possible culprits:
https://codereview.chromium.org/2884163002
https://codereview.chromium.org/2886683003

I will revert both.
Project Member

Comment 3 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36e3810d369c449a7f6659addd6697f7e81132a4

commit 36e3810d369c449a7f6659addd6697f7e81132a4
Author: kolos <kolos@chromium.org>
Date: Wed May 17 09:59:15 2017

Revert of media: Shutdown AudioManager in TestMojoMediaClient (patchset #3 id:40001 of https://codereview.chromium.org/2886683003/ )

Reason for revert:
Layout tests failure ; mojo/module-loading(-manual-deps-loading).html

BUG= 723461 

Original issue's description:
> media: Shutdown AudioManager in TestMojoMediaClient
>
> By AudioManager API, Shutdown() must be called before destruction. This
> isn't caught by tests because media_service_unittests is only run on
> release builds.
>
> Review-Url: https://codereview.chromium.org/2886683003
> Cr-Commit-Position: refs/heads/master@{#472225}
> Committed: https://chromium.googlesource.com/chromium/src/+/6e0f47b9cc33450f93d02d238cd4e60dffa89421

TBR=alokp@chromium.org,xhwang@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2890733004
Cr-Commit-Position: refs/heads/master@{#472404}

[modify] https://crrev.com/36e3810d369c449a7f6659addd6697f7e81132a4/media/mojo/services/test_mojo_media_client.cc

Project Member

Comment 4 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ca49acbd1483c0e82be1a546168c5740231d908

commit 0ca49acbd1483c0e82be1a546168c5740231d908
Author: kolos <kolos@chromium.org>
Date: Wed May 17 09:59:53 2017

Revert of media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService (patchset #1 id:1 of https://codereview.chromium.org/2884163002/ )

Reason for revert:
Layout tests failure ; mojo/module-loading(-manual-deps-loading).html

BUG= 723461 

Original issue's description:
> media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService
>
> Previously InterfaceFactoryImpl instances are using SrongBinding such
> that they will only be destroyed on connection error. However, we could
> hit an issue when MediaService is being destructed, the MojoMediaClient
> is already destroyed, and an InterfaceFactoryImpl still tries to access
> the MojoMediaClient.
>
> This CL ensures that when MediaService is being destructed, all
> InterfaceFactoryImpl will also be destroyed to avoid the issue.
>
> BUG=721965
>
> Review-Url: https://codereview.chromium.org/2884163002
> Cr-Commit-Position: refs/heads/master@{#472261}
> Committed: https://chromium.googlesource.com/chromium/src/+/5223bd13f8a97e293361a3b9b2cc31101ba597da

TBR=alokp@chromium.org,xhwang@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=721965

Review-Url: https://codereview.chromium.org/2892563002
Cr-Commit-Position: refs/heads/master@{#472405}

[modify] https://crrev.com/0ca49acbd1483c0e82be1a546168c5740231d908/media/mojo/services/media_service.cc
[modify] https://crrev.com/0ca49acbd1483c0e82be1a546168c5740231d908/media/mojo/services/media_service.h

Comment 5 by yzshen@chromium.org, May 17 2017

Status: Fixed (was: Available)
I believe this failure was caused by my CL, not the others. Sorry!

The bots are green after my revert. (I cannot find which were still failing after my revert. Would you please point me to them, kolos?)


Marking this as fixed.

Comment 6 by xhw...@chromium.org, May 17 2017

yzshen: Thanks for the update. I'll reland my two CLs then.

Comment 7 by yzshen@chromium.org, May 17 2017

Sorry for all the trouble, Xiaohan!
Project Member

Comment 8 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecb8e8c1f22d894ac2fcec89a968f248b988d8c5

commit ecb8e8c1f22d894ac2fcec89a968f248b988d8c5
Author: xhwang <xhwang@chromium.org>
Date: Wed May 17 16:20:22 2017

Reland of media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService (patchset #1 id:1 of https://codereview.chromium.org/2892563002/ )

Reason for revert:
This was not the cause of the failure, which has been fixed by reverting other CLs. See BUG for details.

Original issue's description:
> Revert of media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService (patchset #1 id:1 of https://codereview.chromium.org/2884163002/ )
>
> Reason for revert:
> Layout tests failure ; mojo/module-loading(-manual-deps-loading).html
>
> BUG= 723461 
>
> Original issue's description:
> > media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService
> >
> > Previously InterfaceFactoryImpl instances are using SrongBinding such
> > that they will only be destroyed on connection error. However, we could
> > hit an issue when MediaService is being destructed, the MojoMediaClient
> > is already destroyed, and an InterfaceFactoryImpl still tries to access
> > the MojoMediaClient.
> >
> > This CL ensures that when MediaService is being destructed, all
> > InterfaceFactoryImpl will also be destroyed to avoid the issue.
> >
> > BUG=721965
> >
> > Review-Url: https://codereview.chromium.org/2884163002
> > Cr-Commit-Position: refs/heads/master@{#472261}
> > Committed: https://chromium.googlesource.com/chromium/src/+/5223bd13f8a97e293361a3b9b2cc31101ba597da
>
> TBR=alokp@chromium.org,xhwang@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=721965
>
> Review-Url: https://codereview.chromium.org/2892563002
> Cr-Commit-Position: refs/heads/master@{#472405}
> Committed: https://chromium.googlesource.com/chromium/src/+/0ca49acbd1483c0e82be1a546168c5740231d908

TBR=alokp@chromium.org,kolos@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 723461 

Review-Url: https://codereview.chromium.org/2887153002
Cr-Commit-Position: refs/heads/master@{#472469}

[modify] https://crrev.com/ecb8e8c1f22d894ac2fcec89a968f248b988d8c5/media/mojo/services/media_service.cc
[modify] https://crrev.com/ecb8e8c1f22d894ac2fcec89a968f248b988d8c5/media/mojo/services/media_service.h

Project Member

Comment 9 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44f871a7d7cb39ef8bda0aaf75ac31194463f50a

commit 44f871a7d7cb39ef8bda0aaf75ac31194463f50a
Author: xhwang <xhwang@chromium.org>
Date: Wed May 17 16:22:30 2017

Reland of media: Shutdown AudioManager in TestMojoMediaClient (patchset #1 id:1 of https://codereview.chromium.org/2890733004/ )

Reason for revert:
This was not the cause of the failure, which has been fixed by reverting other CLs. See BUG for details.

Original issue's description:
> Revert of media: Shutdown AudioManager in TestMojoMediaClient (patchset #3 id:40001 of https://codereview.chromium.org/2886683003/ )
>
> Reason for revert:
> Layout tests failure ; mojo/module-loading(-manual-deps-loading).html
>
> BUG= 723461 
>
> Original issue's description:
> > media: Shutdown AudioManager in TestMojoMediaClient
> >
> > By AudioManager API, Shutdown() must be called before destruction. This
> > isn't caught by tests because media_service_unittests is only run on
> > release builds.
> >
> > Review-Url: https://codereview.chromium.org/2886683003
> > Cr-Commit-Position: refs/heads/master@{#472225}
> > Committed: https://chromium.googlesource.com/chromium/src/+/6e0f47b9cc33450f93d02d238cd4e60dffa89421
>
> TBR=alokp@chromium.org,xhwang@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Review-Url: https://codereview.chromium.org/2890733004
> Cr-Commit-Position: refs/heads/master@{#472404}
> Committed: https://chromium.googlesource.com/chromium/src/+/36e3810d369c449a7f6659addd6697f7e81132a4

TBR=alokp@chromium.org,kolos@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 723461 

Review-Url: https://codereview.chromium.org/2886193002
Cr-Commit-Position: refs/heads/master@{#472470}

[modify] https://crrev.com/44f871a7d7cb39ef8bda0aaf75ac31194463f50a/media/mojo/services/test_mojo_media_client.cc

yzshen: No worries! And, I didn't know reverting/relanding CLs are landed so quickly :)

Sign in to add a comment