New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723411 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Audit is not performed after clicking on 'Perform an audit' button.

Reported by rp...@etouch.net, May 17 2017

Issue description

Version: 60.0.3102.0 1b9cbad892fea821579566528be23955f159555c-refs/heads/master@{#472262}
OS: Windows (7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome, navigate to NTP and open devtools and go to 'Audit' section and keep it open.
2. Now open new NTP and again go to 'Audit' section and click on 'Perform an audit' button,observe

Actual: Audit is not performed after clicking on 'Perform an audit' button
Expected: Audit should be performed after clicking on 'Perform an audit' button

This is a non-regression issue, seen from M-60 series as new feature in 'Audit' appears from build # 60.0.3102.0

Kindly review the attached screenshot for reference.
 
Actual_video.mp4
826 KB View Download
Cc: pfeldman@chromium.org
Status: Untriaged (was: Unconfirmed)
Changing the status to Untriaged, so that the issue would get addressed.
Thank You.

Comment 2 by rp...@etouch.net, May 17 2017

Labels: OS-Linux OS-Mac

Comment 3 by l...@chromium.org, May 17 2017

Cc: paulir...@chromium.org
Owner: pfeldman@chromium.org
Status: Assigned (was: Untriaged)
Thanks for the report.  It doesn't happen all the time, but after just a couple runs I can reproduce.  pfeldman@, could you please take a look?

DevTools on DevTools error:

chrome-devtools-frontend.appspot.com/serve_file/@1b9cbad…/audits2_worker/audits2_worker_module.js:3170 Error: Protocol error (Tracing.start): Tracing is already started
    at callback.resolve.Promise.resolve.then._ (chrome-devtools-frontend.appspot.com/serve_file/@1b9cbad…/audits2_worker/audits2_worker_module.js:508)
    at <anonymous>
(anonymous)	@	chrome-devtools-frontend.appspot.com/serve_file/@1b9cbad…/audits2_worker/audits2_worker_module.js:3170
Promise rejected (async)		
Promise.catchException	@	chrome-devtools-frontend.appspot.com/serve_file/@1b9cbad…/audits2_worker/audits2_worker_module.js:3170
start	@	chrome-devtools-frontend.appspot.com/serve_file/@1b9cbad…/audits2_worker/audits2_worker_module.js:5412
_dispatchMessage	@	audits2_worker.js:149
_dispatchMessageWrapped	@	audits2_worker.js:143
_onMessage	@	audits2_worker.js:158
Cc: caseq@chromium.org phulce@chromium.org
+caseq, check out comment #3. Sounds like we almost got a repro. :)
Owner: paulir...@chromium.org
Owner: phulce@chromium.org
Exception is about having two tabs open to the same site. 
The error isn't surfaced to the user so they don't know.

@luoe, can you file as a separate ticket? Also, in it can you repro this "Tracing is already started" bug reliably? 

Comment 8 by phulce@chromium.org, May 18 2017

The reporting as an error should be fixed by https://codereview.chromium.org/2886073002/, fix for failing on NTP is separate
Project Member

Comment 9 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23da751ab184c42ed88c67e150c316878105211e

commit 23da751ab184c42ed88c67e150c316878105211e
Author: phulce <phulce@chromium.org>
Date: Wed May 24 04:14:56 2017

DevTools: Disable Audits2 buttons when service worker is active

* Displays help text on the dialog when a service worker is active or no category is selected
* Disables the dialog start button when a service worker is active

BUG= 723411 

Review-Url: https://codereview.chromium.org/2901133002
Cr-Commit-Position: refs/heads/master@{#474158}

[modify] https://crrev.com/23da751ab184c42ed88c67e150c316878105211e/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
[modify] https://crrev.com/23da751ab184c42ed88c67e150c316878105211e/third_party/WebKit/Source/devtools/front_end/audits2/audits2Dialog.css
[modify] https://crrev.com/23da751ab184c42ed88c67e150c316878105211e/third_party/WebKit/Source/devtools/front_end/worker_service/ServiceDispatcher.js

Status: Fixed (was: Assigned)
Labels: TE-Verified-60.0.3112.7 TE-Verified-M60
Tested the issue on Mac 10.12.4,Ubuntu 14.04 & windows 7 using chrome dev version#60.0.3112.7 with the steps mentioned in comment #0 and the fix provided in comment#9.

Observed below as per the fix:
-----------------------------
1.Displayed help text ( "Multiple tabs are being controlled by the same service worker. Close your other tabs on the same origin to audit this page") on the second tab when we click on "Perform an audit" button.

2.' Run Audit' button is in disable mode in the second tab

Hence adding TE-Verified labels.

Please find the attached screencast for the same.
Thanks!!
723411.mp4
1.1 MB View Download

Sign in to add a comment