New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723399 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Unnecessary 'Audits to perform' overlay is seen after clicking on Cancel button.

Reported by db...@etouch.net, May 17 2017

Issue description

Chrome Version: 60.0.3102.0 Revision 1b9cbad892fea821579566528be23955f159555c-refs/heads/master@{#472262}
OS: Windows(7,8,10)

What steps will reproduce the problem?
(1) Launch chrome, open dev tools and navigate to Audits section.
(2) Click on Perform an audit button(Audits to perform overlay seen),then click on cancel button.
(3) Observe.

Actual: Unnecessary 'Audits to perform' overlay is seen after clicking on Cancel button.

Expected: 'Audits to perform' overlay should not seen.

This is a non-regression issue seen from 'M-60'(60.0.3102.0)
 
Actual_video.mp4
490 KB View Download
Status: Untriaged (was: Unconfirmed)
Changing the status to Untriaged, so that the issue would get addressed.
Thank You.
Owner: paulir...@chromium.org
Status: Assigned (was: Untriaged)
Cc: paulir...@chromium.org
Owner: pfeldman@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93262850d71a2091db3295a8fb88cbcce5af14cc

commit 93262850d71a2091db3295a8fb88cbcce5af14cc
Author: pfeldman <pfeldman@chromium.org>
Date: Fri May 19 19:36:23 2017

DevTools: do not hide run audit dialog upon canceling the audit, allow it being re-run.

BUG= 723399 

Review-Url: https://codereview.chromium.org/2886903006
Cr-Commit-Position: refs/heads/master@{#473278}

[modify] https://crrev.com/93262850d71a2091db3295a8fb88cbcce5af14cc/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js

Cc: krajshree@chromium.org
Labels: Needs-Feedback
Tested the issue on Win-10 using chrome dev version #60.0.3107.4.

Following are the steps followed to test the issue.
------------
1. Launched chrome, opened dev tools and navigated to Audits section.
2. Clicked on "Run audit" button(Audits to perform overlay seen),then clicked on cancel button.
3. Observed that 'Audits to perform' overlay is seen after clicking the cancel button. (As per comment #4).

Attached a screen cast for reference.

pfeldman@ - Could you please verify the screen cast and please let us know if it is the expected behaviour.

Thanks...!!
723399.mp4
958 KB View Download
Status: Fixed (was: Assigned)

Comment 7 by hdodda@chromium.org, May 30 2017

Cc: hdodda@chromium.org
Labels: TE-Verified-60.0.3112.7 TE-Verified-M60
Tested the issue on windows 7 using Chrome M60 #60.0.3112.7 and this seems working as expected.

AS per CL descrption in comment #4 , 

DevTools: do not hide run audit dialog upon canceling the audit, allow it being re-run.

This is working as expected and hence adding TE-Verified Labels.

Thanks!

Sign in to add a comment