New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723353 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Make VDA and VEA autotest results more readable

Project Member Reported by wuchengli@chromium.org, May 17 2017

Issue description

Now the fail reason is always like this. People need to look into the logs and see which test case failed. We should use the failed test case in the reason instead.

video_encode_accelerator_unittest failed! Command <HOME=/tmp/tmp2BHmvE CR_SOURCE_ROOT=/usr/local/autotest/deps/chrome_test/test_src CHROME_DEVEL_SANDBOX=/opt/google/chrome/chrome-sandbox /usr/local/autotest/deps/chrome_test/test_src/out/Release/video_encode_accelerator_unittest --test_stream_data="/usr/local/autotest/tmp/tmpx0pwgs_video_VideoEncodeAccelerator/tulip2-320x180-55be7124b3aec1b72bfb57f433297193.yuv:320:180:11:/usr/local/autotest/tmp/tmpx0pwgs_video_VideoEncodeAccelerator/tulip2-320x180-55be7124b3aec1b72bfb57f433297193.yuv.out:100000" --ozone-platform=gbm> failed, rc=1, Command returned non-zero exit status
 
This issue is about video_VideoDecodeAccelerator and video_VideoEncodeAccelerator . wmatrix has a column that shows failure reasons.

Comment 2 by kcwu@chromium.org, May 17 2017

Status: Started (was: Assigned)
Thanks for filing bug for me ;)
Actually I started to prepare a CL to tackle this problem.

My plan is setenv GTEST_OUTPUT and parse the result in ChromeBinaryTest.
Project Member

Comment 4 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/aa61f91339f39a7240583f9dd6e9273b7f8101b4

commit aa61f91339f39a7240583f9dd6e9273b7f8101b4
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Mon May 22 10:20:40 2017

autotest: parse error reason for ChromeBinaryTest

This makes error reason easier to find and grouping in dashboard.

BUG= chromium:723353 
TEST=video_VideoDecodeAccelerator and video_VideoEncodeAccelerator

Change-Id: Idbc3fc7fc5d1a38cf51f93e9b489faf95cbc7de5
Reviewed-on: https://chromium-review.googlesource.com/509372
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Pin-chih Lin <johnylin@chromium.org>

[modify] https://crrev.com/aa61f91339f39a7240583f9dd6e9273b7f8101b4/client/cros/chrome_binary_test.py

Project Member

Comment 5 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4cec5bbc59d81df737889ada680ba8360c988be6

commit 4cec5bbc59d81df737889ada680ba8360c988be6
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Wed May 24 06:59:26 2017

autotest: join multi-line reasons into single line

Because the dashboard only shows the first line

BUG= chromium:723353 
TEST=video_VideoDecodeAccelerator and video_VideoEncodeAccelerator

Change-Id: I6ff9c77d6feeac56bd6b2699c8b804209121fff3
Reviewed-on: https://chromium-review.googlesource.com/512242
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Pin-chih Lin <johnylin@chromium.org>

[modify] https://crrev.com/4cec5bbc59d81df737889ada680ba8360c988be6/client/cros/chrome_binary_test.py

Comment 6 by kcwu@chromium.org, May 25 2017

Labels: Merge-Request-58 Merge-Request-59
Project Member

Comment 7 by sheriffbot@chromium.org, May 25 2017

Labels: -Merge-Request-59 Merge-Review-59 Hotlist-Merge-Review
This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by kcwu@chromium.org, May 31 2017

Cc: gkihumba@chromium.org
Hi Grace, IIUC, this need your approval.

The CLs mentioned in comment 4 and 5 are just changing message of test. They are harmless to stability to ChromeOS and actually they are helpful for monitoring test failures.


Labels: Merge-Approved-59
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 2 2017

Labels: merge-merged-release-R59-9460.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6f55509b6200785cbbf0ed391b9489e1c0ead084

commit 6f55509b6200785cbbf0ed391b9489e1c0ead084
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Fri Jun 02 09:20:56 2017

autotest: parse error reason for ChromeBinaryTest

This makes error reason easier to find and grouping in dashboard.

BUG= chromium:723353 
TEST=video_VideoDecodeAccelerator and video_VideoEncodeAccelerator

Change-Id: Idbc3fc7fc5d1a38cf51f93e9b489faf95cbc7de5
Reviewed-on: https://chromium-review.googlesource.com/509372
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Pin-chih Lin <johnylin@chromium.org>
(cherry picked from commit aa61f91339f39a7240583f9dd6e9273b7f8101b4)
Reviewed-on: https://chromium-review.googlesource.com/522269
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Commit-Queue: Kuang-che Wu <kcwu@chromium.org>
Trybot-Ready: Kuang-che Wu <kcwu@chromium.org>

[modify] https://crrev.com/6f55509b6200785cbbf0ed391b9489e1c0ead084/client/cros/chrome_binary_test.py

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d89b147e93260300c54dd1552e08bd8109b3fb84

commit d89b147e93260300c54dd1552e08bd8109b3fb84
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Fri Jun 02 09:26:01 2017

autotest: join multi-line reasons into single line

Because the dashboard only shows the first line

BUG= chromium:723353 
TEST=video_VideoDecodeAccelerator and video_VideoEncodeAccelerator

Change-Id: I6ff9c77d6feeac56bd6b2699c8b804209121fff3
Reviewed-on: https://chromium-review.googlesource.com/512242
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Pin-chih Lin <johnylin@chromium.org>
(cherry picked from commit 4cec5bbc59d81df737889ada680ba8360c988be6)
Reviewed-on: https://chromium-review.googlesource.com/522270
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Commit-Queue: Kuang-che Wu <kcwu@chromium.org>
Trybot-Ready: Kuang-che Wu <kcwu@chromium.org>

[modify] https://crrev.com/d89b147e93260300c54dd1552e08bd8109b3fb84/client/cros/chrome_binary_test.py

Comment 12 by kcwu@chromium.org, Jun 2 2017

Status: Fixed (was: Started)
Project Member

Comment 13 by sheriffbot@chromium.org, Jun 5 2017

Cc: gkihumba@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 14 by kcwu@chromium.org, Jun 5 2017

Labels: -Merge-Request-58 -Merge-Approved-59
Labels: VerifyIn-61
Cc: avkodipelli@chromium.org
Status: Verified (was: Fixed)

Sign in to add a comment