New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723293 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 815385
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Virtual keyboard did not respond when setting up PIN code for unlock.

Project Member Reported by fukino@chromium.org, May 17 2017

Issue description

Chrome Version: 60.0.3101.0 (Official Build) canary (32-bit)
OS: Chrome OS

What steps will reproduce the problem?
(1) Enable PIN unlock from chrome://flags#quick-unlock-pin
(2) Open chrome://settings > People > Screen Lock
(3) Click the radio button for "PIN or password" and click "SET UP PIN"
(4) Try to enter PIN using software keyboard.

What is the expected result?
The software keyboard is shown as number pad and works, or software keyboard is not shown.

What happens instead?
Full software keyboard is shown. The software keyboard did not respond on tapping numbers.

 
Screenshot 2017-05-17 at 13.16.44.png
48.4 KB View Download
Cc: yhanada@chromium.org
Owner: jdufault@chromium.org
Jacob, it looks like the input field is getting focused for keyboard. Could you have a look at that?
Cc: tbuck...@chromium.org
Labels: -Pri-2 Pri-1
Also raising priority if the bug as main use case for PIN is tablet and it means that it doesn't work well for tablet :) 

+tbuckley FYI and to make sure he agrees on prio.
Cc: sammiequon@chromium.org jdufault@chromium.org
Owner: sammiequon@chromium.org
+sammiequon who's been working on PIN Settings

Yes, agreed on prioritization. Though we're having trouble repro'ing -- we can enter a PIN using the virtual keyboard by either longpressing the top row of keys or switching to the number entry. We could not get the numbers to appear in the suggestion row as in the screenshot.

Using version 60.0.3102.0

Note that when this was built, there was no way to prevent the virtual keyboard from triggering when an input was focused and so some complicated workarounds were needed. Now that that's supported (see Issue 642513), we should hopefully be able to simplify the logic.
Any update?
Managed to repro on my scarlett (though that is on M59 version). Still not reproduce-able on Kevin. It seems maybe the VK needs to be in like the picture above with 123.... on a seperate row above; on Kevin it is 1q 2w 3e etc. 

oka/yhanada - How do you alter the VK to have the numbers on a seperate row? 
Cc: wuyingbing@chromium.org
I can repro this on my caroline, eve and scarlet (they are on M61). The layout with separated numerical row is loaded when focusing on an input field whose type is set to "password". I guess that the keyboard fails to see the input type of the PIN field for somewhat reason on your kevin.

+wuyingbing: Please correct me if I'm wrong.
Hmmm I got my hands on a caroline and eve whose password boxes would open the keyboard with the separate numerical row, but after updating chrome (to debug) this is no longer the case. And it is for all password boxes not just PIN one.
 
wuyingbing - Has this changed recently?
yhanada - I am able to reproduce this now -- it only shows up on the official build VK (the ones with the numbers on a seperate row). My debugging shows me that none of these keys on this VK emit keyCodes (the numbers at least). Is this something you or the VK team could look at?
Thank you for testing. I'll take a look at why key events aren't fired.

By the way, I thought that the goal of this issue is letting the VK not show when opening this view. Is this right?
Labels: -Pri-1 Pri-2
Owner: yhanada@chromium.org
Re #9 - Yes, not showing the VK is preferred and being done in  crbug.com/735289 , but users can still pop VK by clicking input. Lowering priority since  crbug.com/735289  will take care of most cases and reassigning.

Comment 11 Deleted

Comment 12 Deleted

Comment 13 by shend@chromium.org, Mar 19 2018

sammiequon@ or yhanada@, is the goal to prevent the virtual keyboard from popping up on that PIN text entry? Can we just use inputmode="none" here? Is that what  crbug.com/815385  is for?

Comment 14 by shend@chromium.org, Mar 19 2018

Just tried adding inputmode="none". VK still seems to trigger because the input type is "password" (works for without type="password"). Not sure if this is intentional...
Mergedinto: 815385
Status: Duplicate (was: Assigned)
shend@: Yes,  crbug.com/815385  looks the same issue.

Using inputmode="none" is simpler solution for preventing VK showing than doing asynchronous focusing, but it's internal clean-up rather than a bug.

Let's mark this bug as a duplicate of  issue 815385 

Sign in to add a comment