New issue
Advanced search Search tips

Issue 723259 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocked on:
issue 719331
issue 742695



Sign in to add a comment

Re-land "Make /deep/ as no-op" CL for M60, which was reverted due to ChromeOS Login UI's breakage

Project Member Reported by hayato@chromium.org, May 17 2017

Issue description

The context:
https://bugs.chromium.org/p/chromium/issues/detail?id=719331

- The original CL: https://codereview.chromium.org/2778983006
- The revert CL: https://codereview.chromium.org/2885153003/

When Chrome OS Login UI issue ( http://crbug.com/719331 ) is fixed, please make sure to re-land the reverted CL so that it is surely in M60.

If you are in trouble in re-landing, please feel free to notify me. I am happy to help you.

I am assigning this to alemate@ because I think alemate@ would work  http://crbug.com/719331  and will know when  bug 719331  is fixed.

 
Please tag with applicable OSs.  Thanks!
Cc: michae...@chromium.org

Comment 3 by hayato@chromium.org, May 18 2017

Labels: OS-All
The blocking bug: Issue 719331  seems to be specific to chromeOS, not blocking Desktop Dev release due to this.

Moving to RBS. Please change if needed.
Labels: -ReleaseBlock-Dev ReleaseBlock-Stable
alemate@ - Could you please provide any update on this issue as it has been marked as a stable blocker.

Thanks...!!

Comment 8 by hayato@chromium.org, Jun 22 2017

alemate@, I am also wondering the status. Could you please provide any update?
alemate@ - Friendly ping! Could you please provide any update on this issue as it has been marked as a stable blocker.

Thank You!
alemate@ - Gentle ping! Could you please provide any update on this issue as it has been marked as a stable blocker.

Thank You!
rkc@, alemate@

I have received several inquiries about the stautus of removing /deep/ at M60.
Could you update the status?
Blockedon: 742695
Status update: CL in CQ is currently blocked by 742695.
Can we push this back to M61?  We're a week away from Stable and this doesn't seem like it's impacting users.
Yeah, the risk is already high enough.

Web site owners should have enough time to test the removal of /deep/ using Chrome Canary or M60 beta, but we have not been able to provide this opportunity for these 2 months, blocked by CrOS.

Given that, I propose that we should push this back to M61 or M62. Let me decide it soon, and announce it, and update chromestatus. I need time to analyze the risk after I can get all information from CrOS team.

Maybe we should have a postmortem for this confusion. I had a private discussion with alemate@ and rkc@ in the last week, and I have asked them to update the progress many times. I don't want to see that this kind of confusion would happen again in the future.




Comment 15 Deleted

Comment 16 by r...@chromium.org, Jul 18 2017

I assigned this back to you because dpapad@ mentioned here (https://bugs.chromium.org/p/chromium/issues/detail?id=719331#c43) that there were 4 other references to iron-flex-layout.html. I don't know if it safe to reland this change, hence leaving it up to your judgment.

rkc@

Could you avoid "Restrict-View-Google" because this bug has been shared with external web developers? They want to know what is happening.

Comment 18 by r...@chromium.org, Jul 18 2017

Labels: -Restrict-View-Google
Project Member

Comment 19 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b160073dd51148f56b6586a9902b8a24674886c4

commit b160073dd51148f56b6586a9902b8a24674886c4
Author: Hayato Ito <hayato@chromium.org>
Date: Wed Jul 19 04:33:31 2017

Reland: Make /deep/ as no-op and remove ::shadow in dynamic profile

Reland the CL [1], which was reverted at [2], since CrOS's OOBE issue was fixed.

- [1]: https://codereview.chromium.org/2778983006
- [2]: https://codereview.chromium.org/2885153003

Bug:  489954 , 723259 
Change-Id: Ie162502385443a4e9a9cc80444c596458ad1e100
Reviewed-on: https://chromium-review.googlesource.com/575322
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487745}
[modify] https://crrev.com/b160073dd51148f56b6586a9902b8a24674886c4/third_party/WebKit/Source/core/css/CSSPageRule.cpp
[modify] https://crrev.com/b160073dd51148f56b6586a9902b8a24674886c4/third_party/WebKit/Source/core/css/CSSSelector.cpp
[modify] https://crrev.com/b160073dd51148f56b6586a9902b8a24674886c4/third_party/WebKit/Source/core/css/CSSSelector.h
[modify] https://crrev.com/b160073dd51148f56b6586a9902b8a24674886c4/third_party/WebKit/Source/core/css/SelectorChecker.cpp
[modify] https://crrev.com/b160073dd51148f56b6586a9902b8a24674886c4/third_party/WebKit/Source/core/css/SelectorFilter.cpp
[modify] https://crrev.com/b160073dd51148f56b6586a9902b8a24674886c4/third_party/WebKit/Source/core/css/parser/CSSParser.cpp
[modify] https://crrev.com/b160073dd51148f56b6586a9902b8a24674886c4/third_party/WebKit/Source/core/css/parser/CSSParser.h
[modify] https://crrev.com/b160073dd51148f56b6586a9902b8a24674886c4/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
[modify] https://crrev.com/b160073dd51148f56b6586a9902b8a24674886c4/third_party/WebKit/Source/core/css/parser/CSSParserImpl.h
[modify] https://crrev.com/b160073dd51148f56b6586a9902b8a24674886c4/third_party/WebKit/Source/core/css/parser/CSSParserSelector.h
[modify] https://crrev.com/b160073dd51148f56b6586a9902b8a24674886c4/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
[modify] https://crrev.com/b160073dd51148f56b6586a9902b8a24674886c4/third_party/WebKit/Source/core/dom/StyleEngineTest.cpp

Status: Fixed (was: Assigned)
I've re-landed the CL. Chrome M61 will get it.
Please see also the comment in the tracking bug for the current schedule: https://bugs.chromium.org/p/chromium/issues/detail?id=489954#c66
Project Member

Comment 22 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5d015a62218436871593534dc5bb051aa14b2bc

commit d5d015a62218436871593534dc5bb051aa14b2bc
Author: Hayato Ito <hayato@chromium.org>
Date: Thu Aug 10 08:10:18 2017

Revert "Reland: Make /deep/ as no-op and remove ::shadow in dynamic profile"

This reverts commit b160073dd51148f56b6586a9902b8a24674886c4.

Reason for revert: We've decided to delay the removal of /deep/ from M61 to M63.
See https://bugs.chromium.org/p/chromium/issues/detail?id=489954#c99 for details.

Original change's description:
> Reland: Make /deep/ as no-op and remove ::shadow in dynamic profile
> 
> Reland the CL [1], which was reverted at [2], since CrOS's OOBE issue was fixed.
> 
> - [1]: https://codereview.chromium.org/2778983006
> - [2]: https://codereview.chromium.org/2885153003
> 
> Bug:  489954 , 723259 
> Change-Id: Ie162502385443a4e9a9cc80444c596458ad1e100
> Reviewed-on: https://chromium-review.googlesource.com/575322
> Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
> Commit-Queue: Hayato Ito <hayato@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487745}

TBR=kochi@chromium.org,hayato@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  489954 ,  723259 
Change-Id: I1b58db5bc2f3268f16b832214b87f1d77ada38ee
Reviewed-on: https://chromium-review.googlesource.com/609602
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493331}
[modify] https://crrev.com/d5d015a62218436871593534dc5bb051aa14b2bc/third_party/WebKit/Source/core/css/CSSPageRule.cpp
[modify] https://crrev.com/d5d015a62218436871593534dc5bb051aa14b2bc/third_party/WebKit/Source/core/css/CSSSelector.cpp
[modify] https://crrev.com/d5d015a62218436871593534dc5bb051aa14b2bc/third_party/WebKit/Source/core/css/CSSSelector.h
[modify] https://crrev.com/d5d015a62218436871593534dc5bb051aa14b2bc/third_party/WebKit/Source/core/css/SelectorChecker.cpp
[modify] https://crrev.com/d5d015a62218436871593534dc5bb051aa14b2bc/third_party/WebKit/Source/core/css/SelectorFilter.cpp
[modify] https://crrev.com/d5d015a62218436871593534dc5bb051aa14b2bc/third_party/WebKit/Source/core/css/parser/CSSParser.cpp
[modify] https://crrev.com/d5d015a62218436871593534dc5bb051aa14b2bc/third_party/WebKit/Source/core/css/parser/CSSParser.h
[modify] https://crrev.com/d5d015a62218436871593534dc5bb051aa14b2bc/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
[modify] https://crrev.com/d5d015a62218436871593534dc5bb051aa14b2bc/third_party/WebKit/Source/core/css/parser/CSSParserImpl.h
[modify] https://crrev.com/d5d015a62218436871593534dc5bb051aa14b2bc/third_party/WebKit/Source/core/css/parser/CSSParserSelector.h
[modify] https://crrev.com/d5d015a62218436871593534dc5bb051aa14b2bc/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
[modify] https://crrev.com/d5d015a62218436871593534dc5bb051aa14b2bc/third_party/WebKit/Source/core/dom/StyleEngineTest.cpp

Project Member

Comment 23 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bd1ec4faae8e7df923a87ec799961ee6d3205de

commit 6bd1ec4faae8e7df923a87ec799961ee6d3205de
Author: Hayato Ito <hayato@chromium.org>
Date: Tue Aug 15 10:01:21 2017

Update deprecation/removal message of /deep/ and :shadow

We've decided to delay the removal of /deep/ and ::shadow from M61 to M63.
See https://bugs.chromium.org/p/chromium/issues/detail?id=489954#c99
for details.

Bug:  489954 ,  723259 
Change-Id: If36e58cf2d3cf7857fb66595c6886bc0be4bf639
Reviewed-on: https://chromium-review.googlesource.com/615207
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494352}
[modify] https://crrev.com/6bd1ec4faae8e7df923a87ec799961ee6d3205de/third_party/WebKit/LayoutTests/fast/dom/shadow/apply-deep-in-document-scope-expected.txt
[modify] https://crrev.com/6bd1ec4faae8e7df923a87ec799961ee6d3205de/third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinator-and-shadow-pseudo-expected.txt
[modify] https://crrev.com/6bd1ec4faae8e7df923a87ec799961ee6d3205de/third_party/WebKit/Source/core/frame/Deprecation.cpp

Project Member

Comment 24 by bugdroid1@chromium.org, Aug 16 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f15b7cd806d666e554ee26fc3b2e7e291f082acb

commit f15b7cd806d666e554ee26fc3b2e7e291f082acb
Author: Hayato Ito <hayato@chromium.org>
Date: Wed Aug 16 03:43:15 2017

Revert "Reland: Make /deep/ as no-op and remove ::shadow in dynamic profile"

This reverts commit b160073dd51148f56b6586a9902b8a24674886c4.

Reason for revert: We've decided to delay the removal of /deep/ from M61 to M63.
See https://bugs.chromium.org/p/chromium/issues/detail?id=489954#c99 for details.

Original change's description:
> Reland: Make /deep/ as no-op and remove ::shadow in dynamic profile
>
> Reland the CL [1], which was reverted at [2], since CrOS's OOBE issue was fixed.
>
> - [1]: https://codereview.chromium.org/2778983006
> - [2]: https://codereview.chromium.org/2885153003
>
> Bug:  489954 , 723259 
> Change-Id: Ie162502385443a4e9a9cc80444c596458ad1e100
> Reviewed-on: https://chromium-review.googlesource.com/575322
> Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
> Commit-Queue: Hayato Ito <hayato@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487745}

TBR=hayato@chromium.org, kochi@chromium.org


(cherry picked from commit d5d015a62218436871593534dc5bb051aa14b2bc)

Bug:  489954 ,  723259 
Change-Id: I1b58db5bc2f3268f16b832214b87f1d77ada38ee
Reviewed-on: https://chromium-review.googlesource.com/609602
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493331}
Reviewed-on: https://chromium-review.googlesource.com/616502
Cr-Commit-Position: refs/branch-heads/3163@{#597}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/f15b7cd806d666e554ee26fc3b2e7e291f082acb/third_party/WebKit/Source/core/css/CSSPageRule.cpp
[modify] https://crrev.com/f15b7cd806d666e554ee26fc3b2e7e291f082acb/third_party/WebKit/Source/core/css/CSSSelector.cpp
[modify] https://crrev.com/f15b7cd806d666e554ee26fc3b2e7e291f082acb/third_party/WebKit/Source/core/css/CSSSelector.h
[modify] https://crrev.com/f15b7cd806d666e554ee26fc3b2e7e291f082acb/third_party/WebKit/Source/core/css/SelectorChecker.cpp
[modify] https://crrev.com/f15b7cd806d666e554ee26fc3b2e7e291f082acb/third_party/WebKit/Source/core/css/SelectorFilter.cpp
[modify] https://crrev.com/f15b7cd806d666e554ee26fc3b2e7e291f082acb/third_party/WebKit/Source/core/css/parser/CSSParser.cpp
[modify] https://crrev.com/f15b7cd806d666e554ee26fc3b2e7e291f082acb/third_party/WebKit/Source/core/css/parser/CSSParser.h
[modify] https://crrev.com/f15b7cd806d666e554ee26fc3b2e7e291f082acb/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
[modify] https://crrev.com/f15b7cd806d666e554ee26fc3b2e7e291f082acb/third_party/WebKit/Source/core/css/parser/CSSParserImpl.h
[modify] https://crrev.com/f15b7cd806d666e554ee26fc3b2e7e291f082acb/third_party/WebKit/Source/core/css/parser/CSSParserSelector.h
[modify] https://crrev.com/f15b7cd806d666e554ee26fc3b2e7e291f082acb/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
[modify] https://crrev.com/f15b7cd806d666e554ee26fc3b2e7e291f082acb/third_party/WebKit/Source/core/dom/StyleEngineTest.cpp

Sign in to add a comment