Image Capture: applyConstraints() should resolve with a MediaTrackConstraints object |
|||
Issue descriptionapplyConstraints fulfills with some PhotoCapabilities. How about fulfilling with Constraints instead (same as in track.getConstraints()) so that we know which constraints have been applied?
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9b1515a258e10ce170b40eff942232a49d24faf commit d9b1515a258e10ce170b40eff942232a49d24faf Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Wed May 31 05:14:37 2017 Image Capture: resolve applyConstraints() with the passed MediaTrackConstraints argument MediaStreamTrack::applyConstraints() currently resolves with PhotoCapabilities bc Caps+Settings are retrieved after applying those constraints. This CL changes this to resolve applyConstraints() with the constraints that were applied. LayoutTests are updated and slightly cleaned up by factoring out a service method into resources/imagecapture-helpers.js Bug: 723251 Change-Id: I0db8671c75154fbeff1ef03f385ed277cf5ce17e Reviewed-on: https://chromium-review.googlesource.com/517280 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#475808} [modify] https://crrev.com/d9b1515a258e10ce170b40eff942232a49d24faf/third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-getSettings.html [modify] https://crrev.com/d9b1515a258e10ce170b40eff942232a49d24faf/third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints.html [modify] https://crrev.com/d9b1515a258e10ce170b40eff942232a49d24faf/third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-getSettings.html [add] https://crrev.com/d9b1515a258e10ce170b40eff942232a49d24faf/third_party/WebKit/LayoutTests/imagecapture/resources/imagecapture-helpers.js [modify] https://crrev.com/d9b1515a258e10ce170b40eff942232a49d24faf/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp [modify] https://crrev.com/d9b1515a258e10ce170b40eff942232a49d24faf/third_party/WebKit/Source/modules/imagecapture/ImageCapture.h [modify] https://crrev.com/d9b1515a258e10ce170b40eff942232a49d24faf/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl
,
May 31 2017
Verified in Chromium 61.03117.0
,
May 31 2017
,
May 31 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mcasas@chromium.org
, May 30 2017Status: Assigned (was: Available)