Link to the failed builder: https://luci-milo.appspot.com/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Tests%20(1)/38659 PageLoadMetricsBrowserTest.NonHtmlMainResource PageLoadMetricsBrowserTest.Ignore204Pages PageLoadMetricsBrowserTest.HttpErrorPage PageLoadMetricsBrowserTest.IgnoreDownloads Culprit CL: https://codereview.chromium.org/2887773003 (Reverting shortly).
Already reverted https://codereview.chromium.org/2890603005/ Thanks!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40c27d78b91fc87eb549e263640e66d8a3f4ba67 commit 40c27d78b91fc87eb549e263640e66d8a3f4ba67 Author: jkarlin <jkarlin@chromium.org> Date: Thu May 18 16:16:45 2017 [PageLoadMetrics] Don't record an ads histogram if the page hasn't committed This is a simple fix with a complex test. BUG=723219, 708570 Review-Url: https://codereview.chromium.org/2893633003 Cr-Commit-Position: refs/heads/master@{#472833} [modify] https://crrev.com/40c27d78b91fc87eb549e263640e66d8a3f4ba67/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc [modify] https://crrev.com/40c27d78b91fc87eb549e263640e66d8a3f4ba67/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h [modify] https://crrev.com/40c27d78b91fc87eb549e263640e66d8a3f4ba67/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/40c27d78b91fc87eb549e263640e66d8a3f4ba67/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc [modify] https://crrev.com/40c27d78b91fc87eb549e263640e66d8a3f4ba67/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.
<UI triage> Bug owners, please add the appropriate component to your bug. Thanks!
Comment 1 by afakhry@chromium.org
, May 17 2017