New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723200 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Compat



Sign in to add a comment

Make Snackbar on tablet center aligned

Project Member Reported by martiw@chromium.org, May 17 2017

Issue description

Currently, snackbar on tablet are left aligned and farther from bottom.
It doesn't look nice with the infobar which is center aligned.

We could like to make snackbar center aligned like the png attached.
If it's okay to go ahead.
You could assign this bug to me.
Thx.
 
snackbar_center.png
15.5 KB View Download
snackbar_left.png
700 KB View Download

Comment 1 by martiw@chromium.org, May 19 2017

Cc: -martiw@chromium.org tedc...@chromium.org
Owner: martiw@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/693c21e381f14e84e67137c2307e1c83a24923fe

commit 693c21e381f14e84e67137c2307e1c83a24923fe
Author: martiw <martiw@chromium.org>
Date: Mon May 22 15:45:50 2017

Make snackbar on tablet center aligned and sticked to bottom.
Currently, snackbar on tablet are left aligned and farther from bottom.
It doesn't look nice with the infobar which is center aligned.

Below is what the snackbar looks like on tablet after the change:
https://drive.google.com/open?id=0B1O0Z7eoZMuGT1NPcEhKb2VwdWM

BUG= 723200 

Review-Url: https://codereview.chromium.org/2892133002
Cr-Commit-Position: refs/heads/master@{#473583}

[modify] https://crrev.com/693c21e381f14e84e67137c2307e1c83a24923fe/chrome/android/java/res/drawable/snackbar_background_tablet.xml
[modify] https://crrev.com/693c21e381f14e84e67137c2307e1c83a24923fe/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java

Comment 3 by martiw@chromium.org, May 23 2017

Status: Fixed (was: Started)

Sign in to add a comment