Lock screen dialog buttons do not look correct. |
||||
Issue descriptionOpen chrome://md-settings/lockScreen. Inspect the password prompt dialog CANCEL buttons. Inspect a regular settings dialog (ie. Reset) The whole strip is missing padding and the the left button is missing margin.
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2ba5f2a226750292f28fe300c8ba4c845fa34df commit b2ba5f2a226750292f28fe300c8ba4c845fa34df Author: Sammie Quon <sammiequon@google.com> Date: Thu May 18 19:40:49 2017 [merge to m59]md settings: Fix dialog buttons on lock screen. Fix the password prompt, pin setup, fingerprint setup dialogs on the lock screen. They dont use the 'button-container' class from cr-dialog, so they are missing some margins/paddings the other dialogs have. Also the previous 'button-strip' was part of the body content of cr-dialog. Before: https://screenshot.googleplex.com/heBMZLNjZXY After: https://screenshot.googleplex.com/TYHdxUQNzC6 TEST=manual BUG= 723192 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2889893002 Cr-Original-Commit-Position: refs/heads/master@{#472586} Review-Url: https://codereview.chromium.org/2894003003 . Cr-Commit-Position: refs/branch-heads/3071@{#620} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/b2ba5f2a226750292f28fe300c8ba4c845fa34df/chrome/browser/resources/settings/people_page/password_prompt_dialog.html [modify] https://crrev.com/b2ba5f2a226750292f28fe300c8ba4c845fa34df/chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.html [modify] https://crrev.com/b2ba5f2a226750292f28fe300c8ba4c845fa34df/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
,
May 18 2017
,
May 22 2017
ChromeOS 9460.48.0, 59.0.3071.67 |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, May 17 2017