New issue
Advanced search Search tips

Issue 723192 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Lock screen dialog buttons do not look correct.

Project Member Reported by sammiequon@chromium.org, May 17 2017

Issue description

Open chrome://md-settings/lockScreen.
Inspect the password prompt dialog CANCEL buttons.
Inspect a regular settings dialog (ie. Reset)

The whole strip is missing padding and the the left button is missing margin.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1d96eb7bec272c948773c33474bbcc5479c5503

commit e1d96eb7bec272c948773c33474bbcc5479c5503
Author: sammiequon <sammiequon@chromium.org>
Date: Wed May 17 22:18:38 2017

md settings: Fix dialog buttons on lock screen.

Fix the password prompt, pin setup, fingerprint setup dialogs on the lock screen. They dont use the 'button-container' class from cr-dialog, so they are missing some margins/paddings the other dialogs have. Also the previous 'button-strip' was part of the body content of cr-dialog.

Before: https://screenshot.googleplex.com/heBMZLNjZXY
After: https://screenshot.googleplex.com/TYHdxUQNzC6

TEST=manual
BUG= 723192 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2889893002
Cr-Commit-Position: refs/heads/master@{#472586}

[modify] https://crrev.com/e1d96eb7bec272c948773c33474bbcc5479c5503/chrome/browser/resources/settings/people_page/password_prompt_dialog.html
[modify] https://crrev.com/e1d96eb7bec272c948773c33474bbcc5479c5503/chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.html
[modify] https://crrev.com/e1d96eb7bec272c948773c33474bbcc5479c5503/chrome/browser/resources/settings/people_page/setup_pin_dialog.html

Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2017

Labels: merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2ba5f2a226750292f28fe300c8ba4c845fa34df

commit b2ba5f2a226750292f28fe300c8ba4c845fa34df
Author: Sammie Quon <sammiequon@google.com>
Date: Thu May 18 19:40:49 2017

[merge to m59]md settings: Fix dialog buttons on lock screen.

Fix the password prompt, pin setup, fingerprint setup dialogs on the lock screen. They dont use the 'button-container' class from cr-dialog, so they are missing some margins/paddings the other dialogs have. Also the previous 'button-strip' was part of the body content of cr-dialog.

Before: https://screenshot.googleplex.com/heBMZLNjZXY
After: https://screenshot.googleplex.com/TYHdxUQNzC6

TEST=manual
BUG= 723192 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2889893002
Cr-Original-Commit-Position: refs/heads/master@{#472586}
Review-Url: https://codereview.chromium.org/2894003003 .
Cr-Commit-Position: refs/branch-heads/3071@{#620}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/b2ba5f2a226750292f28fe300c8ba4c845fa34df/chrome/browser/resources/settings/people_page/password_prompt_dialog.html
[modify] https://crrev.com/b2ba5f2a226750292f28fe300c8ba4c845fa34df/chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.html
[modify] https://crrev.com/b2ba5f2a226750292f28fe300c8ba4c845fa34df/chrome/browser/resources/settings/people_page/setup_pin_dialog.html

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
ChromeOS 9460.48.0, 59.0.3071.67

Sign in to add a comment