New issue
Advanced search Search tips

Issue 723179 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7.3%-75.5% regression in page_cycler_v2.typical_25 at 470766:471298

Project Member Reported by lanwei@chromium.org, May 17 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 17 2017

Cc: yhirano@chromium.org
Owner: yhirano@chromium.org

=== Auto-CCing suspected CL author yhirano@chromium.org ===

Hi yhirano@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : yhirano
  Commit : 97c0d877b1aff4ac84138c3eab71d994ead93b14
  Date   : Thu May 11 05:39:25 2017
  Subject: Revert "Separate preaload matching from MemoryCache"

Bisect Details
  Configuration: win_perf_bisect
  Benchmark    : page_cycler_v2_site_isolation.basic_oopif
  Metric       : timeToFirstMeaningfulPaint_avg/pcv1-warm/http___www.cnn.com
  Change       : 23.41% | 655.780666666 -> 837.391785714

Revision             Result                  N
chromium@470765      655.781 +- 12.0454      6       good
chromium@470798      661.304 +- 40.4168      9       good
chromium@470815      711.217 +- 385.951      14      good
chromium@470823      727.085 +- 504.516      21      good
chromium@470824      694.716 +- 231.473      14      good
chromium@470825      845.377 +- 430.126      14      bad       <--
chromium@470827      825.71 +- 156.17        14      bad
chromium@470831      837.392 +- 228.75       14      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...www.cnn.com page_cycler_v2_site_isolation.basic_oopif

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979389438578101424

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5808955671969792


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Assigned (was: Untriaged)
This is interesting.

This is a revert CL, and the reason of revert is perf regression. But it seems the original CL brought some perf improvements as well.

I'll keep this open for a while.
See also:  issue 719502 
Components: Blink>Loader
Status: WontFix (was: Assigned)

Sign in to add a comment