New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 723149 link

Starred by 1 user
Status: Fixed
Owner:
█ msarett@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
brianosman@chromium.org
ccameron@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 713891



Sign in to add a comment

color: images/color-profile-group.html crashes with --enable-color-correct-rendering CPU raster

Project Member Reported by ccameron@chromium.org, May 17 2017 
To reproduce:
1. Download the attached .html and .jpg files (a reduced version of images/color-profile-group.html)
2. Run chrome with 
  --disable-gpu-rasterization
  --enable-color-correct-rendering
  --force-color-profile=generic-rgb
3. Open the downloaded .html file.
4. [software_image_decode_cache.cc(590)] Check failed: image.

In particular, the call to SkImage::makeColorSpace is returning nullptr.
color-profile-group.html
289 bytes View Download
red-at-12-oclock-with-color-profile.jpg
226 KB View Download

Comment 1 by msarett@chromium.org, May 17 2017

Cc: -msarett@chromium.org ccameron@chromium.org
Owner: msarett@chromium.org
This is a case of us not handling images created by SkImage::makeSubset() correctly.  In this case, the dimensions of the SkImage do not match the dimensions of its SkImageGenerator (since the image is a subset of a generator) - the mismatch is causing makeColorSpace() to fail.

I'll write a fix.
Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2017 

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/b2004f76e2ac8395ca93dfa444011120e3223197

commit b2004f76e2ac8395ca93dfa444011120e3223197
Author: Matt Sarett <msarett@google.com>
Date: Thu May 18 15:14:59 2017

Fix SkImage::onMakeColorSpace() for subset lazy images

Bug:  723149 
Change-Id: Ib56a77958fc1b7e026ee5ca98a46e8f014fe75d4
Reviewed-on: https://skia-review.googlesource.com/17309
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>

[modify] https://crrev.com/b2004f76e2ac8395ca93dfa444011120e3223197/src/image/SkImage_Lazy.cpp

Comment 3 by msarett@chromium.org, May 19 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment