New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723146 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[MD settings] too much space between vert separator and icons

Project Member Reported by dschuyler@chromium.org, May 17 2017

Issue description

in chrome://settings/content/cookies (and elsewhere) there is too much space between the vertical grey line separator and the icon button and the end of the row.
 
Screenshot from 2017-05-16 17:34:54.png
10.3 KB View Download
Screenshot from 2017-05-16 17:35:19.png
6.0 KB View Download
Fixed versions.
Screenshot from 2017-05-16 17:30:49.png
18.8 KB View Download
Screenshot from 2017-05-16 17:31:13.png
2.4 KB View Download
Affected buttons are highlighted pink in these screen shots (the pink color is not part of the CL).
Screenshot from 2017-05-17 17:12:06.png
6.2 KB View Download
Screenshot from 2017-05-17 17:11:55.png
13.2 KB View Download
Screenshot from 2017-05-17 17:11:38.png
15.3 KB View Download
Cc: msrchandra@chromium.org dschuyler@chromium.org ranjitkan@chromium.org nyerramilli@chromium.org
 Issue 723988  has been merged into this issue.
Labels: -Pri-3 Pri-1
I duped a pri1 to this bug, so I'm moving the pri here.

Comment 5 by dbeam@chromium.org, May 18 2017

Labels: Hotlist-MD-Settings-General
Project Member

Comment 6 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a14c40573ecd9fbf68ac4c4d97b9e4c9f504a6d

commit 8a14c40573ecd9fbf68ac4c4d97b9e4c9f504a6d
Author: dschuyler <dschuyler@chromium.org>
Date: Thu May 18 23:45:53 2017

[MD settings] layout vertical separators with paper-icon-button-light

This CL adjusts the margins and padding on vertical grey line separators
and paper-icon-button-light buttons.

BUG= 723146 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2893483002
Cr-Commit-Position: refs/heads/master@{#472976}

[modify] https://crrev.com/8a14c40573ecd9fbf68ac4c4d97b9e4c9f504a6d/ui/webui/resources/cr_elements/network/cr_network_list_item.html
[modify] https://crrev.com/8a14c40573ecd9fbf68ac4c4d97b9e4c9f504a6d/ui/webui/resources/cr_elements/shared_vars_css.html

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on ChromeOS 9574.0.0, 60.0.3105.0

Sign in to add a comment