New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723138 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 719040



Sign in to add a comment

Failed "SignerTest" is causing entire Rambi family builds to fail

Project Member Reported by vsu...@chromium.org, May 17 2017

Issue description

Comment 1 by vsu...@chromium.org, May 17 2017

Cc: afakhry@chromium.org chingcodes@chromium.org kyan@chromium.org krishna...@chromium.org
CC'ing some people who may be able to assign a good owner for this. Also CC'ing morning planner.
Cc: semenzato@chromium.org
+semenzato Do you know who might be able to help with this?

INFO    security_test_image: Running ensure_secure_kernelparams.sh
Unexpected kernel parameters found:
  maxcpus=3 
Debug output:
required_kparams=(
	'cros_secure'
	'dm_verity.error_behavior=3'
	'dm_verity.max_bios=-1'
	'dm_verity.dev_wait=1'
	'init=/sbin/init'
	'ro'
	'rootwait'
	'add_efi_memmap'
	'boot=local'
	'i915.modeset=1'
	'nmi_watchdog=panic,lapic'
	'noresume'
	'noswap'
	'tpm_tis.force=1'
	'tpm_tis.interrupts=0'
)

Comment 3 by dchan@google.com, May 23 2017

Cc: hashimoto@chromium.org grundler@chromium.org aaboagye@chromium.org ihf@chromium.org
ping! any update on this ?

Comment 5 by aut...@google.com, May 23 2017

Components: -Infra>Client>ChromeOS

Comment 6 by dchan@google.com, May 24 2017

Components: OS>Kernel

Comment 7 by ihf@chromium.org, May 24 2017

Blockedon: 719040
Cc: marc...@chromium.org snanda@chromium.org
Labels: OS-Chrome
Ninja: Unexpected kernel parameters found:
  maxcpus=2 

Clapper: Unexpected kernel parameters found:
  maxcpus=3 

Comment 8 by grundler@google.com, May 24 2017

First, I'm surprised anyone is specifying maxcpus...but I'm assuming there is some good reason for doing so since several public overlays are doing this:
grundler@firesword ~/trunk/src/overlays $ fgrep -R maxcpus
overlay-heli/scripts/build_kernel_image.sh:  echo "maxcpus=3" >> "$1"
overlay-candy/scripts/build_kernel_image.sh:  echo "maxcpus=3" >> "$1"
overlay-banjo/scripts/build_kernel_image.sh:  echo "maxcpus=3" >> "$1"
overlay-gnawty/scripts/build_kernel_image.sh:  echo "maxcpus=3" >> "$1"
overlay-kip/scripts/build_kernel_image.sh:  echo "maxcpus=3" >> "$1"
overlay-squawks/scripts/build_kernel_image.sh:  echo "maxcpus=3" >> "$1"
overlay-clapper/scripts/build_kernel_image.sh:  echo "maxcpus=3" >> "$1"
grep: .git/shallow: No such file or directory
grep: .git/packed-refs: No such file or directory
overlay-enguarde/scripts/build_kernel_image.sh:  echo "maxcpus=3" >> "$1"
overlay-glimmer/scripts/build_kernel_image.sh:  echo "maxcpus=3" >> "$1"
overlay-quawks/scripts/build_kernel_image.sh:  echo "maxcpus=3" >> "$1"
overlay-sumo/scripts/build_kernel_image.sh:  echo "maxcpus=2" >> "$1"
overlay-winky/scripts/build_kernel_image.sh:  echo "maxcpus=3" >> "$1"
overlay-rambi/scripts/build_kernel_image.sh:  echo "maxcpus=3" >> "$1"
overlay-expresso/scripts/build_kernel_image.sh:  echo "maxcpus=3" >> "$1"
overlay-swanky/scripts/build_kernel_image.sh:  echo "maxcpus=3" >> "$1"
overlay-orco/scripts/build_kernel_image.sh:  echo "maxcpus=3" >> "$1"
overlay-ninja/scripts/build_kernel_image.sh:  echo "maxcpus=2" >> "$1"
grep: overlay-variant-veyron-mickey/chromeos-base/chromeos-bsp-mickey/chromeos-bsp-mickey-0.0.1-r2.ebuild: No such file or directory

ninja added the maxcpus with this change as a workaround:
    https://chromium-review.googlesource.com/c/484652/

I'm going to guess most of the above are running chromeos-4.4 kernel and suffering some common issue...  which suggests ensure_secure_kernelparams.sh needs to be modified to accept this parameter. Any objections?
Labels: Merge-Request-59 M-59
Agreed, this should already be fixed by https://chrome-internal-review.googlesource.com/#/c/360789/

Perhaps this just needs to be merged into 59?
Project Member

Comment 10 by sheriffbot@chromium.org, May 24 2017

Labels: -Merge-Request-59 Merge-Review-59 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: rajatja@chromium.org
c#9: yes, merging to M59 should do the trick. Bernie, did you want to do that yourself?
Labels: -Merge-Review-59
Status: Fixed (was: Untriaged)
Labels: -Hotlist-Merge-Review

Comment 16 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment