New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 723135 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: May 2018
Cc:
kojii@chromium.org
█ glebl@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Account for atomic inline margins before positioning them

Project Member Reported by glebl@chromium.org, May 17 2017 
Currently we are not taking into account atomic inline margins
Example:

<span style="display:inline-block; vertical-align: bottom; height: 20px; width: 300px; background: blue; margin-left: 10px;"></span>
  <span style="display:inline-block; vertical-align: bottom; height: 20px; width: 300px; background: purple; margin-left: 100px;"></span>
  <span style="display:inline-block; vertical-align: bottom; height: 20px; width: 300px; background: fuchsia"></span>

 LayoutNGBlockFlow (floating) {div} at (0,0) size 500x500
        LayoutNGBlockFlow {span} at (0,0) size 300x20 [bgcolor=#0000FF]
        LayoutText {#text} at (0,0) size 0x0
        LayoutNGBlockFlow {span} at (0,20) size 300x20 [bgcolor=#800080]
        LayoutText {#text} at (0,0) size 0x0
        LayoutNGBlockFlow {span} at (0,40) size 300x20 [bgcolor=#FF00FF]
        LayoutText {#text} at (0,0) size 0x0

failed tests

virtual/layout_ng/external/wpt/css/CSS2/floats/floats-zero-height-wrap-001.xht
virtual/layout_ng/external/wpt/css/CSS2/floats/floats-zero-height-wrap-002.xht
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88768594c337f30f19c9b7ea2bd2d7d8820067a4

commit 88768594c337f30f19c9b7ea2bd2d7d8820067a4
Author: kojii <kojii@chromium.org>
Date: Wed May 17 16:39:06 2017

[LayoutNG] Implement inline margins for atomic inline boxes

This patch implements inline margins for atomic inline boxes. Inline
margins for non-replaced inline boxes is not included and will be in
following patches.

Also changes not to generate OpenTag/CloseTag NGInlineItem for atomic
inline boxes. Atomic inlines use their margin boxes for inline layout
purposes, while non-replaced inline boxes has different characteristics.
Not generating OpenTag/CloseTag helps single code to handle both cases.

BUG=636993, 723135 

Review-Url: https://codereview.chromium.org/2883213003
Cr-Commit-Position: refs/heads/master@{#472478}

[modify] https://crrev.com/88768594c337f30f19c9b7ea2bd2d7d8820067a4/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h
[modify] https://crrev.com/88768594c337f30f19c9b7ea2bd2d7d8820067a4/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc
[modify] https://crrev.com/88768594c337f30f19c9b7ea2bd2d7d8820067a4/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.h
[modify] https://crrev.com/88768594c337f30f19c9b7ea2bd2d7d8820067a4/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc
[modify] https://crrev.com/88768594c337f30f19c9b7ea2bd2d7d8820067a4/third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc
Project Member

Comment 2 by sheriffbot@chromium.org, May 18 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by e...@chromium.org, May 18 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment