New issue
Advanced search Search tips

Issue 723129 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 706125


Participants' hotlists:
dmurph-shortlist-features
IDB-Scaling

Show other hotlists

Other hotlists containing this issue:
Hotlist-1


Sign in to add a comment

[IndexedDB] Create new metrics to help prioritize work

Project Member Reported by dmu...@chromium.org, May 17 2017

Issue description

See doc for list of issues and planning:
https://docs.google.com/document/d/1dTcn2uHyCpFOWg3S5slB4p06ZGXck8h06ZW8cntaBIo/edit#

Deleting object store is slow (issue 693799)
 - record time for deleting object store. If this is slow then we investigate.


Clear browsing data action takes a long time ( issue 574819 )
 - record time for storage partition clear browser data. Prioritize based on results.

Clear Index table's tombstones more proactively ( issue 704244 )
 - Record # of index key tombstones in finch trial, where we crawl indexes on idle.

Abort outstanding transactions under memory pressure (issue 612525)
 - Record # of running and pending transactions on memory pressure. Solution will depend on # of running and pending txns.

Added in https://codereview.chromium.org/2904603003/:
Renderer process crash / large values (issue 500733)
Avoiding value copying (issue 681212 and issue 682363) (renderer and browser side)
 - record idb value size. If large, then prioritize this work.

Support large writing txns, esp for initialization from version change (issue 527995)
 - record the total idbvalue and key size, time, and operation count for txns, split on txn type (versionchange and normal)

 

Comment 1 by dmu...@chromium.org, May 19 2017

Description: Show this description

Comment 2 by dmu...@chromium.org, May 19 2017

Description: Show this description

Comment 3 by dmu...@chromium.org, May 19 2017

Cc: jsb...@chromium.org pwnall@chromium.org

Comment 4 by jsb...@chromium.org, May 22 2017

Labels: Pri-2

Comment 5 by dmu...@chromium.org, May 24 2017

Description: Show this description
Project Member

Comment 6 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dc3da85cabab5ebae5807dbb4ecb3d270e9072b

commit 4dc3da85cabab5ebae5807dbb4ecb3d270e9072b
Author: dmurph <dmurph@chromium.org>
Date: Wed May 31 23:26:41 2017

[IndexedDB] Adding txn, value, and key size metrics, and update txn cost.

Metrics for transaction, value, and key sizes.
Transaction size cost for quota updated to include key size estimation.

BUG= 723129 

Review-Url: https://codereview.chromium.org/2904603003
Cr-Commit-Position: refs/heads/master@{#476089}

[modify] https://crrev.com/4dc3da85cabab5ebae5807dbb4ecb3d270e9072b/content/browser/indexed_db/database_impl.cc
[modify] https://crrev.com/4dc3da85cabab5ebae5807dbb4ecb3d270e9072b/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/4dc3da85cabab5ebae5807dbb4ecb3d270e9072b/content/browser/indexed_db/indexed_db_backing_store.h
[modify] https://crrev.com/4dc3da85cabab5ebae5807dbb4ecb3d270e9072b/content/browser/indexed_db/indexed_db_fake_backing_store.cc
[modify] https://crrev.com/4dc3da85cabab5ebae5807dbb4ecb3d270e9072b/content/browser/indexed_db/indexed_db_fake_backing_store.h
[modify] https://crrev.com/4dc3da85cabab5ebae5807dbb4ecb3d270e9072b/content/browser/indexed_db/indexed_db_transaction.cc
[modify] https://crrev.com/4dc3da85cabab5ebae5807dbb4ecb3d270e9072b/content/browser/indexed_db/leveldb/leveldb_transaction.cc
[modify] https://crrev.com/4dc3da85cabab5ebae5807dbb4ecb3d270e9072b/content/browser/indexed_db/leveldb/leveldb_transaction.h
[modify] https://crrev.com/4dc3da85cabab5ebae5807dbb4ecb3d270e9072b/content/browser/indexed_db/leveldb/leveldb_transaction_unittest.cc
[modify] https://crrev.com/4dc3da85cabab5ebae5807dbb4ecb3d270e9072b/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp
[modify] https://crrev.com/4dc3da85cabab5ebae5807dbb4ecb3d270e9072b/third_party/WebKit/Source/modules/indexeddb/IDBValueWrapping.cpp
[modify] https://crrev.com/4dc3da85cabab5ebae5807dbb4ecb3d270e9072b/third_party/WebKit/Source/modules/indexeddb/IDBValueWrapping.h
[modify] https://crrev.com/4dc3da85cabab5ebae5807dbb4ecb3d270e9072b/tools/metrics/histograms/histograms.xml

Comment 7 by dmu...@chromium.org, May 31 2017

Labels: Merge-Request-60 OS-All
Requesting merge for https://codereview.chromium.org/2904603003/ (4dc3da85cabab5ebae5807dbb4ecb3d270e9072b) from comment #6
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cef226d150bca11b6151dcf39f9ecc3ed71715f

commit 2cef226d150bca11b6151dcf39f9ecc3ed71715f
Author: dmurph <dmurph@chromium.org>
Date: Thu Jun 01 00:23:33 2017

[IndexedDB] Adding async tracing for renderer calls.

Screenshot of new async tracing:
https://screenshot.googleplex.com/empkTdUte65

R=pwnall
BUG= 723129 

Review-Url: https://codereview.chromium.org/2890023003
Cr-Commit-Position: refs/heads/master@{#476107}

[modify] https://crrev.com/2cef226d150bca11b6151dcf39f9ecc3ed71715f/third_party/WebKit/Source/modules/indexeddb/IDBCursor.cpp
[modify] https://crrev.com/2cef226d150bca11b6151dcf39f9ecc3ed71715f/third_party/WebKit/Source/modules/indexeddb/IDBCursor.h
[modify] https://crrev.com/2cef226d150bca11b6151dcf39f9ecc3ed71715f/third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp
[modify] https://crrev.com/2cef226d150bca11b6151dcf39f9ecc3ed71715f/third_party/WebKit/Source/modules/indexeddb/IDBIndex.cpp
[modify] https://crrev.com/2cef226d150bca11b6151dcf39f9ecc3ed71715f/third_party/WebKit/Source/modules/indexeddb/IDBIndex.h
[modify] https://crrev.com/2cef226d150bca11b6151dcf39f9ecc3ed71715f/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp
[modify] https://crrev.com/2cef226d150bca11b6151dcf39f9ecc3ed71715f/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.h
[modify] https://crrev.com/2cef226d150bca11b6151dcf39f9ecc3ed71715f/third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.cpp
[modify] https://crrev.com/2cef226d150bca11b6151dcf39f9ecc3ed71715f/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
[modify] https://crrev.com/2cef226d150bca11b6151dcf39f9ecc3ed71715f/third_party/WebKit/Source/modules/indexeddb/IDBRequest.h
[modify] https://crrev.com/2cef226d150bca11b6151dcf39f9ecc3ed71715f/third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp
[modify] https://crrev.com/2cef226d150bca11b6151dcf39f9ecc3ed71715f/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp
[modify] https://crrev.com/2cef226d150bca11b6151dcf39f9ecc3ed71715f/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

Status: Fixed (was: Assigned)
Marking as fixed for merge bot - openning up new bugs for remaining metrics
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 2 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 2 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af6083e608f2368961ca78d534bd711f7bf1fcac

commit af6083e608f2368961ca78d534bd711f7bf1fcac
Author: Daniel Murphy <dmurph@chromium.org>
Date: Fri Jun 02 00:37:02 2017

[IndexedDB] Adding txn, value, and key size metrics, and update txn cost.

Metrics for transaction, value, and key sizes.
Transaction size cost for quota updated to include key size estimation.

BUG= 723129 
TBR=dmurph@chromium.org

(cherry picked from commit 4dc3da85cabab5ebae5807dbb4ecb3d270e9072b)

Review-Url: https://codereview.chromium.org/2904603003
Cr-Original-Commit-Position: refs/heads/master@{#476089}
Change-Id: I423443c9e90d43908354fa12c15e90336a41fc1a
Reviewed-on: https://chromium-review.googlesource.com/522342
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#107}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/af6083e608f2368961ca78d534bd711f7bf1fcac/content/browser/indexed_db/database_impl.cc
[modify] https://crrev.com/af6083e608f2368961ca78d534bd711f7bf1fcac/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/af6083e608f2368961ca78d534bd711f7bf1fcac/content/browser/indexed_db/indexed_db_backing_store.h
[modify] https://crrev.com/af6083e608f2368961ca78d534bd711f7bf1fcac/content/browser/indexed_db/indexed_db_fake_backing_store.cc
[modify] https://crrev.com/af6083e608f2368961ca78d534bd711f7bf1fcac/content/browser/indexed_db/indexed_db_fake_backing_store.h
[modify] https://crrev.com/af6083e608f2368961ca78d534bd711f7bf1fcac/content/browser/indexed_db/indexed_db_transaction.cc
[modify] https://crrev.com/af6083e608f2368961ca78d534bd711f7bf1fcac/content/browser/indexed_db/leveldb/leveldb_transaction.cc
[modify] https://crrev.com/af6083e608f2368961ca78d534bd711f7bf1fcac/content/browser/indexed_db/leveldb/leveldb_transaction.h
[modify] https://crrev.com/af6083e608f2368961ca78d534bd711f7bf1fcac/content/browser/indexed_db/leveldb/leveldb_transaction_unittest.cc
[modify] https://crrev.com/af6083e608f2368961ca78d534bd711f7bf1fcac/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp
[modify] https://crrev.com/af6083e608f2368961ca78d534bd711f7bf1fcac/third_party/WebKit/Source/modules/indexeddb/IDBValueWrapping.cpp
[modify] https://crrev.com/af6083e608f2368961ca78d534bd711f7bf1fcac/third_party/WebKit/Source/modules/indexeddb/IDBValueWrapping.h
[modify] https://crrev.com/af6083e608f2368961ca78d534bd711f7bf1fcac/tools/metrics/histograms/histograms.xml

Blocking: 706125
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66da98b692341dd44357b586a52bb5fc265c0011

commit 66da98b692341dd44357b586a52bb5fc265c0011
Author: Daniel Murphy <dmurph@chromium.org>
Date: Thu Aug 17 21:21:06 2017

[IndexedDB] Index tombstone crawler for stats and tombstone deletion.

Bug:  725565 ,  711439 ,  723129 
Change-Id: I29d64e968b62aed0e7cdea4ac5721d0441958b75
Reviewed-on: https://chromium-review.googlesource.com/572700
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495322}
[modify] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/browser/BUILD.gn
[modify] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/browser/indexed_db/indexed_db_backing_store.h
[modify] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/browser/indexed_db/indexed_db_factory_impl.cc
[modify] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/browser/indexed_db/indexed_db_factory_impl.h
[modify] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/browser/indexed_db/indexed_db_leveldb_coding.cc
[modify] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/browser/indexed_db/indexed_db_leveldb_coding.h
[modify] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc
[add] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/browser/indexed_db/indexed_db_pre_close_task_queue.cc
[add] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/browser/indexed_db/indexed_db_pre_close_task_queue.h
[add] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/browser/indexed_db/indexed_db_pre_close_task_queue_unittest.cc
[add] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/browser/indexed_db/indexed_db_tombstone_sweeper.cc
[add] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/browser/indexed_db/indexed_db_tombstone_sweeper.h
[add] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/browser/indexed_db/indexed_db_tombstone_sweeper_unittest.cc
[modify] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/browser/indexed_db/leveldb/leveldb_database.h
[add] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/browser/indexed_db/leveldb/mock_level_db.cc
[add] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/browser/indexed_db/leveldb/mock_level_db.h
[modify] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/common/indexed_db/indexed_db_metadata.cc
[modify] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/common/indexed_db/indexed_db_metadata.h
[modify] https://crrev.com/66da98b692341dd44357b586a52bb5fc265c0011/content/test/BUILD.gn

Sign in to add a comment