LayoutTests floats-124.xht, floats-125.xht fail to render floats |
|
Issue descriptionThey pass today because both tests and refs are blank. After https://codereview.chromium.org/2887623002 lands refs test will start rendering and the test will fail. virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-124.xht virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-125.xht
,
May 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dd63993f535aa99d4f0ecb3159751b5fcb2089f commit 1dd63993f535aa99d4f0ecb3159751b5fcb2089f Author: kojii <kojii@chromium.org> Date: Sat May 20 18:11:53 2017 [LayoutNG] Place InlineFlowBox from NGFragment tree NGInlineNode::CopyFragmentDataToLayoutBox copies geometry from inline NGFragment tree to RootInlineBox and InlineTextBox, but didn't include InlineFlowBox. This results in InlineFlowBox, generated for nested inline elements, to have (0,0). Their children are placed, but since parent InlineFlowBox is at (0,0), they were clipped. This fix turns several tests to fail. They used to pass because expected images did not render. This fix unhides such tests. BUG=636993, 723117 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2887623002 Cr-Commit-Position: refs/heads/master@{#473444} [modify] https://crrev.com/1dd63993f535aa99d4f0ecb3159751b5fcb2089f/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/1dd63993f535aa99d4f0ecb3159751b5fcb2089f/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc |
|
►
Sign in to add a comment |
|
Comment 1 by glebl@chromium.org
, May 18 2017