[IPH] DCHECK_NE when running in demo mode |
|||
Issue descriptionIn feature_engagement_tracker_impl.cc, the function FeatureEngagementTrackerImpl::ShouldTriggerHelpUI() is failing a DCHECK. This is because of our initial setup and the expectations in the method: (1) CreateDemoModeFeatureEngagementTracker() is called. (2) This calls GetAllFeatures() and builds a fake FeatureConfig. (3) We don't set the FeatureConfig::trigger::name. Inside FeatureEngagementTrackerImpl::ShouldTriggerHelpUI() we mandate that FeatureConfig::trigger::name is not empty when we are incrementing the event on the model.
,
May 17 2017
CL in review: https://chromium-review.googlesource.com/c/507787/
,
May 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44ba9092273b822880e06cef6c59a24d40c9df05 commit 44ba9092273b822880e06cef6c59a24d40c9df05 Author: Tommy Nyquist <nyquist@chromium.org> Date: Wed May 17 18:25:25 2017 Fix issue with In-Product Help demo mode. In demo-mode (enabled through chrome://flags), the configuration for In-Product Help was just something that was created at runtime, and the only FeatureConfig field that was set was whether it was valid or not. However, as part of being able to track that a feature triggering has happened, it is now required to also have a trigger event name so the configuration can decide what that field name can be. This was only set in the Chrome Variations configuration and in tests, and not in the demo mode. This CL therefore just appends "_trigger" to the feature name and uses that as the trigger event name when in demo-mode. BUG= 723111 , 723009 Change-Id: I62b9507c2bd12c296184bedfb98bbe218923b374 Reviewed-on: https://chromium-review.googlesource.com/507787 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#472505} [modify] https://crrev.com/44ba9092273b822880e06cef6c59a24d40c9df05/components/feature_engagement_tracker/internal/feature_engagement_tracker_impl.cc
,
May 17 2017
,
Jun 21 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by nyquist@chromium.org
, May 17 2017