New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 723098 link

Starred by 1 user
Status: Fixed
Owner:
caseq@chromium.org
Closed: Sep 2017
Cc:
█ lushnikov@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: Cannot read property 'requestContent' of undefined -> failed view of formatted source

Project Member Reported by paulir...@chromium.org, May 16 2017 
repro

0. have persistence 2.0 on?
1. load https://nest.com/works-with-nest/
2. capture coverage 
3. click through on a JS file
4. it tries to load the formatted JS file


earlier:


inspector.js:6502 Uncaught (in promise) TypeError: Cannot read property 'requestContent' of undefined
    at Bindings.ContentProviderBasedProject.requestFileContent (inspector.js:6502)
    at Workspace.UISourceCode.requestContent (inspector.js:5790)
    at Sources.JavaScriptSourceFrame.workingCopy [as _lazyContent] (chrome-devtools://devtools/bundled/source_frame/source_frame_module.js:252)
    at Sources.JavaScriptSourceFrame._ensureContentLoaded (chrome-devtools://devtools/bundled/source_frame/source_frame_module.js:173)
    at Sources.JavaScriptSourceFrame.wasShown (chrome-devtools://devtools/bundled/source_frame/source_frame_module.js:167)
    at Sources.JavaScriptSourceFrame.wasShown (chrome-devtools://devtools/bundled/source_frame/source_frame_module.js:255)
    at Sources.JavaScriptSourceFrame.wasShown (chrome-devtools://devtools/bundled/sources/sources_module.js:284)
    at Sources.JavaScriptSourceFrame._notify (inspector.js:1002)
    at Sources.JavaScriptSourceFrame._processWasShown (inspector.js:993)
    at Sources.JavaScriptSourceFrame._showWidget (


later:


Uncaught (in promise) TypeError: Cannot read property 'focus' of null
    at Sources.SourcesView.showSourceLocation (chrome-devtools://devtools/bundled/sources/sources_module.js:1221)
    at Sources.SourcesPanel.showUISourceCode (chrome-devtools://devtools/bundled/sources/sources_module.js:1437)
    at Sources.SourcesPanel.UISourceCodeRevealer.reveal (chrome-devtools://devtools/bundled/sources/sources_module.js:1553)
    at reveal (inspector.js:854)
    at <anonymous>
Screen Shot 2017-05-16 at 4.28.14 PM.png
537 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88ed93a30047ad7f2b91312c644abc0dbe98c2ff

commit 88ed93a30047ad7f2b91312c644abc0dbe98c2ff
Author: caseq <caseq@chromium.org>
Date: Mon May 22 05:55:02 2017

DevTools: fix race when revealing formatted source code

The porblem was caused by trying to format and add a source code twice.
As a drive by, do not reveal the source code if the user navigated away.

BUG= 723098 

Review-Url: https://codereview.chromium.org/2888843002
Cr-Commit-Position: refs/heads/master@{#473510}

[modify] https://crrev.com/88ed93a30047ad7f2b91312c644abc0dbe98c2ff/third_party/WebKit/LayoutTests/inspector/coverage/reveal-autoformat.html
[modify] https://crrev.com/88ed93a30047ad7f2b91312c644abc0dbe98c2ff/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js
[modify] https://crrev.com/88ed93a30047ad7f2b91312c644abc0dbe98c2ff/third_party/WebKit/Source/devtools/front_end/sources/SourceFormatter.js

Comment 2 by caseq@chromium.org, Sep 22 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment