New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723093 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

It2Me host shouldn't ignore port range policy

Project Member Reported by sergeyu@chromium.org, May 16 2017

Issue description

Currently It2Me host ignores port-range policy. The policy is only applied for me2me host.
 
Owner: nicho...@chromium.org
Status: Assigned (was: Untriaged)
Gus is working on this.
Project Member

Comment 2 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49ccc86fa6f0112e768dda3b7dd2d78529275ca8

commit 49ccc86fa6f0112e768dda3b7dd2d78529275ca8
Author: gusss <gusss@google.com>
Date: Fri May 26 17:35:41 2017

Host port range policy is no longer ignored in it2me host.

Adds UpdateHostUdpPortRangePolicy into It2MeHost, which is called whenever a policy update contains a port range setting. This port range setting is then stored, and is later used to set the appropriate fields in the NetworkSettings object passed into the TransportContext.

BUG= 723093 

Review-Url: https://codereview.chromium.org/2901033002
Cr-Commit-Position: refs/heads/master@{#475047}

[modify] https://crrev.com/49ccc86fa6f0112e768dda3b7dd2d78529275ca8/remoting/host/chromoting_host.h
[modify] https://crrev.com/49ccc86fa6f0112e768dda3b7dd2d78529275ca8/remoting/host/it2me/it2me_host.cc
[modify] https://crrev.com/49ccc86fa6f0112e768dda3b7dd2d78529275ca8/remoting/host/it2me/it2me_host.h
[modify] https://crrev.com/49ccc86fa6f0112e768dda3b7dd2d78529275ca8/remoting/host/it2me/it2me_host_unittest.cc

Comment 3 by gusss@google.com, May 26 2017

Status: Fixed (was: Assigned)
Cc: gusss@google.com
Labels: M-60 Merge-Request-60
Owner: sergeyu@chromium.org
Status: Started (was: Fixed)
Project Member

Comment 5 by sheriffbot@chromium.org, May 30 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, May 30 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ca472105b2cb318faaf61882000504fd8f7649f

commit 8ca472105b2cb318faaf61882000504fd8f7649f
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue May 30 18:33:08 2017

Host port range policy is no longer ignored in it2me host.

Adds UpdateHostUdpPortRangePolicy into It2MeHost, which is called whenever a policy update contains a port range setting. This port range setting is then stored, and is later used to set the appropriate fields in the NetworkSettings object passed into the TransportContext.

BUG= 723093 

Review-Url: https://codereview.chromium.org/2901033002
Cr-Original-Commit-Position: refs/heads/master@{#475047}
Review-Url: https://codereview.chromium.org/2912143002 .
Cr-Commit-Position: refs/branch-heads/3112@{#35}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/8ca472105b2cb318faaf61882000504fd8f7649f/remoting/host/chromoting_host.h
[modify] https://crrev.com/8ca472105b2cb318faaf61882000504fd8f7649f/remoting/host/it2me/it2me_host.cc
[modify] https://crrev.com/8ca472105b2cb318faaf61882000504fd8f7649f/remoting/host/it2me/it2me_host.h
[modify] https://crrev.com/8ca472105b2cb318faaf61882000504fd8f7649f/remoting/host/it2me/it2me_host_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment