New issue
Advanced search Search tips

Issue 723092 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Lock screen dialogs to use dom-if.

Project Member Reported by sammiequon@chromium.org, May 16 2017

Issue description

Change lock screen dialogs to use dom-if instead of open/close. That seems to be the norm. Fingerprint dialog as well too.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54d7eb0b3a09f39e9db65452d72209bee09fd006

commit 54d7eb0b3a09f39e9db65452d72209bee09fd006
Author: sammiequon <sammiequon@chromium.org>
Date: Fri Jun 02 03:45:47 2017

md-settings: wrap lock screen dialogs in dom-if.

Also had to modify some tests. This also fixes issue where lock screen page flickers when pressing back button on people page, after canceling a password authentication.

TEST=manual, browser_test --gtest_filter="CrSettingsPeoplePageLockScreenTest.*:CrSettingsPeoplePageSetupPinDialogTest.*:CrSettingsFingerprintListTest.*"
BUG= 723092 ,728394
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2893053002
Cr-Commit-Position: refs/heads/master@{#476554}

[modify] https://crrev.com/54d7eb0b3a09f39e9db65452d72209bee09fd006/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
[modify] https://crrev.com/54d7eb0b3a09f39e9db65452d72209bee09fd006/chrome/browser/resources/settings/people_page/fingerprint_list.html
[modify] https://crrev.com/54d7eb0b3a09f39e9db65452d72209bee09fd006/chrome/browser/resources/settings/people_page/fingerprint_list.js
[modify] https://crrev.com/54d7eb0b3a09f39e9db65452d72209bee09fd006/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/54d7eb0b3a09f39e9db65452d72209bee09fd006/chrome/browser/resources/settings/people_page/lock_screen.js
[modify] https://crrev.com/54d7eb0b3a09f39e9db65452d72209bee09fd006/chrome/browser/resources/settings/people_page/password_prompt_dialog.html
[modify] https://crrev.com/54d7eb0b3a09f39e9db65452d72209bee09fd006/chrome/browser/resources/settings/people_page/password_prompt_dialog.js
[modify] https://crrev.com/54d7eb0b3a09f39e9db65452d72209bee09fd006/chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.js
[modify] https://crrev.com/54d7eb0b3a09f39e9db65452d72209bee09fd006/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
[modify] https://crrev.com/54d7eb0b3a09f39e9db65452d72209bee09fd006/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
[modify] https://crrev.com/54d7eb0b3a09f39e9db65452d72209bee09fd006/chrome/test/data/webui/settings/fingerprint_browsertest_chromeos.js
[modify] https://crrev.com/54d7eb0b3a09f39e9db65452d72209bee09fd006/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js

Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment