New issue
Advanced search Search tips

Issue 723088 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 718612
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Chrome Data Use Ascriber does not separate navigations in the same webcontents

Project Member Reported by ryansturm@chromium.org, May 16 2017

Issue description

I suspect https://cs.chromium.org/chromium/src/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc?type=cs&l=161 is part of the problem. I mainly suspect this because if the navigation is ready to commit, it won't ever be committed.
 
Cc: rajendrant@chromium.org
This is related to rajendrant@'s work on DidFinishNavigation vs ReadyToCommitNavigation.
Looks like this is related to transfer navigations.
Yes. Both cause this problem. !navigation_handle->HasCommitted() check and also transfer navigations.

Following CL fixes it:
https://codereview.chromium.org/2875263003/

But I am still testing for all cases, after removing HasCommitted() check.

Comment 4 by bengr@chromium.org, May 17 2017

Status: Started (was: Assigned)
Mergedinto: 718612
Status: Duplicate (was: Started)

Sign in to add a comment