Hundreds of registry/plist reads of the brand code per tab |
||||||
Issue descriptionChrome Version: 60 OS: Win10, OSX 10.12 What steps will reproduce the problem? (1) On Windows start Process Monitor and set filter to observe only registry events with path containing "brand" (2) Launch chrome with a single tab. (3) Look at the registry events - hundreds of them are registered. On Mac the reads happen from the Info.plist file and the following command tracks them: sudo fs_usage -w -f pathname | grep Chrome | grep Info.plist What is the expected result? On Windows we should observe only a handful of reads, ideally 1. What happens instead? Hundreds of reads happen. There is an RLZ code that checks the brand code fairly often and it doesn't cache it.
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c295631f2dda9cc64b1b9becd12527c12efe8802 commit c295631f2dda9cc64b1b9becd12527c12efe8802 Author: thestig <thestig@chromium.org> Date: Thu May 18 01:59:57 2017 Revert of Avoid unnecessary registry/plist reads (hundreds of them) by caching the brand code. (patchset #5 id:80001 of https://codereview.chromium.org/2891453004/ ) Reason for revert: Broke official builds due to chromium-style compiler error. Original issue's description: > Avoid unnecessary registry/plist reads (hundreds of them) by caching the brand code. > > BUG= 723072 > > Review-Url: https://codereview.chromium.org/2891453004 > Cr-Commit-Position: refs/heads/master@{#472622} > Committed: https://chromium.googlesource.com/chromium/src/+/4c703a924fc505015240e1ee859c6a9340d4be2e TBR=pkasting@chromium.org,grt@chromium.org,borisv@chromium.org,borisv@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 723072 Review-Url: https://codereview.chromium.org/2893483004 Cr-Commit-Position: refs/heads/master@{#472624} [modify] https://crrev.com/c295631f2dda9cc64b1b9becd12527c12efe8802/chrome/browser/search_engines/ui_thread_search_terms_data.cc
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04749717bf2f41bf945b73d9729d24eb262b2843 commit 04749717bf2f41bf945b73d9729d24eb262b2843 Author: borisv <borisv@chromium.org> Date: Fri May 19 05:56:23 2017 Cache the brand code to avoid hundreds of repeated reads. BUG= 723072 Review-Url: https://codereview.chromium.org/2890943005 Cr-Commit-Position: refs/heads/master@{#473102} [modify] https://crrev.com/04749717bf2f41bf945b73d9729d24eb262b2843/chrome/browser/search_engines/ui_thread_search_terms_data.cc
,
May 23 2017
,
May 23 2017
,
Dec 14 2017
This has been reverted: https://chromium-review.googlesource.com/c/chromium/src/+/824363
,
Dec 14 2017
,
Jan 29 2018
Merging into issue 806130 , which proposes a mechanism to achieve a Windows-specific solution for this issue. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, May 18 2017