DCHECK_EQ failure at the constructor of AvatarButton
Reported by
sungmann...@navercorp.com,
May 16 2017
|
|||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.96 Safari/537.36 Steps to reproduce the problem: 1. Run a debug version of chrome.exe with --disable-dwm-composition on Windows 10 2. 3. What is the expected behavior? What went wrong? A 'fatal error' dialog appears. Did this work before? N/A Chrome version: 58.0.3029.96 Channel: n/a OS Version: 10.0 Flash Version:
,
May 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b08234bf776baa8a8517fc6c0145526055353d0 commit 1b08234bf776baa8a8517fc6c0145526055353d0 Author: sungmann.cho <sungmann.cho@navercorp.com> Date: Wed May 17 13:52:08 2017 Use the win10 native avatar button only for AvatarButtonStyle::NATIVE OpaqueBrowserFrameView creates AvatarButton with AvatarButtonStyle::THEMED, and this leads to DCHECK_EQ failure at the constructor of AvatarButton. BUG= 723070 Review-Url: https://codereview.chromium.org/2891573002 Cr-Commit-Position: refs/heads/master@{#472443} [modify] https://crrev.com/1b08234bf776baa8a8517fc6c0145526055353d0/chrome/browser/ui/views/profiles/avatar_button.cc
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f752dd6fb26463148e8720f2353f62a31939cdd commit 8f752dd6fb26463148e8720f2353f62a31939cdd Author: sungmann.cho <sungmann.cho@navercorp.com> Date: Fri May 19 00:07:09 2017 Always use the new style avatar button for the glass frame on Windows 10 The new style avatar button is currently used only for the non-themed glass frame, but it would be more reasonable to use it for both the themed and the non-themed glass frame for aesthetic consistency. BUG= 723070 Review-Url: https://codereview.chromium.org/2887363002 Cr-Commit-Position: refs/heads/master@{#472981} [modify] https://crrev.com/8f752dd6fb26463148e8720f2353f62a31939cdd/chrome/browser/ui/views/profiles/avatar_button.cc
,
Jul 20 2017
,
Oct 25 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sungmann...@navercorp.com
, May 16 20172.6 MB
2.6 MB Download