New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 593874



Sign in to add a comment
link

Issue 723069: Add a global dependencies target

Reported by thomasanderson@chromium.org, May 16 2017 Project Member

Issue description

All targets (at least on sanitizer builds) unconditionally depend on //build/config/sanitizers:deps (which is a no-op on non-sanitizer builds).

It is necessary for  bug 593874  that all targets now also depend on //buildtools/third_party/libc++:libcxx_proxy.  This suggests a new "global dependency" should be added.  Something like //build/config:exe_and_shlib_deps
 

Comment 1 by bugdroid1@chromium.org, May 18 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1334d4270679548dba126bca749e54bb4232310a

commit 1334d4270679548dba126bca749e54bb4232310a
Author: thomasanderson <thomasanderson@chromium.org>
Date: Thu May 18 21:48:28 2017

Add //build/config:exe_and_shlib_deps

This CL adds a new target that all executables and shared libraries
should depend on in preparation for adding a dependency on libc++.  It
also changes "component" to reference this new target instead of
//build/config/sanitizers:deps.

BUG= 723069 
R=dpranke@chromium.org,thakis@chromium.org,brettw@chromium.org

Review-Url: https://codereview.chromium.org/2888713003
Cr-Commit-Position: refs/heads/master@{#472940}

[modify] https://crrev.com/1334d4270679548dba126bca749e54bb4232310a/build/config/BUILD.gn
[modify] https://crrev.com/1334d4270679548dba126bca749e54bb4232310a/build/config/BUILDCONFIG.gn

Comment 2 by bugdroid1@chromium.org, May 18 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84fa8b0864ae839a74233d9cb0bc10fee9a892df

commit 84fa8b0864ae839a74233d9cb0bc10fee9a892df
Author: thomasanderson <thomasanderson@chromium.org>
Date: Thu May 18 23:38:47 2017

Replace sanitizers:deps with exe_and_shlib_deps (Chromium repo only)

BUG= 723069 
R=brettw@chromium.org,xhwang@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2892493002
Cr-Commit-Position: refs/heads/master@{#472971}

[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/ash/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/base/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/base/android/linker/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/base/test/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/breakpad/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/chrome/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/chrome/android/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/chrome/chrome_watcher/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/chrome/installer/mini_installer/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/chrome/installer/setup/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/chrome/installer/test/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/chrome/test/chromedriver/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/chrome/tools/convert_dict/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/chrome/tools/service_discovery_sniffer/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/chrome_elf/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/chromecast/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/components/cronet/ios/cronet_consumer/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/components/sync/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/components/wifi/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/content/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/content/browser/bluetooth/tools/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/content/shell/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/content/shell/android/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/courgette/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/dbus/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/extensions/shell/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/gin/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/google_apis/gcm/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/gpu/gles2_conform_support/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/gpu/tools/compositor_model_bench/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/ios/showcase/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/ios/web/shell/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/ios/web/shell/test/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/ios/web_view/shell/test/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/mash/runner/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/media/cast/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/media/cdm/ppapi/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/mojo/android/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/net/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/net/tools/transport_security_state_generator/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/ppapi/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/remoting/host/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/remoting/host/it2me/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/remoting/host/linux/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/remoting/host/mac/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/remoting/test/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/remoting/tools/javascript_key_tester/pnacl/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/rlz/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/sandbox/linux/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/sandbox/win/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/services/service_manager/public/cpp/service.gni
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/services/service_manager/tests/connect/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/services/service_manager/tests/lifecycle/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/services/service_manager/tests/service_manager/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/skia/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/storage/browser/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/testing/test.gni
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/third_party/android_platform/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/third_party/android_protobuf/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/third_party/brotli/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/third_party/flatbuffers/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/third_party/ijar/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/third_party/mesa/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/third_party/opus/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/third_party/protobuf/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/third_party/qcms/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/third_party/sqlite/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/third_party/widevine/cdm/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/third_party/yasm/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/tools/android/forwarder2/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/tools/android/md5sum/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/tools/battor_agent/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/tools/gn/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/tools/imagediff/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/tools/perf/clear_system_cache/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/tools/xdisplaycheck/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/ui/app_list/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/ui/aura/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/ui/file_manager/zip_archiver/cpp/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/ui/ozone/demo/BUILD.gn
[modify] https://crrev.com/84fa8b0864ae839a74233d9cb0bc10fee9a892df/ui/views/examples/BUILD.gn

Comment 3 by bugdroid1@chromium.org, May 19 2017

Project Member
The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/22644731e0e46eae1f50927376e557c7d64db1d5

commit 22644731e0e46eae1f50927376e557c7d64db1d5
Author: Tom Anderson <thomasanderson@google.com>
Date: Fri May 19 00:48:57 2017

Replace sanitizers:deps with exe_and_shlib_deps (pdfium)

Roll build/ to f671d3b and replace "//build/config/sanitizers:deps"
with "//build/config:exe_and_shlib_deps"

Bug= chromium:723069 
R=thestig@chromium.org

Change-Id: Ib890f22a13769a594ce248637aeabc5ac3062ab2
Reviewed-on: https://pdfium-review.googlesource.com/5670
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/22644731e0e46eae1f50927376e557c7d64db1d5/third_party/yasm/BUILD.gn
[modify] https://crrev.com/22644731e0e46eae1f50927376e557c7d64db1d5/samples/BUILD.gn
[modify] https://crrev.com/22644731e0e46eae1f50927376e557c7d64db1d5/DEPS

Comment 5 by bugdroid1@chromium.org, May 19 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/cb7dd0a911adf91afbe9ebae3df84b56756087d3

commit cb7dd0a911adf91afbe9ebae3df84b56756087d3
Author: thomasanderson <thomasanderson@chromium.org>
Date: Fri May 19 21:52:47 2017

Replace sanitizers:deps with exe_and_shlib_deps (v8)

All targets (at least on sanitizer builds) unconditionally depend
on //build/config/sanitizers:deps.

It is necessary for  bug 593874  that all targets now also depend
on //buildtools/third_party/libc++:libcxx_proxy.  This requires
adding a new "global dependency": //build/config:exe_and_shlib_deps.

This CL updates references to sanitizers:deps to instead refer to
//build/config:exe_and_shlib_deps.

BUG= chromium:723069 
R=bradnelson@chromium.org

Review-Url: https://codereview.chromium.org/2894013003
Cr-Commit-Position: refs/heads/master@{#45435}

[modify] https://crrev.com/cb7dd0a911adf91afbe9ebae3df84b56756087d3/BUILD.gn
[modify] https://crrev.com/cb7dd0a911adf91afbe9ebae3df84b56756087d3/test/cctest/BUILD.gn
[modify] https://crrev.com/cb7dd0a911adf91afbe9ebae3df84b56756087d3/test/inspector/BUILD.gn
[modify] https://crrev.com/cb7dd0a911adf91afbe9ebae3df84b56756087d3/test/mkgrokdump/BUILD.gn
[modify] https://crrev.com/cb7dd0a911adf91afbe9ebae3df84b56756087d3/test/unittests/BUILD.gn

Comment 6 by bugdroid1@chromium.org, May 19 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca61e77bb3744ec5ea08e8d7cbeea818f3e44f3f

commit ca61e77bb3744ec5ea08e8d7cbeea818f3e44f3f
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Fri May 19 22:15:04 2017

Roll src/third_party/catapult/ 16b38d742..08a6e0ac1 (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/16b38d742568..08a6e0ac161d

$ git log 16b38d742..08a6e0ac1 --date=short --no-merges --format='%ad %ae %s'
2017-05-19 thomasanderson Replace sanitizers:deps with exe_and_shlib_deps (catapult)

Created with:
  roll-dep src/third_party/catapult
BUG= 723069 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ib279c2ba7fc20fb3c3a3ad57bc62f341333d9f02
Reviewed-on: https://chromium-review.googlesource.com/510009
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473355}
[modify] https://crrev.com/ca61e77bb3744ec5ea08e8d7cbeea818f3e44f3f/DEPS

Comment 7 by bugdroid1@chromium.org, May 19 2017

Project Member
The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/41e3c35db0d01098fcf8cb86e22ff6ac846d5a15

commit 41e3c35db0d01098fcf8cb86e22ff6ac846d5a15
Author: Tom Anderson <thomasanderson@google.com>
Date: Fri May 19 22:39:12 2017

Update more references to sanitizers:deps

[1] updated sanitizers:deps references to exe_and_shlib_deps.
However, this was only for *.gn files.  I missed a *.gni file which is
changed in this CL.

[1] https://pdfium-review.googlesource.com/c/5670/

Bug= chromium:723069 
R=thestig@chromium.org

Change-Id: Ib5e0c0a31f4227b89d067f9645c2c78945c1ab4f
Reviewed-on: https://pdfium-review.googlesource.com/5734
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/41e3c35db0d01098fcf8cb86e22ff6ac846d5a15/testing/test.gni

Comment 8 by bugdroid1@chromium.org, May 23 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/native_client/src/native_client.git/+/3e3253af7d201e8793cca4f36c5163bdb58074c7

commit 3e3253af7d201e8793cca4f36c5163bdb58074c7
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue May 23 06:16:25 2017

Replace sanitizers:deps with exe_and_shlib_deps (native_client)

All targets (at least on sanitizer builds) unconditionally depend
on //build/config/sanitizers:deps.

It is necessary for  bug 593874  that all targets now also depend
on //buildtools/third_party/libc++:libcxx_proxy.  This requires
adding a new "global dependency": //build/config:exe_and_shlib_deps.

This CL updates references to sanitizers:deps to instead refer to
//build/config:exe_and_shlib_deps.

BUG= chromium:723069 
R=bradnelson@chromium.org
NOTRY=true

Change-Id: Id45d405c0eb79cf9d4d8375f04c3e69f9157671d
Reviewed-on: https://chromium-review.googlesource.com/509938
Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Commit-Queue: Brad Nelson <bradnelson@chromium.org>

[modify] https://crrev.com/3e3253af7d201e8793cca4f36c5163bdb58074c7/DEPS
[modify] https://crrev.com/3e3253af7d201e8793cca4f36c5163bdb58074c7/src/tools/tls_edit/BUILD.gn
[modify] https://crrev.com/3e3253af7d201e8793cca4f36c5163bdb58074c7/src/trusted/debug_stub/BUILD.gn
[modify] https://crrev.com/3e3253af7d201e8793cca4f36c5163bdb58074c7/src/trusted/service_runtime/BUILD.gn
[modify] https://crrev.com/3e3253af7d201e8793cca4f36c5163bdb58074c7/src/trusted/validator/driver/BUILD.gn

Comment 9 by bugdroid1@chromium.org, May 23 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c051edbbf2aeeb61144a5756752c677ca1147b78

commit c051edbbf2aeeb61144a5756752c677ca1147b78
Author: nacl-deps-roller@chromium.org <nacl-deps-roller@chromium.org>
Date: Tue May 23 22:50:42 2017

Roll src/native_client/ aac1de245..3e3253af7 (2 commits)

https://chromium.googlesource.com/native_client/src/native_client.git/+log/aac1de245362..3e3253af7d20

$ git log aac1de245..3e3253af7 --date=short --no-merges --format='%ad %ae %s'
2017-05-19 thomasanderson Replace sanitizers:deps with exe_and_shlib_deps (native_client)
2017-04-12 borenet Whitespace change to test the Autoroller via Gerrit

Created with:
  roll-dep src/native_client
BUG= 723069 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
TBR=mseaborn@chromium.org

Change-Id: I63a571212aab489ed82ffc4f941bf7f3f33161ca
Reviewed-on: https://chromium-review.googlesource.com/513145
Reviewed-by: <nacl-deps-roller@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Mark Seaborn <mseaborn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474092}
[modify] https://crrev.com/c051edbbf2aeeb61144a5756752c677ca1147b78/DEPS

Comment 10 by bugdroid1@chromium.org, May 24 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f65051935b939d3fed895a045308261f363f395b

commit f65051935b939d3fed895a045308261f363f395b
Author: thomasanderson <thomasanderson@chromium.org>
Date: Wed May 24 00:31:30 2017

Whitelist exe_and_shlib_deps to include sanitizers:deps

BUG= 723069 
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2898303002
Cr-Commit-Position: refs/heads/master@{#474121}

[modify] https://crrev.com/f65051935b939d3fed895a045308261f363f395b/build/config/sanitizers/BUILD.gn

Comment 11 by bugdroid1@chromium.org, May 24 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e449acf2a251e5130b41c2e69ab1bc7b6a534b48

commit e449acf2a251e5130b41c2e69ab1bc7b6a534b48
Author: thomasanderson <thomasanderson@chromium.org>
Date: Wed May 24 04:16:24 2017

Add missing dependency on exe_and_shlib_deps

BUG= 723069 
R=bradnelson@chromium.org

Review-Url: https://codereview.chromium.org/2905513002
Cr-Commit-Position: refs/heads/master@{#474160}

[modify] https://crrev.com/e449acf2a251e5130b41c2e69ab1bc7b6a534b48/chrome/browser/nacl_host/test/BUILD.gn

Comment 12 by bugdroid1@chromium.org, May 25 2017

Project Member
The following revision refers to this bug:
  https://boringssl.googlesource.com/boringssl/+/68f84f5c40644e029ed066999448696b01caba7a

commit 68f84f5c40644e029ed066999448696b01caba7a
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu May 25 17:26:44 2017

Add missing dependencies on exe_and_shlib_deps

Corresponding Chrome CL:
https://codereview.chromium.org/2899403004/

BUG= chromium:723069 

Change-Id: I0ab9c104263d12e8251adf60d89ad19cf0436785
Reviewed-on: https://boringssl-review.googlesource.com/16664
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>

[modify] https://crrev.com/68f84f5c40644e029ed066999448696b01caba7a/util/generate_build_files.py

Comment 13 by bugdroid1@chromium.org, May 25 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/26098cb2efc09b845fccc6560fbf6e8f375db315

commit 26098cb2efc09b845fccc6560fbf6e8f375db315
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu May 25 18:53:05 2017

Add missing dependencies on exe_and_shlib_deps (angle)

BUG= chromium:723069 

Change-Id: I2b3c9be297c2b65955e31f393756ca266cc7c60b
Reviewed-on: https://chromium-review.googlesource.com/514436
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/26098cb2efc09b845fccc6560fbf6e8f375db315/BUILD.gn
[modify] https://crrev.com/26098cb2efc09b845fccc6560fbf6e8f375db315/src/vulkan_support/BUILD.gn

Comment 14 by bugdroid1@chromium.org, May 25 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/26098cb2efc09b845fccc6560fbf6e8f375db315

commit 26098cb2efc09b845fccc6560fbf6e8f375db315
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu May 25 18:53:05 2017

Add missing dependencies on exe_and_shlib_deps (angle)

BUG= chromium:723069 

Change-Id: I2b3c9be297c2b65955e31f393756ca266cc7c60b
Reviewed-on: https://chromium-review.googlesource.com/514436
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/26098cb2efc09b845fccc6560fbf6e8f375db315/BUILD.gn
[modify] https://crrev.com/26098cb2efc09b845fccc6560fbf6e8f375db315/src/vulkan_support/BUILD.gn

Comment 15 by bugdroid1@chromium.org, May 26 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a5b43da4d706751276a46486256ad6677014868

commit 0a5b43da4d706751276a46486256ad6677014868
Author: ynovikov <ynovikov@chromium.org>
Date: Fri May 26 00:40:52 2017

Roll ANGLE 9e3bd31..ff77c35

https://chromium.googlesource.com/angle/angle.git/+log/9e3bd31..ff77c35

BUG=None,449754,chromium:723856,chromium:723069,722684,chromium:699479
TBR=jmadill@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2908513003
Cr-Commit-Position: refs/heads/master@{#474852}

[modify] https://crrev.com/0a5b43da4d706751276a46486256ad6677014868/DEPS

Comment 16 by bugdroid1@chromium.org, May 26 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e926233bf660c42676d6bd4cb77dade846aca69

commit 9e926233bf660c42676d6bd4cb77dade846aca69
Author: thomasanderson <thomasanderson@chromium.org>
Date: Fri May 26 18:09:01 2017

Add missing dependencies on exe_and_shlib_deps (Chromium repo)

BUG= 723069 
R=brettw@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng

Review-Url: https://codereview.chromium.org/2899403004
Cr-Commit-Position: refs/heads/master@{#475059}

[modify] https://crrev.com/9e926233bf660c42676d6bd4cb77dade846aca69/components/url_formatter/top_domains/BUILD.gn
[modify] https://crrev.com/9e926233bf660c42676d6bd4cb77dade846aca69/gpu/BUILD.gn
[modify] https://crrev.com/9e926233bf660c42676d6bd4cb77dade846aca69/headless/BUILD.gn
[modify] https://crrev.com/9e926233bf660c42676d6bd4cb77dade846aca69/media/cast/BUILD.gn
[modify] https://crrev.com/9e926233bf660c42676d6bd4cb77dade846aca69/media/cdm/ppapi/ppapi_cdm_adapter.gni
[modify] https://crrev.com/9e926233bf660c42676d6bd4cb77dade846aca69/net/BUILD.gn
[modify] https://crrev.com/9e926233bf660c42676d6bd4cb77dade846aca69/ppapi/examples/ppapi_example.gni
[modify] https://crrev.com/9e926233bf660c42676d6bd4cb77dade846aca69/remoting/host/linux/BUILD.gn
[modify] https://crrev.com/9e926233bf660c42676d6bd4cb77dade846aca69/remoting/test/BUILD.gn
[modify] https://crrev.com/9e926233bf660c42676d6bd4cb77dade846aca69/third_party/leveldatabase/BUILD.gn

Comment 17 by bugdroid1@chromium.org, May 26 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0503f5125ed2c1f6b1cd8001b1f83731493d5ea7

commit 0503f5125ed2c1f6b1cd8001b1f83731493d5ea7
Author: nednguyen <nednguyen@google.com>
Date: Fri May 26 19:04:51 2017

Revert of Add missing dependencies on exe_and_shlib_deps (Chromium repo) (patchset #2 id:60001 of https://codereview.chromium.org/2899403004/ )

Reason for revert:
BUG= 726808 

Suspecting causing generate_build_files failure (according to FindIt)

Original issue's description:
> Add missing dependencies on exe_and_shlib_deps (Chromium repo)
>
> BUG= 723069 
> R=brettw@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
>
> Review-Url: https://codereview.chromium.org/2899403004
> Cr-Commit-Position: refs/heads/master@{#475059}
> Committed: https://chromium.googlesource.com/chromium/src/+/9e926233bf660c42676d6bd4cb77dade846aca69

TBR=brettw@chromium.org,davidben@chromium.org,thomasanderson@google.com,thomasanderson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 723069 

Review-Url: https://codereview.chromium.org/2912513002
Cr-Commit-Position: refs/heads/master@{#475077}

[modify] https://crrev.com/0503f5125ed2c1f6b1cd8001b1f83731493d5ea7/components/url_formatter/top_domains/BUILD.gn
[modify] https://crrev.com/0503f5125ed2c1f6b1cd8001b1f83731493d5ea7/gpu/BUILD.gn
[modify] https://crrev.com/0503f5125ed2c1f6b1cd8001b1f83731493d5ea7/headless/BUILD.gn
[modify] https://crrev.com/0503f5125ed2c1f6b1cd8001b1f83731493d5ea7/media/cast/BUILD.gn
[modify] https://crrev.com/0503f5125ed2c1f6b1cd8001b1f83731493d5ea7/media/cdm/ppapi/ppapi_cdm_adapter.gni
[modify] https://crrev.com/0503f5125ed2c1f6b1cd8001b1f83731493d5ea7/net/BUILD.gn
[modify] https://crrev.com/0503f5125ed2c1f6b1cd8001b1f83731493d5ea7/ppapi/examples/ppapi_example.gni
[modify] https://crrev.com/0503f5125ed2c1f6b1cd8001b1f83731493d5ea7/remoting/host/linux/BUILD.gn
[modify] https://crrev.com/0503f5125ed2c1f6b1cd8001b1f83731493d5ea7/remoting/test/BUILD.gn
[modify] https://crrev.com/0503f5125ed2c1f6b1cd8001b1f83731493d5ea7/third_party/leveldatabase/BUILD.gn

Comment 18 by bugdroid1@chromium.org, May 26 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7a527720b277b3ec4af030be6c32e288f0b18c6

commit b7a527720b277b3ec4af030be6c32e288f0b18c6
Author: thomasanderson <thomasanderson@chromium.org>
Date: Fri May 26 19:26:42 2017

Reland of Add missing dependencies on exe_and_shlib_deps (Chromium repo) (patchset #1 id:1 of https://codereview.chromium.org/2912513002/ )

Reason for revert:
The failing build [1] failed because of an internal issue (gclient sync failure), not because of the original cl

[1] https://build.chromium.org/p/chromium.linux/builders/Deterministic%20Linux/builds/3055

Original issue's description:
> Revert of Add missing dependencies on exe_and_shlib_deps (Chromium repo) (patchset #2 id:60001 of https://codereview.chromium.org/2899403004/ )
>
> Reason for revert:
> BUG= 726808 
>
> Suspecting causing generate_build_files failure (according to FindIt)
>
> Original issue's description:
> > Add missing dependencies on exe_and_shlib_deps (Chromium repo)
> >
> > BUG= 723069 
> > R=brettw@chromium.org
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
> >
> > Review-Url: https://codereview.chromium.org/2899403004
> > Cr-Commit-Position: refs/heads/master@{#475059}
> > Committed: https://chromium.googlesource.com/chromium/src/+/9e926233bf660c42676d6bd4cb77dade846aca69
>
> TBR=brettw@chromium.org,davidben@chromium.org,thomasanderson@google.com,thomasanderson@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 723069 
>
> Review-Url: https://codereview.chromium.org/2912513002
> Cr-Commit-Position: refs/heads/master@{#475077}
> Committed: https://chromium.googlesource.com/chromium/src/+/0503f5125ed2c1f6b1cd8001b1f83731493d5ea7

TBR=brettw@chromium.org,davidben@chromium.org,thomasanderson@google.com,nednguyen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 726808 

Review-Url: https://codereview.chromium.org/2911643003
Cr-Commit-Position: refs/heads/master@{#475086}

[modify] https://crrev.com/b7a527720b277b3ec4af030be6c32e288f0b18c6/components/url_formatter/top_domains/BUILD.gn
[modify] https://crrev.com/b7a527720b277b3ec4af030be6c32e288f0b18c6/gpu/BUILD.gn
[modify] https://crrev.com/b7a527720b277b3ec4af030be6c32e288f0b18c6/headless/BUILD.gn
[modify] https://crrev.com/b7a527720b277b3ec4af030be6c32e288f0b18c6/media/cast/BUILD.gn
[modify] https://crrev.com/b7a527720b277b3ec4af030be6c32e288f0b18c6/media/cdm/ppapi/ppapi_cdm_adapter.gni
[modify] https://crrev.com/b7a527720b277b3ec4af030be6c32e288f0b18c6/net/BUILD.gn
[modify] https://crrev.com/b7a527720b277b3ec4af030be6c32e288f0b18c6/ppapi/examples/ppapi_example.gni
[modify] https://crrev.com/b7a527720b277b3ec4af030be6c32e288f0b18c6/remoting/host/linux/BUILD.gn
[modify] https://crrev.com/b7a527720b277b3ec4af030be6c32e288f0b18c6/remoting/test/BUILD.gn
[modify] https://crrev.com/b7a527720b277b3ec4af030be6c32e288f0b18c6/third_party/leveldatabase/BUILD.gn

Comment 19 by bugdroid1@chromium.org, Jun 7 2017

Project Member
Labels: merge-merged-58
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/ebff529f0436a764e6e98cca50ca5a8cdb27ff78

commit ebff529f0436a764e6e98cca50ca5a8cdb27ff78
Author: kjellander <kjellander@webrtc.org>
Date: Wed Jun 07 06:43:54 2017

Replace sanitizers:deps with exe_and_shlib_deps (webrtc)

BUG= chromium:723069 ,  webrtc:7762 
R=mbonadei@webrtc.org
NOTRY=True
NOPRESUBMIT=true

Review-Url: https://codereview.webrtc.org/2897523002
Cr-Original-Commit-Position: refs/heads/master@{#18206}
Review-Url: https://codereview.webrtc.org/2922423003
Cr-Commit-Position: refs/branch-heads/58@{#20}
Cr-Branched-From: f31969a584bcafe9406c214a9d4c3afb49d19650-refs/heads/master@{#16937}

[modify] https://crrev.com/ebff529f0436a764e6e98cca50ca5a8cdb27ff78/webrtc/tools/BUILD.gn
[modify] https://crrev.com/ebff529f0436a764e6e98cca50ca5a8cdb27ff78/webrtc/webrtc.gni

Comment 20 by bugdroid1@chromium.org, Jun 7 2017

Project Member
Labels: merge-merged-59
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/0d665af77aadb2339722ffdefa257588fadc1a78

commit 0d665af77aadb2339722ffdefa257588fadc1a78
Author: kjellander <kjellander@webrtc.org>
Date: Wed Jun 07 07:28:30 2017

Replace sanitizers:deps with exe_and_shlib_deps (webrtc)

BUG= chromium:723069 ,  webrtc:7762 
R=mbonadei@webrtc.org
NOTRY=True
NOPRESUBMIT=true

Review-Url: https://codereview.webrtc.org/2897523002
Cr-Original-Commit-Position: refs/heads/master@{#18206}
Review-Url: https://codereview.webrtc.org/2930603002
Cr-Commit-Position: refs/branch-heads/59@{#17}
Cr-Branched-From: 10d095d4f743bc16f8e486e156c48a6d023b32c5-refs/heads/master@{#17657}

[modify] https://crrev.com/0d665af77aadb2339722ffdefa257588fadc1a78/webrtc/tools/BUILD.gn
[modify] https://crrev.com/0d665af77aadb2339722ffdefa257588fadc1a78/webrtc/webrtc.gni

Comment 21 by bugdroid1@chromium.org, Jun 7 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/0d665af77aadb2339722ffdefa257588fadc1a78

commit 0d665af77aadb2339722ffdefa257588fadc1a78
Author: kjellander <kjellander@webrtc.org>
Date: Wed Jun 07 07:28:30 2017

Replace sanitizers:deps with exe_and_shlib_deps (webrtc)

BUG= chromium:723069 ,  webrtc:7762 
R=mbonadei@webrtc.org
NOTRY=True
NOPRESUBMIT=true

Review-Url: https://codereview.webrtc.org/2897523002
Cr-Original-Commit-Position: refs/heads/master@{#18206}
Review-Url: https://codereview.webrtc.org/2930603002
Cr-Commit-Position: refs/branch-heads/59@{#17}
Cr-Branched-From: 10d095d4f743bc16f8e486e156c48a6d023b32c5-refs/heads/master@{#17657}

[modify] https://crrev.com/0d665af77aadb2339722ffdefa257588fadc1a78/webrtc/tools/BUILD.gn
[modify] https://crrev.com/0d665af77aadb2339722ffdefa257588fadc1a78/webrtc/webrtc.gni

Comment 22 by bugdroid1@chromium.org, Jun 8 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/26d147165e71878fb183b4d16f20ccfe8b12b3c3

commit 26d147165e71878fb183b4d16f20ccfe8b12b3c3
Author: kjellander <kjellander@webrtc.org>
Date: Thu Jun 08 05:27:09 2017

Revert of Replace sanitizers:deps with exe_and_shlib_deps (webrtc) (patchset #1 id:1 of https://codereview.webrtc.org/2930603002/ )

Reason for revert:
Breaks Chrome official builders (http://crbug.com/730934)

Original issue's description:
> Replace sanitizers:deps with exe_and_shlib_deps (webrtc)
>
> BUG= chromium:723069 ,  webrtc:7762 
> R=mbonadei@webrtc.org
> NOTRY=True
> NOPRESUBMIT=true
>
> Review-Url: https://codereview.webrtc.org/2897523002
> Cr-Original-Commit-Position: refs/heads/master@{#18206}
> Review-Url: https://codereview.webrtc.org/2930603002
> Cr-Commit-Position: refs/branch-heads/59@{#17}
> Cr-Branched-From: 10d095d4f743bc16f8e486e156c48a6d023b32c5-refs/heads/master@{#17657}
> Committed: https://chromium.googlesource.com/external/webrtc/+/0d665af77aadb2339722ffdefa257588fadc1a78

TBR=mbonadei@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:723069 ,  webrtc:7762 , chromium:730934

Review-Url: https://codereview.webrtc.org/2927763003
Cr-Commit-Position: refs/branch-heads/59@{#18}
Cr-Branched-From: 10d095d4f743bc16f8e486e156c48a6d023b32c5-refs/heads/master@{#17657}

[modify] https://crrev.com/26d147165e71878fb183b4d16f20ccfe8b12b3c3/webrtc/tools/BUILD.gn
[modify] https://crrev.com/26d147165e71878fb183b4d16f20ccfe8b12b3c3/webrtc/webrtc.gni

Comment 23 by bugdroid1@chromium.org, Jun 8 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/6504196a312da382d75c5ff577d10207793f2907

commit 6504196a312da382d75c5ff577d10207793f2907
Author: kjellander <kjellander@webrtc.org>
Date: Thu Jun 08 05:28:18 2017

Revert of Replace sanitizers:deps with exe_and_shlib_deps (webrtc) (patchset #1 id:1 of https://codereview.webrtc.org/2922423003/ )

Reason for revert:
Breaks Chrome official builders (http://crbug.com/730934)

Original issue's description:
> Replace sanitizers:deps with exe_and_shlib_deps (webrtc)
>
> BUG= chromium:723069 ,  webrtc:7762 
> R=mbonadei@webrtc.org
> NOTRY=True
> NOPRESUBMIT=true
>
> Review-Url: https://codereview.webrtc.org/2897523002
> Cr-Original-Commit-Position: refs/heads/master@{#18206}
> Review-Url: https://codereview.webrtc.org/2922423003
> Cr-Commit-Position: refs/branch-heads/58@{#20}
> Cr-Branched-From: f31969a584bcafe9406c214a9d4c3afb49d19650-refs/heads/master@{#16937}
> Committed: https://chromium.googlesource.com/external/webrtc/+/ebff529f0436a764e6e98cca50ca5a8cdb27ff78

TBR=mbonadei@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:723069 ,  webrtc:7762 , chromium:730934

Review-Url: https://codereview.webrtc.org/2929753002
Cr-Commit-Position: refs/branch-heads/58@{#21}
Cr-Branched-From: f31969a584bcafe9406c214a9d4c3afb49d19650-refs/heads/master@{#16937}

[modify] https://crrev.com/6504196a312da382d75c5ff577d10207793f2907/webrtc/tools/BUILD.gn
[modify] https://crrev.com/6504196a312da382d75c5ff577d10207793f2907/webrtc/webrtc.gni

Comment 24 by bugdroid1@chromium.org, Jun 9 2017

Project Member
The following revision refers to this bug:
  https://swiftshader.googlesource.com/SwiftShader.git/+/399a298b449e9f9fff72170caf06ab2214172683

commit 399a298b449e9f9fff72170caf06ab2214172683
Author: Nicolas Capens <capn@google.com>
Date: Fri Jun 09 16:45:35 2017

Add Chromium global build dependency.

All build targets must depend on //build/config:exe_and_shlib_deps.

 Bug chromium:723069 
 Bug swiftshader:54 

Change-Id: I7aaecd681ece1ed773239a88a5c4c93a75f7cd1f
Reviewed-on: https://swiftshader-review.googlesource.com/9829
Reviewed-by: Tom Anderson <thomasanderson@google.com>
Reviewed-by: Nicolas Capens <capn@google.com>
Tested-by: Nicolas Capens <capn@google.com>

[modify] https://crrev.com/399a298b449e9f9fff72170caf06ab2214172683/src/OpenGL/libEGL/BUILD.gn
[modify] https://crrev.com/399a298b449e9f9fff72170caf06ab2214172683/src/OpenGL/libGLESv2/BUILD.gn

Comment 25 by thomasanderson@chromium.org, Jun 9 2017

Status: Fixed (was: Started)

Comment 26 by bugdroid1@chromium.org, Jul 14 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c763e8bb9505f03619ad16b9ad8dc20b209627bf

commit c763e8bb9505f03619ad16b9ad8dc20b209627bf
Author: Etienne Pierre-Doray <etiennep@chromium.org>
Date: Fri Jul 14 00:02:07 2017

Add dependancy exe_and_shlib_deps for zucchini executable


Bug:  723069 
Change-Id: Ic029206b64001406858de8a18efeeec8d7c289c9
Reviewed-on: https://chromium-review.googlesource.com/571042
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486551}
[modify] https://crrev.com/c763e8bb9505f03619ad16b9ad8dc20b209627bf/chrome/installer/zucchini/BUILD.gn

Comment 27 by dnicoara@chromium.org, Mar 21 2018

If this target is _needed_ by all executables, why does it need to be explicitly added as a dependency? Is this a limitation in the build system that we can't have it implicitly added to all executable and shared library targets? Thanks!

Comment 28 by thomasanderson@chromium.org, Mar 21 2018

> Is this a limitation in the build system that we can't have it implicitly added to all executable and shared library targets?

At this time, yes.  I wonder how dpranke@ and brettw@ would feel about allowing deps in set_defaults("executable") and set_defaults("shared_library").

Comment 29 by dpranke@chromium.org, Mar 21 2018

We've generally been against it, because often it's not really needed by literally every executable, and there's relatively few executables that aren't covered by one of the other templates, like the test() template.

It's possible that there are some cases where this is really needed and would be useful, but since we try to limit GN's core feature set, we've worked around it like you saw thus far.

Sign in to add a comment