+msramek@, yitingc@: Given the fingerprinting questions discussed in the I2S thread and in https://wicg.github.io/netinfo/#privacy-considerations, it would be helpful for privacy to sign off on this.

i2s thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/UVfNMH50aaQ

For the privacy issue, I filed https://github.com/WICG/netinfo/issues/58 and would like it if someone took a look.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0

commit 1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0
Author: Tarun Bansal <tbansal@chromium.org>
Date: Fri Jul 14 04:18:09 2017

Enable NetInfo rtt, downlink, effectiveType APIs.

Enable NetInfo rtt, downlink, effectiveType APIs on all platforms.

Currently, NetInfo API is enabled only on Android and ChromeOS
platforms. To enable the rtt, downlink, effectiveType attributes
on all platforms, this CL also enables NetInfo API on all platforms
and then selectively disables other existing attributes
(type, downlinkMax, typeChange) on non-Android,
non-ChromeOS platforms.

Bug:  723068 
Change-Id: Ife4388240d6434aebf3f31d7a402d310bd4f587c
TBR: pfeldman@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/565342
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Charlie Reis (OOO until July 19) <creis@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486671}
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/content/browser/net_info_browsertest.cc
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/content/child/runtime_features.cc
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/content/public/common/content_switches.cc
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/content/public/common/content_switches.h
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/third_party/WebKit/Source/modules/netinfo/NavigatorNetworkInformation.idl
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/third_party/WebKit/Source/modules/netinfo/NetworkInformation.idl
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/third_party/WebKit/Source/modules/netinfo/WorkerNavigatorNetworkInformation.idl
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/1f332ebe9cae4e7981f8cee43fc7e4283b7e43a0/third_party/WebKit/public/platform/WebRuntimeFeatures.h

+msramek@, yitingc@: ping.

I only had one privacy concern, which was about the fingerprinting surface of this feature. We agreed to add some noise which should not significantly hurt its usability (since the returned value is an estimate anyways), but will help reduce the surface.

Sorry for my slowness in this review, Tarun, and thanks for your patience :)

 Issue 643266  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/993a3910d7e58ddcdb08de65373ce7bc466348b6

commit 993a3910d7e58ddcdb08de65373ce7bc466348b6
Author: Tarun Bansal <tbansal@chromium.org>
Date: Tue Aug 14 06:35:51 2018

Remove the flags for NetInfo JavaScript APIs.

The NetInfo network quality attributes have been enabled
since M-61. NetInfo saveData attribute has been enabled
since M-65.

Change-Id: Ie4b005834e92180d080391ea7d00f4e57c8c5df3
Bug:  723068 , 772566 
Reviewed-on: https://chromium-review.googlesource.com/1172087
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582849}
[modify] https://crrev.com/993a3910d7e58ddcdb08de65373ce7bc466348b6/third_party/blink/renderer/modules/netinfo/network_information.idl
[modify] https://crrev.com/993a3910d7e58ddcdb08de65373ce7bc466348b6/third_party/blink/renderer/platform/runtime_enabled_features.json5