[Snowflake] Unify top sheet text styles |
|||
Issue descriptionWe would like to unify text styles for top sheets (see parent bug for more details): + Change Page info URL from bold to medium Material Primary Grey 600 - 87% black - #DE000000 + Change Chooser url at top to Regular not Medium (bluetooth chooser screen) + Change Connection info green "http…" text from Regular to Medium + Connection info all text Material Primary (87%) and url to #3367D6 Spec: https://docs.google.com/document/d/1kTibP9GcfWUt_PGtmSWkIRdlozeIepuZZr7Jotw5Qs8/edit Tracker: https://docs.google.com/spreadsheets/d/1TJthSNjqaraTKgmNy2vVvW4GiZn0_j8r0ssGjV9Zvkg/edit#gid=0
,
Jun 8 2017
hannahs@ - I think the page info you are referring here is actually connection info in code, and connection info should be page info (same in sticker sheet). Could you double check? Thanks!
,
Jul 12 2017
hannahs@ - Please check screenshots before I upload a CL, thanks!
,
Jul 12 2017
lgtm! 2 quick things to check: 1. It looks like the padding under the "PAIR" button in bluetooth_dialog.png is a little short (should be the same as the padding to the right of the button. 2. The "get help" text looks like its not the right blue (should be #3367D6 if it's 14sp) 3. The line height for the paragraph text in Connection info should be 20. (20 is the minimum line height in Material specs so its a going to make the dialog a little taller but it's more legible.) Otherwise, everything should be good to ship! Thanks for making the updates!
,
Jul 15 2017
BTW, when I was changing text from bold to medium, I found that RobotoMediumStyle in style.xml is used in a lot of places (infobar, payment etc.), and the style is actually bold text font. Do you think this needs to be changed? RobotoMediumStyle is defined here: https://cs.chromium.org/chromium/src/chrome/android/java/res/values-v17/styles.xml?type=cs&q=robotomediumstyle&sq=package:chromium&l=576
,
Jul 17 2017
sans-serif-medium didn't exist until Lollipop so we use a combo of sans-serif + bold to get a similar visual effect on KitKat and JellyBean.
,
Jul 17 2017
+1 to what twellington@ said. Everything else lgtm! Thanks again for being so diligent!
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4fb04a8aaab7ab6633f8f87cf4af6e36cd0627fe commit 4fb04a8aaab7ab6633f8f87cf4af6e36cd0627fe Author: Becky Zhou <huayinz@chromium.org> Date: Tue Jul 18 18:30:43 2017 [Snowflake] Unify infobar text styles + Infobar secondary text from #646464 to 54% black + Infobar big icon control message to 20sp + Conneciton info url from bold to medium + Conneciton info description line height to 20 + Page info secure scheme "https" text to medium + Page info and connection info link text to #3367D6 + Bluetooth dialog link text to #3367D6 + Bluetooth dialog bottom margin to match button right margin BUG= 723044 , 723054 Change-Id: I2646135c31d3328d0028b831275941ab00278382 Reviewed-on: https://chromium-review.googlesource.com/572545 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#487534} [modify] https://crrev.com/4fb04a8aaab7ab6633f8f87cf4af6e36cd0627fe/chrome/android/java/res/layout/connection_info.xml [modify] https://crrev.com/4fb04a8aaab7ab6633f8f87cf4af6e36cd0627fe/chrome/android/java/res/layout/item_chooser_dialog.xml [modify] https://crrev.com/4fb04a8aaab7ab6633f8f87cf4af6e36cd0627fe/chrome/android/java/res/values/colors.xml [modify] https://crrev.com/4fb04a8aaab7ab6633f8f87cf4af6e36cd0627fe/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/4fb04a8aaab7ab6633f8f87cf4af6e36cd0627fe/chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java [modify] https://crrev.com/4fb04a8aaab7ab6633f8f87cf4af6e36cd0627fe/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
,
Jul 18 2017
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/638a36ea517305e8e564da10039ae89219798ff5 commit 638a36ea517305e8e564da10039ae89219798ff5 Author: Becky Zhou <huayinz@chromium.org> Date: Thu Jul 20 17:58:19 2017 Revert "[Snowflake] Unify infobar text styles" This reverts commit 4fb04a8aaab7ab6633f8f87cf4af6e36cd0627fe. Reason for revert: <INSERT REASONING HERE> Original change's description: > [Snowflake] Unify infobar text styles > > + Infobar secondary text from #646464 to 54% black > + Infobar big icon control message to 20sp > + Conneciton info url from bold to medium > + Conneciton info description line height to 20 > + Page info secure scheme "https" text to medium > + Page info and connection info link text to #3367D6 > + Bluetooth dialog link text to #3367D6 > + Bluetooth dialog bottom margin to match button right margin > > BUG= 723044 , 723054 > > Change-Id: I2646135c31d3328d0028b831275941ab00278382 > Reviewed-on: https://chromium-review.googlesource.com/572545 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Becky Zhou <huayinz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487534} TBR=tedchoc@chromium.org,twellington@chromium.org,huayinz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 723044 , 723054 Change-Id: I2c0593255aaa196ead26f6d34c9dc59d6672d195 Reviewed-on: https://chromium-review.googlesource.com/579788 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#488303} [modify] https://crrev.com/638a36ea517305e8e564da10039ae89219798ff5/chrome/android/java/res/layout/connection_info.xml [modify] https://crrev.com/638a36ea517305e8e564da10039ae89219798ff5/chrome/android/java/res/layout/item_chooser_dialog.xml [modify] https://crrev.com/638a36ea517305e8e564da10039ae89219798ff5/chrome/android/java/res/values/colors.xml [modify] https://crrev.com/638a36ea517305e8e564da10039ae89219798ff5/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/638a36ea517305e8e564da10039ae89219798ff5/chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java [modify] https://crrev.com/638a36ea517305e8e564da10039ae89219798ff5/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/860b0dda54fabcce3654fa956d0d76c70fe42ea5 commit 860b0dda54fabcce3654fa956d0d76c70fe42ea5 Author: Becky Zhou <huayinz@chromium.org> Date: Fri Jul 21 20:45:25 2017 [Snowflake] Unify infobar text styles + Infobar secondary text from #646464 to 54% black + Infobar big icon control message to 20sp + Conneciton info url from bold to medium + Conneciton info description line height to 20 + Page info secure scheme "https" text to medium + Page info and connection info link text to #3367D6 + Bluetooth dialog link text to #3367D6 + Bluetooth dialog bottom margin to match button right margin BUG= 723044 , 723054 Change-Id: I59461f4d9a73da49d0370661a8d275f8b2699083 Reviewed-on: https://chromium-review.googlesource.com/581801 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#488743} [modify] https://crrev.com/860b0dda54fabcce3654fa956d0d76c70fe42ea5/chrome/android/java/res/layout/connection_info.xml [modify] https://crrev.com/860b0dda54fabcce3654fa956d0d76c70fe42ea5/chrome/android/java/res/layout/item_chooser_dialog.xml [modify] https://crrev.com/860b0dda54fabcce3654fa956d0d76c70fe42ea5/chrome/android/java/res/values/colors.xml [modify] https://crrev.com/860b0dda54fabcce3654fa956d0d76c70fe42ea5/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/860b0dda54fabcce3654fa956d0d76c70fe42ea5/chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java [modify] https://crrev.com/860b0dda54fabcce3654fa956d0d76c70fe42ea5/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java |
|||
►
Sign in to add a comment |
|||
Comment 1 by k...@chromium.org
, May 16 2017