New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723051 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: ----

Blocking:
issue 723025



Sign in to add a comment

[Snowflake] Unify CCT text styles

Project Member Reported by k...@chromium.org, May 16 2017

Issue description

We would like to unify CCT text styles (see parent bug for more details):
+ Change “Powered by Chrome” from #616161 to Material Secondary Grey - 54% black - #8A000000
+ Custom tabs url path to Material Secondary (54%) and url to Material Primary (87%)  and icons should be 5a5a5a
+ CCT urls to Material Primary Grey 600 - 87% black - #DE000000

Spec: https://docs.google.com/document/d/1kTibP9GcfWUt_PGtmSWkIRdlozeIepuZZr7Jotw5Qs8/edit
Tracker: https://docs.google.com/spreadsheets/d/1TJthSNjqaraTKgmNy2vVvW4GiZn0_j8r0ssGjV9Zvkg/edit#gid=0

 

Comment 1 by k...@chromium.org, May 16 2017

Cc: hannahs@chromium.org
hannahs@ - 
1) The button icons in custom tabs currently share the same color with button icons in omnibox toolbar, app menu, find in page and default TintedDrawable widget. They have color #A3000000 and in disabled mode #3D000000. Do I change all of them or just the colors in custom tabs?

2) Are these two items the same?
  + CCT urls to Material Primary Grey 600 - 87% black - #DE000000
  + Custom tabs url to Material Primary (87%)

1) The icons don't need to be updated here :) so you can keep that as is the spec here only refer to type
2) I yes, they should be referring to the same thing (the url under the title of the site to the right of the lock icon)
powered_by_chrome.png
213 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d40ceab7039f28583f99693b3aa651fa71aeb52

commit 7d40ceab7039f28583f99693b3aa651fa71aeb52
Author: Becky Zhou <huayinz@chromium.org>
Date: Fri Sep 08 21:27:24 2017

[Snowflake] Unify small blue link text and grey text

+ Change blue link text no larger than Reg 16sp or Med 14sp 
  to google blue 700
+ Change "powered by chrome" in CCT to black 54
+ Change #333, #000 to black 87 (except omnibox and toolbar)

Bug:  723040 ,  723051 
Change-Id: I2c6b05bb6b7539c90c75b8aa790186f6ad23ad50
Reviewed-on: https://chromium-review.googlesource.com/646582
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500684}
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/layout/contextual_search_promo_view.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/layout/contextual_suggestions_card.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/layout/download_manager_ui_space_widget.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/layout/find_in_page.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/layout/fre_data_reduction_proxy.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/layout/fre_tosanduma.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/layout/lightweight_fre_tos.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/layout/new_tab_page_all_dismissed.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/layout/new_tab_page_snippets_card_large_thumbnail.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/layout/new_tab_page_status_card.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/layout/other_forms_of_history_dialog.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/layout/page_info.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/layout/page_info_permission_row.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/layout/powered_by_chrome_footer.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/layout/recent_tabs_group_item.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/layout/recent_tabs_list_item.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/layout/sad_tab.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/layout/signin_promo_view_impl.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/values/colors.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryAdapter.java
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsGroupView.java
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/src/org/chromium/chrome/browser/page_info/ConnectionInfoPopup.java
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/src/org/chromium/chrome/browser/preferences/LearnMorePreference.java
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbarPhone.java
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/test/data/android/render_tests/ArticleSnippetsTest.download_snippet_placeholder.Nexus_5-19.png
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/test/data/android/render_tests/ArticleSnippetsTest.download_snippet_thumbnail.Nexus_5-19.png
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/test/data/android/render_tests/ArticleSnippetsTest.signin_promo.Nexus_5-19.png
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/test/data/android/render_tests/NewTabPageTest.new_tab_page.Nexus_5-19.png
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/chrome/test/data/android/render_tests/NewTabPageTest.new_tab_page_scrolled.Nexus_5-19.png
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/ui/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/7d40ceab7039f28583f99693b3aa651fa71aeb52/ui/android/java/src/org/chromium/ui/text/NoUnderlineClickableSpan.java

Status: Fixed (was: Available)
this one is fixed.

Sign in to add a comment