New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723050 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: ----

Blocking:
issue 723025



Sign in to add a comment

[Snowflake] Unify bookmarks, history, downloads text styles

Project Member Reported by k...@chromium.org, May 16 2017

Issue description

We would like to unify bookmarks, history, downloads text styles (see parent bug for more details):

+ Change Bookmarks page title from Med 20 - #212121 to  Material Primary Grey 600 - 87% black - #DE000000
+ Change history bottom link from Bold 12sp to Med 14 - Material Primary Grey 600 - 87% black - #DE000000
+ Change history time stamp and urls from #969696 to Material Secondary Grey - 54% black - #8A000000
+ Change History page title from Bold to Med 20 -  Material Primary Grey 600 - 87% black - #DE000000 - LH 24 and lower 5dp
+ Downloads menu selected text to #3367D6

Spec: https://docs.google.com/document/d/1kTibP9GcfWUt_PGtmSWkIRdlozeIepuZZr7Jotw5Qs8/edit
Tracker: https://docs.google.com/spreadsheets/d/1TJthSNjqaraTKgmNy2vVvW4GiZn0_j8r0ssGjV9Zvkg/edit#gid=0

 

Comment 1 by k...@chromium.org, May 16 2017

Cc: hannahs@chromium.org

Comment 2 Deleted

hannahs@ - I think the current bookmarks page and history page already get the default text color #333, and the text style is not bold, so the following items can be fixed by  issue 723040 . 
+ Change Bookmarks page title from Med 20 - #212121 to  Material Primary Grey 600 - 87% black - #DE000000
+ Change history bottom link from Bold 12sp to Med 14 - Material Primary Grey 600 - 87% black - #DE000000 
+ Change History page title from Bold to Med 20 - Material Primary Grey 600 - 87% black - #DE000000

Could you double check the attached screenshots and see if I'm wrong?
bookmarks.png
65.7 KB View Download
history.png
157 KB View Download
hannahs@ - I would also like to ask if 
  + Downloads menu selected text to #3367D6
should be something like the attached screenshot.
download_menu_selected.png
97.8 KB View Download
Cc: -dfalcant...@chromium.org
Hey! Comment#3 lgtm±!

And for #4 thanks for taking the screenshot! It's actually incorrect (my bad!) I was basking this off of old downloads specs which has changed since then.... so please revert this change... Thanks for the catch! (and again my apologies for missing this to begin with!)
No problem, I'll revert the change. Thanks for checking:) so for item
  + Downloads menu selected text to #3367D6
I'll just ignore that?
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c64920be23861a50acda753f3984d94fac2ec7e3

commit c64920be23861a50acda753f3984d94fac2ec7e3
Author: huayinz <huayinz@chromium.org>
Date: Tue Jun 06 18:39:32 2017

[Snowflake] Unify bookmarks, history and downloads text styles

+ Change history time stamp and urls to 54% black
+ Change default text color from #333 to 87% black

BUG= 723050 

Review-Url: https://codereview.chromium.org/2927603002
Cr-Commit-Position: refs/heads/master@{#477351}

[modify] https://crrev.com/c64920be23861a50acda753f3984d94fac2ec7e3/chrome/android/java/res/layout/history_item_view.xml
[modify] https://crrev.com/c64920be23861a50acda753f3984d94fac2ec7e3/chrome/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/c64920be23861a50acda753f3984d94fac2ec7e3/chrome/android/java/res/values/colors.xml

Screenshots after changes. hannahs@ - Please check! I also would like to know if I need to change the 'showing history from this device' text to 54% black since it is not specified in the bug.
new_bookmarks.png
52.2 KB View Download
new_downloads.png
63.7 KB View Download
new_history_with_privacy_text.png
111 KB View Download
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f677dc1e24c3f8d441ec47460976b7546649d642

commit f677dc1e24c3f8d441ec47460976b7546649d642
Author: huayinz <huayinz@chromium.org>
Date: Wed Jun 07 00:02:22 2017

[Snowflake] Unify bookmarks, history and downloads text styles

+ Change downloads image button tint not to use default_text_color

BUG= 723050 

Review-Url: https://codereview.chromium.org/2925933002
Cr-Commit-Position: refs/heads/master@{#477471}

[modify] https://crrev.com/f677dc1e24c3f8d441ec47460976b7546649d642/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java

Status: Fixed (was: Available)
lgtm! Thanks for knocking this out so fast!

Sign in to add a comment