[Snowflake] Unify bookmarks, history, downloads text styles |
|||
Issue descriptionWe would like to unify bookmarks, history, downloads text styles (see parent bug for more details): + Change Bookmarks page title from Med 20 - #212121 to Material Primary Grey 600 - 87% black - #DE000000 + Change history bottom link from Bold 12sp to Med 14 - Material Primary Grey 600 - 87% black - #DE000000 + Change history time stamp and urls from #969696 to Material Secondary Grey - 54% black - #8A000000 + Change History page title from Bold to Med 20 - Material Primary Grey 600 - 87% black - #DE000000 - LH 24 and lower 5dp + Downloads menu selected text to #3367D6 Spec: https://docs.google.com/document/d/1kTibP9GcfWUt_PGtmSWkIRdlozeIepuZZr7Jotw5Qs8/edit Tracker: https://docs.google.com/spreadsheets/d/1TJthSNjqaraTKgmNy2vVvW4GiZn0_j8r0ssGjV9Zvkg/edit#gid=0
,
Jun 5 2017
hannahs@ - I think the current bookmarks page and history page already get the default text color #333, and the text style is not bold, so the following items can be fixed by issue 723040 . + Change Bookmarks page title from Med 20 - #212121 to Material Primary Grey 600 - 87% black - #DE000000 + Change history bottom link from Bold 12sp to Med 14 - Material Primary Grey 600 - 87% black - #DE000000 + Change History page title from Bold to Med 20 - Material Primary Grey 600 - 87% black - #DE000000 Could you double check the attached screenshots and see if I'm wrong?
,
Jun 5 2017
hannahs@ - I would also like to ask if + Downloads menu selected text to #3367D6 should be something like the attached screenshot.
,
Jun 5 2017
,
Jun 6 2017
Hey! Comment#3 lgtm±! And for #4 thanks for taking the screenshot! It's actually incorrect (my bad!) I was basking this off of old downloads specs which has changed since then.... so please revert this change... Thanks for the catch! (and again my apologies for missing this to begin with!)
,
Jun 6 2017
No problem, I'll revert the change. Thanks for checking:) so for item + Downloads menu selected text to #3367D6 I'll just ignore that?
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c64920be23861a50acda753f3984d94fac2ec7e3 commit c64920be23861a50acda753f3984d94fac2ec7e3 Author: huayinz <huayinz@chromium.org> Date: Tue Jun 06 18:39:32 2017 [Snowflake] Unify bookmarks, history and downloads text styles + Change history time stamp and urls to 54% black + Change default text color from #333 to 87% black BUG= 723050 Review-Url: https://codereview.chromium.org/2927603002 Cr-Commit-Position: refs/heads/master@{#477351} [modify] https://crrev.com/c64920be23861a50acda753f3984d94fac2ec7e3/chrome/android/java/res/layout/history_item_view.xml [modify] https://crrev.com/c64920be23861a50acda753f3984d94fac2ec7e3/chrome/android/java/res/values-v17/styles.xml [modify] https://crrev.com/c64920be23861a50acda753f3984d94fac2ec7e3/chrome/android/java/res/values/colors.xml
,
Jun 6 2017
Screenshots after changes. hannahs@ - Please check! I also would like to know if I need to change the 'showing history from this device' text to 54% black since it is not specified in the bug.
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f677dc1e24c3f8d441ec47460976b7546649d642 commit f677dc1e24c3f8d441ec47460976b7546649d642 Author: huayinz <huayinz@chromium.org> Date: Wed Jun 07 00:02:22 2017 [Snowflake] Unify bookmarks, history and downloads text styles + Change downloads image button tint not to use default_text_color BUG= 723050 Review-Url: https://codereview.chromium.org/2925933002 Cr-Commit-Position: refs/heads/master@{#477471} [modify] https://crrev.com/f677dc1e24c3f8d441ec47460976b7546649d642/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
,
Jun 7 2017
,
Jun 12 2017
lgtm! Thanks for knocking this out so fast! |
|||
►
Sign in to add a comment |
|||
Comment 1 by k...@chromium.org
, May 16 2017