[Snowflake] Unify NTP & tab switcher text styles |
||||
Issue descriptionWe would like to unify NTP & tab switcher text styles: + Change Learn more text link/ string at bottom of NTP to regular instead of italic + Frequently visited tiles to Material Secondary Grey - 54% black - #8A000000 + Tab switcher titles to Material Gray 900 (87%) Spec: https://docs.google.com/document/d/1kTibP9GcfWUt_PGtmSWkIRdlozeIepuZZr7Jotw5Qs8/edit Tracker: https://docs.google.com/spreadsheets/d/1TJthSNjqaraTKgmNy2vVvW4GiZn0_j8r0ssGjV9Zvkg/edit#gid=0
,
May 16 2017
,
May 17 2017
Can you take a look?
,
May 18 2017
This should be fine on our side. Kingston and Hannah - have you already checked accessibility for the frequently visited tiles text?
,
May 18 2017
Yes! All these text styles have an approved contrast ratio.
,
May 22 2017
Awesome, thanks!
,
May 24 2017
There was a typo for: + Tab switcher titles to Material Gray 900 (87%) Should be: + Tab switcher titles to Material Gray 600 (87%)
,
May 24 2017
Hi hannah, Could you clarify: + Tab switcher titles to Material Gray 600 (87%) Should it be 54% instead (i.e. #8A000000)?
,
May 24 2017
Sorry, I think there's some confusion about the Material color numbering. The 6000 or 900 refers to this color palette: https://material.googleplex.com/style/color.html#color-color-palette Which I think is different to how it's coded. TL;DR Ignore the number "Material" number, please follow only the transparency percentages: 87% black: #DE000000 54% black: #8A000000 38% Black: #61000000 Thanks!!
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2c96f726dffb1ba319a3ed7d4da8aa0c1156fb2 commit e2c96f726dffb1ba319a3ed7d4da8aa0c1156fb2 Author: huayinz <huayinz@chromium.org> Date: Tue May 30 18:21:51 2017 Unify toolbar, NTP, and tab switcher text styles + Change omnibox URL path text to 38% black + Change omnibox status 'Offline' text to 54% black + Change omnibox 'Search or type URL' text to 38% black + Change omnibox selected and suggestions to 87% black + Move color constants in SuggestionView and AnswerTextBuilder to color.xml + Change NTP 'learn more' text to regular font + Change Frequently visited tiles to 54% black + Change tab switcher titles to 87% black BUG= 723042 , 723047 R=twellington@chromium.org Review-Url: https://codereview.chromium.org/2896883003 Cr-Commit-Position: refs/heads/master@{#475602} [modify] https://crrev.com/e2c96f726dffb1ba319a3ed7d4da8aa0c1156fb2/chrome/android/java/res/layout/new_tab_page_footer.xml [modify] https://crrev.com/e2c96f726dffb1ba319a3ed7d4da8aa0c1156fb2/chrome/android/java/res/values/colors.xml [modify] https://crrev.com/e2c96f726dffb1ba319a3ed7d4da8aa0c1156fb2/chrome/android/java/src/org/chromium/chrome/browser/omnibox/AnswerTextBuilder.java [modify] https://crrev.com/e2c96f726dffb1ba319a3ed7d4da8aa0c1156fb2/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
,
May 30 2017
,
May 31 2017
Sorry to ask for the extra step, but can you add a quick screenshot when marking a bug as fixed just for posterity?
,
May 31 2017
Perfect!!! Thank you so much!!!! <3 Verified by me :) (Also as a part of bug: https://bugs.chromium.org/p/chromium/issues/detail?id=723040 the "learn more" link in the bottom of the NTP will have to change to #3367D6 to meet accessibility standards - not sure if it's easier to batch change this, but just letting you know in case you want to change it now! Thanks again so much!!! You're blazing fast! Thanks! |
||||
►
Sign in to add a comment |
||||
Comment 1 by k...@chromium.org
, May 16 2017