[Snowflake] Unify infobar text styles |
|||
Issue descriptionWe would like to unify infobar text styles: + Change Add to Home infobar title from Bold to Medium and app title from 18sp to 17sp Infobar secondary text “Page language” al #646464 to Material Secondary Grey - 54% black - #8A000000 + Add to home screen title from 18 to 20sp Material Primary Grey 600 - 87% black - #DE000000 + Url path under add to home screen to Reg 12 Material Secondary Grey - 54% black - #8A000000 Spec: https://docs.google.com/document/d/1kTibP9GcfWUt_PGtmSWkIRdlozeIepuZZr7Jotw5Qs8/edit Tracker: https://docs.google.com/spreadsheets/d/1TJthSNjqaraTKgmNy2vVvW4GiZn0_j8r0ssGjV9Zvkg/edit#gid=0
,
May 26 2017
,
May 30 2017
,
May 30 2017
Hi Hannah, Thanks for the clarification. The add to home screen dialog exists, but there is no url path in the add to home screen dialog. For url path, do you mean the url path in the app banner infobar (the screenshot I took)?
,
May 30 2017
Hrm, I think I must have been referring to the infobar, but changed my mind to be consistent with list views.... Please ignore on that one :) Thanks!
,
Jun 1 2017
Hi Hannah, for this one, + Add to home screen title from 18 to 20sp Material Primary Grey 600 - 87% black - #DE000000 I believe the add to home screen title in the add to home screen dialog is already 20sp right now. Could you double check if this title is referring to the one in add to home screen dialog? Thanks, Becky
,
Jun 2 2017
This looks great, I believe this was based on a screenshot as I wasn't able to find the code for it, so as long as it's 20sp #DE000000, we're good. Thanks for double checking!
,
Jun 2 2017
hannahs@ - I found that Add to home screen dialog is created by AlertDialog.Builder (from which most dialogs are built in chromium). Dialog created by the builder has title text size 20sp and a message size 16sp unless style is specified. I think just changing add to home screen dialogs style might be strange because all these dialogs have some shared styles, so it might be nice to define a standard default style for all of them. Could you take a look to them and make a decision please? Thanks Attached are some examples I found: + suggestion view dialog has the default 20sp for title and 16sp for message + share dialog (this dialog might be replaced in new versions?) has default 20sp for title and 18sp #8A000000 for the app text view
,
Jun 6 2017
Thanks for looking into this! I wasn't sure so I added these specs but we should just leave the dialog builder defaults as is then for consistency (so no change needed here) thanks so much for doing the legwork!
,
Jun 8 2017
Screenshots on new changes (The translate infobar has recently changed to the compact version so I can only find this with infobar secondary text). Please check! Also, is + Change Add to Home infobar title from Bold to Medium and app title from 18sp to 17sp a special case? 17sp is not in the style guide and Add to Home infobar app title is not in unique type treatment either.
,
Jun 12 2017
The add to homes screen dialog looks great! Thanks! for: "+ Change Add to Home infobar title from Bold to Medium and app title from 18sp to 17sp" I made a miscalculation -was trying to make it look like the add to home screen dialog, so we should use the same title as that. Apologies for the confusion! Please change "The Air Horner" type to be the same as "Add to Home screen" (Roboto Medium 20sp 87% black - #DE000000) Also what's the padding between "The Air Horner" and airhorner.com? (I believe it should be 8dp). Thanks!!!
,
Jun 12 2017
The padding between "The Air Horner" and airhorner.com is already 8dp. Screenshot of new changes attached.
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4fb04a8aaab7ab6633f8f87cf4af6e36cd0627fe commit 4fb04a8aaab7ab6633f8f87cf4af6e36cd0627fe Author: Becky Zhou <huayinz@chromium.org> Date: Tue Jul 18 18:30:43 2017 [Snowflake] Unify infobar text styles + Infobar secondary text from #646464 to 54% black + Infobar big icon control message to 20sp + Conneciton info url from bold to medium + Conneciton info description line height to 20 + Page info secure scheme "https" text to medium + Page info and connection info link text to #3367D6 + Bluetooth dialog link text to #3367D6 + Bluetooth dialog bottom margin to match button right margin BUG= 723044 , 723054 Change-Id: I2646135c31d3328d0028b831275941ab00278382 Reviewed-on: https://chromium-review.googlesource.com/572545 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#487534} [modify] https://crrev.com/4fb04a8aaab7ab6633f8f87cf4af6e36cd0627fe/chrome/android/java/res/layout/connection_info.xml [modify] https://crrev.com/4fb04a8aaab7ab6633f8f87cf4af6e36cd0627fe/chrome/android/java/res/layout/item_chooser_dialog.xml [modify] https://crrev.com/4fb04a8aaab7ab6633f8f87cf4af6e36cd0627fe/chrome/android/java/res/values/colors.xml [modify] https://crrev.com/4fb04a8aaab7ab6633f8f87cf4af6e36cd0627fe/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/4fb04a8aaab7ab6633f8f87cf4af6e36cd0627fe/chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java [modify] https://crrev.com/4fb04a8aaab7ab6633f8f87cf4af6e36cd0627fe/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
,
Jul 18 2017
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/638a36ea517305e8e564da10039ae89219798ff5 commit 638a36ea517305e8e564da10039ae89219798ff5 Author: Becky Zhou <huayinz@chromium.org> Date: Thu Jul 20 17:58:19 2017 Revert "[Snowflake] Unify infobar text styles" This reverts commit 4fb04a8aaab7ab6633f8f87cf4af6e36cd0627fe. Reason for revert: <INSERT REASONING HERE> Original change's description: > [Snowflake] Unify infobar text styles > > + Infobar secondary text from #646464 to 54% black > + Infobar big icon control message to 20sp > + Conneciton info url from bold to medium > + Conneciton info description line height to 20 > + Page info secure scheme "https" text to medium > + Page info and connection info link text to #3367D6 > + Bluetooth dialog link text to #3367D6 > + Bluetooth dialog bottom margin to match button right margin > > BUG= 723044 , 723054 > > Change-Id: I2646135c31d3328d0028b831275941ab00278382 > Reviewed-on: https://chromium-review.googlesource.com/572545 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Becky Zhou <huayinz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487534} TBR=tedchoc@chromium.org,twellington@chromium.org,huayinz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 723044 , 723054 Change-Id: I2c0593255aaa196ead26f6d34c9dc59d6672d195 Reviewed-on: https://chromium-review.googlesource.com/579788 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#488303} [modify] https://crrev.com/638a36ea517305e8e564da10039ae89219798ff5/chrome/android/java/res/layout/connection_info.xml [modify] https://crrev.com/638a36ea517305e8e564da10039ae89219798ff5/chrome/android/java/res/layout/item_chooser_dialog.xml [modify] https://crrev.com/638a36ea517305e8e564da10039ae89219798ff5/chrome/android/java/res/values/colors.xml [modify] https://crrev.com/638a36ea517305e8e564da10039ae89219798ff5/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/638a36ea517305e8e564da10039ae89219798ff5/chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java [modify] https://crrev.com/638a36ea517305e8e564da10039ae89219798ff5/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/860b0dda54fabcce3654fa956d0d76c70fe42ea5 commit 860b0dda54fabcce3654fa956d0d76c70fe42ea5 Author: Becky Zhou <huayinz@chromium.org> Date: Fri Jul 21 20:45:25 2017 [Snowflake] Unify infobar text styles + Infobar secondary text from #646464 to 54% black + Infobar big icon control message to 20sp + Conneciton info url from bold to medium + Conneciton info description line height to 20 + Page info secure scheme "https" text to medium + Page info and connection info link text to #3367D6 + Bluetooth dialog link text to #3367D6 + Bluetooth dialog bottom margin to match button right margin BUG= 723044 , 723054 Change-Id: I59461f4d9a73da49d0370661a8d275f8b2699083 Reviewed-on: https://chromium-review.googlesource.com/581801 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#488743} [modify] https://crrev.com/860b0dda54fabcce3654fa956d0d76c70fe42ea5/chrome/android/java/res/layout/connection_info.xml [modify] https://crrev.com/860b0dda54fabcce3654fa956d0d76c70fe42ea5/chrome/android/java/res/layout/item_chooser_dialog.xml [modify] https://crrev.com/860b0dda54fabcce3654fa956d0d76c70fe42ea5/chrome/android/java/res/values/colors.xml [modify] https://crrev.com/860b0dda54fabcce3654fa956d0d76c70fe42ea5/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/860b0dda54fabcce3654fa956d0d76c70fe42ea5/chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java [modify] https://crrev.com/860b0dda54fabcce3654fa956d0d76c70fe42ea5/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java |
|||
►
Sign in to add a comment |
|||
Comment 1 by k...@chromium.org
, May 16 2017