[Snowflake] Unify toolbar text styles |
|||||||||||||||||||||||||||
Issue descriptionWe would like to unify toolbar text styles: + Change omnibox path text from 41% to Material Grey Hint Text - 38% Black - #61000000 + Change omnibox offline text from 64 to Material Gray 600 (54%) + Change “Search or type” omnibox hint text to Material Grey Hint Text - 38% Black - #61000000 Incl NTP + Change Omnibox selected (entered text) and suggestions to Material Primary (87%) Spec: https://docs.google.com/document/d/1kTibP9GcfWUt_PGtmSWkIRdlozeIepuZZr7Jotw5Qs8/edit Tracker: https://docs.google.com/spreadsheets/d/1TJthSNjqaraTKgmNy2vVvW4GiZn0_j8r0ssGjV9Zvkg/edit#gid=0
,
May 17 2017
Can you take a look Becky?
,
May 19 2017
,
May 23 2017
Hi Kingston and Hannah, The suggestions from Answers in Suggest has colors + Google Red 700 - #C53929 (to be depreciate) for negative description + Google Green 700 - #0B8043 (to be depreciate) for positive description + #8a8a8a (not specified in style guide) for general answers I don't find a issue in tracker for them and couldn't find a replacement color either. Could you specify some colors if you want to also change them in the suggestions?
,
May 23 2017
Hi! And thanks for helping out! Can you provide a screenshot so I can get a better idea of what you're specifically referring to? Since this is a pretty critical part of the UI I just want to make sure I'm accurately describing my specs (my nomenclature for "hint text" may not be what it's actually referred to in code - which is something I'm also working on defining). I've also set up a meeting with you so I can introduce myself properly and hopefully provide more clarity :) Thanks! Thanks!
,
May 24 2017
Hi Hannah, Attached are the examples of Answers in Suggest. You can see Google Red 700 and Google Green 700 are used in the stock price, and #8a8a8a is used for the rest of the answer. Thanks for your help!
,
May 24 2017
+jdonnely to be roped in for any decisions we make about answers in suggest
,
May 24 2017
For the time being, I don't think we should change the answers in suggest (don't change the red or green) until we have further data from the Chrome Home experiment. For the #8a8a8a "general answers" are you referring to the "GOOGL (NASDAQ)" text)? It seems like a lighter grey than the default text we use for the answers in the omnibox dropdown. (We can also chat in person if this helps!)
,
May 26 2017
Both gray elements ("GOOGL (NASDAQ)" and the price "20.01") are #8a8a8a. The attribution ("GOOGL (NASDAQ)") looks lighter because it's a smaller font. Looking at the screenshots, I have a hard time believing that myself, but the code doesn't lie. Probably. :)
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/omnibox/AnswerTextBuilder.java?l=58-71&rcl=c290763a1b98e8c9815e87e326b13a314605bf98
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2c96f726dffb1ba319a3ed7d4da8aa0c1156fb2 commit e2c96f726dffb1ba319a3ed7d4da8aa0c1156fb2 Author: huayinz <huayinz@chromium.org> Date: Tue May 30 18:21:51 2017 Unify toolbar, NTP, and tab switcher text styles + Change omnibox URL path text to 38% black + Change omnibox status 'Offline' text to 54% black + Change omnibox 'Search or type URL' text to 38% black + Change omnibox selected and suggestions to 87% black + Move color constants in SuggestionView and AnswerTextBuilder to color.xml + Change NTP 'learn more' text to regular font + Change Frequently visited tiles to 54% black + Change tab switcher titles to 87% black BUG= 723042 , 723047 R=twellington@chromium.org Review-Url: https://codereview.chromium.org/2896883003 Cr-Commit-Position: refs/heads/master@{#475602} [modify] https://crrev.com/e2c96f726dffb1ba319a3ed7d4da8aa0c1156fb2/chrome/android/java/res/layout/new_tab_page_footer.xml [modify] https://crrev.com/e2c96f726dffb1ba319a3ed7d4da8aa0c1156fb2/chrome/android/java/res/values/colors.xml [modify] https://crrev.com/e2c96f726dffb1ba319a3ed7d4da8aa0c1156fb2/chrome/android/java/src/org/chromium/chrome/browser/omnibox/AnswerTextBuilder.java [modify] https://crrev.com/e2c96f726dffb1ba319a3ed7d4da8aa0c1156fb2/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
,
May 30 2017
,
May 30 2017
Hi! Just to make sure I didn't break anything, can you add a quick screenshot when you're done? (or if you can teach me how I can take the screenshot myself that works too!)
,
May 31 2017
,
May 31 2017
I'm so sorry but I forgot that due to accessibility we decided use 54% black instead of 38% black: just for the “Search or type” text in the omnibox and NTP box. Can you update it to 54% Black #8A000000? Again my apologies...!
,
May 31 2017
Also this should probably be a different bug, but for some reason it looks like the padding under the last suggestion in the dropdown, and above the first suggestion got shorter. It should be 32dp on bottom and 20dp on top.
,
Jun 1 2017
The current suggestion list does not have any padding on the top and bottom of the suggestion list. The screenshot you gave (20dp on top and 32dp on bottom) includes padding of each suggestion answer view, could you specify how much extra padding we should put on top and bottom of the list? Also, I found a ux design doc specifying 8dp extra padding on both top and bottom of the suggestion list. Is the doc I found out of date? Where can I find ux design docs?
,
Jun 2 2017
Apologies for the confusion, most of the design docs are probably out of date... can you link the UX design doc (with the 8dp padding) not sure which one you're referring to. (8dp may be correct if the suggestions are using a list template in which each text row has built in padding) this might be easier if I just stop by your desk! Will put something on your calendar for next week!
,
Jun 8 2017
Here are the screenshots on the new changes. Please check, thanks!
,
Jun 12 2017
Everything lgtm! I just one question - why is there's a grey selected state for "m" in the omnibox suggestion dropdown menu? (for the last 3 images) Is this an accessibility state for mobile users? Or were you just highlighting it to demonstrate the padding? Sorry for the dumb questions!
,
Jun 12 2017
I was just holding the suggestion result and take the screenshot to show you the padding:)
,
Jun 12 2017
Ah, thanks for doing that, then everything lgtm!! Thanks!
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57f1f0bb48b70875fa118be2266104b7249db921 commit 57f1f0bb48b70875fa118be2266104b7249db921 Author: huayinz <huayinz@chromium.org> Date: Tue Jun 13 00:14:26 2017 [Snowflake] Unify toolbar text styles + Change omnibox/ntp search hint text color to 54% black + Change suggestion view list top and bottom padding to 8dp BUG= 723042 Review-Url: https://codereview.chromium.org/2930713002 Cr-Commit-Position: refs/heads/master@{#478833} [modify] https://crrev.com/57f1f0bb48b70875fa118be2266104b7249db921/chrome/android/java/res/values-sw600dp/dimens.xml [modify] https://crrev.com/57f1f0bb48b70875fa118be2266104b7249db921/chrome/android/java/res/values/colors.xml [modify] https://crrev.com/57f1f0bb48b70875fa118be2266104b7249db921/chrome/android/java/res/values/dimens.xml
,
Jun 13 2017
,
Jun 13 2017
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22ce12082518748df0f9c773d21da665232247b7 commit 22ce12082518748df0f9c773d21da665232247b7 Author: huayinz <huayinz@chromium.org> Date: Tue Jun 13 16:36:54 2017 Revert url color in suggestion view Revert suggesstion url from #3367d6 back to #5595fe. BUG= 723042 Review-Url: https://codereview.chromium.org/2928363005 Cr-Commit-Position: refs/heads/master@{#479043} [modify] https://crrev.com/22ce12082518748df0f9c773d21da665232247b7/chrome/android/java/res/values/colors.xml
,
Jun 14 2017
|
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by k...@chromium.org
, May 16 2017