New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723041 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

BuildPackages Failures due to compile error in Chrome

Project Member Reported by afakhry@chromium.org, May 16 2017

Issue description

Failing on x86-generic-tot-chromium-pfq-informational: https://build.chromium.org/p/chromiumos.chromium/builders/x86-generic-tot-chromium-pfq-informational/builds/11894
and ChromiumOS x86-generic Compile: https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20x86-generic%20Compile/builds/35648

Culprit CL: https://codereview.chromium.org/2886803002 (Being reverted).
Also This CL should be fixed: https://codereview.chromium.org/2869933002 (Will be reverted shortly).

chromeos-chrome-60.0.3102.0_alpha-r1: FAILED: obj/media/audio/audio/audio_manager_cras.o 
chromeos-chrome-60.0.3102.0_alpha-r1: i686-pc-linux-gnu-g++ -B/usr/x86_64-pc-linux-gnu/i686-pc-linux-gnu/binutils-bin/2.25.51-gold -MMD -MF obj/media/audio/audio/audio_manager_cras.o.d -DV8_DEPRECATION_WARNINGS -DDCHECK_ALWAYS_ON=1 -DUSE_UDEV -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_ALSA -DUSE_CRAS -DMEDIA_IMPLEMENTATION -DUSE_EGL -DANGLE_ENABLE_RELEASE_ASSERTS -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1 -I../../../../../../../home/chrome-bot/chrome_root/src -Igen -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libwebp -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/khronos -I../../../../../../../home/chrome-bot/chrome_root/src/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/skia/config -I../../../../../../../home/chrome-bot/chrome_root/src/skia/ext -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/c -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/config -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/core -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/effects -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/encode -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/images -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/lazy -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pathops -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pdf -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pipe -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/ports -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/utils -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/third_party/vulkan -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/src/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/src/sksl -I/build/x86-generic/usr/include/dbus-1.0 -I/build/x86-generic/usr/lib/dbus-1.0/include -fno-strict-aliasing -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -m32 -msse2 -mfpmath=sse -mmmx -pthread -Wall -Werror -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g2 -gsplit-dwarf --sysroot=../../../../../../../build/x86-generic -fvisibility=hidden -std=gnu++11 -Wno-narrowing -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -march=i686 -pipe -march=i686 -pipe -pipe -march=i686 -mfpmath=sse -mmmx -msse -msse2 -msse3 -D__google_stl_debug_vector=1 -femit-struct-debug-reduced -c ../../../../../../../home/chrome-bot/chrome_root/src/media/audio/cras/audio_manager_cras.cc -o obj/media/audio/audio/audio_manager_cras.o
chromeos-chrome-60.0.3102.0_alpha-r1: In file included from ../../../../../../../home/chrome-bot/chrome_root/src/base/memory/ref_counted.h:17:0,
chromeos-chrome-60.0.3102.0_alpha-r1:                  from ../../../../../../../home/chrome-bot/chrome_root/src/media/audio/cras/audio_manager_cras.h:14,
chromeos-chrome-60.0.3102.0_alpha-r1:                  from ../../../../../../../home/chrome-bot/chrome_root/src/media/audio/cras/audio_manager_cras.cc:5:
chromeos-chrome-60.0.3102.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/base/logging.h: In instantiation of 'std::string* logging::CheckEQImpl(const t1&, const t2&, const char*) [with t1 = int; t2 = unsigned int; std::string = std::basic_string<char>]':
chromeos-chrome-60.0.3102.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/media/audio/cras/audio_manager_cras.cc:95:168:   required from here
chromeos-chrome-60.0.3102.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/base/logging.h:747:120: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
chromeos-chrome-60.0.3102.0_alpha-r1:  DEFINE_CHECK_OP_IMPL(EQ, ==)
chromeos-chrome-60.0.3102.0_alpha-r1:                                                                                                                         ^
chromeos-chrome-60.0.3102.0_alpha-r1: cc1plus: all warnings being treated as errors
 

Comment 1 by thakis@chromium.org, May 16 2017

Cc: warx@chromium.org
Owner: dmazz...@chromium.org
Status: Started (was: Assigned)
https://codereview.chromium.org/2886993002/

Ok, then, won't have to revert warx's CL.

Comment 3 by warx@chromium.org, May 16 2017

thanks for the work

Comment 4 by gab@chromium.org, May 16 2017

Did https://codereview.chromium.org/2886993002/ fix this or do we need to address this as well before re-enabling?

Comment 5 by gab@chromium.org, May 17 2017

Looks like it did, remaining error on those bots after that revision is the same as  issue 723090  (video_capture_oracle.o)

Comment 6 by gab@chromium.org, May 17 2017

Status: Fixed (was: Started)

Comment 7 by warx@chromium.org, May 17 2017

btw, my CL is also merged to m59. Will the fix CL also need to be merged to m59?

Comment 8 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment