New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723039 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 738485



Sign in to add a comment

Move "rotation lock" into tiles row

Project Member Reported by est...@chromium.org, May 16 2017

Issue description

The rotation lock toggle in the ChromeOS system menu gets an entire row. Tapping the row doesn't show a detailed view; it just toggles the setting. Should this live in "tiles" view (i.e. the row of buttons at the bottom of the menu)?
 
Labels: Proj-MaterialDesign-CrOS
IMO yes this would be a clear win since rotation lock is a simple "on/off" toggle similar to https://codereview.chromium.org/2907503002/ which is implemented as a toggle-able tile.

This would be the sixth tile added to the tiles row, and it looks like seven icons can fit comfortably. I think it makes sense to make this change now, but note it brings us one step closer to requiring the 'tile mode' implementation specced in issue 677581.

Possible bonus user delight opportunity: consider using a moticon when toggling on/off similar to what is seen in Android system UI.

Comment 2 by est...@chromium.org, May 25 2017

indeed, rotation lock, nightlight and the message center's do not disturb icons are three candidates on our radar for adding motion.

Comment 3 by est...@chromium.org, May 31 2017

Cc: girard@chromium.org
ping Sebastien, wdyt?
Summary: Move "rotation lock" into tiles row (was: rotation lock gets its own row)
Sebastien, friendly ping. Would you be comfortable with rotation lock being turned into a tile even before the full "tile mode" spec is implemented?
Cc: jennschen@chromium.org
Sorry for the delay. I think rotation lock is a great candidate for a tile.
I think it should be positioned right after the Night Light icon.
Adding Jenn for Sanity check.
Cc: sgabr...@chromium.org
Owner: tdander...@chromium.org
Agreed, would be great to move this in to the tile area!

It'd be great for this (similar to Night Light) would be able to have feedback about the state upon tapping since we'll be losing the (arguably not great) strings here by moving it into a tile, and we can't rely on tooltips here to express strings.
One more thing: would be good to prevent accidentally tapping something destructive, so to the left of Night Light might be a more protected location.
I've filed bug 738485 to track that effort and assigned it to myself.
@Jenn feel free to mark it as blocking this bug. If not, let's go ahead and make the change and get the toggle feedback in later. 
Blockedon: 738485
Done — would consider this a regression in usability if we didn't have feedback since we do a better job with that today, and it's a more commonly toggled action.
Sounds good I'll get to the new feedback system when I come back.
Cc: tdander...@chromium.org
Owner: est...@chromium.org
Cc: est...@chromium.org
Owner: sgabr...@chromium.org
Components: UI>Settings

Sign in to add a comment