New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723036 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 459786



Sign in to add a comment

Move render surface creation decision to compositor thread

Project Member Reported by jaydasika@chromium.org, May 16 2017

Issue description

We currently decide whether to create a render surface or nor during cc property tree building on the main thread (PropertyTreeBuilder::ShouldCreateRenderSurface)
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/190125cd098bf1a71b7186b4278f6104aa0dbe6c

commit 190125cd098bf1a71b7186b4278f6104aa0dbe6c
Author: jaydasika <jaydasika@chromium.org>
Date: Tue May 23 22:10:46 2017

cc : Remove transform nodes for scroll child

We create transform nodes for scroll child when it has a target
different from its scroll parent. We were doing this when we were
creating render surfaces on the main thread and had target_id on clip
and transform nodes because if didn't create a transform node, the
target_id would have been wrong for scroll child's subtree.

Now, render surfaces are created on compositor thread. We don't create
clip nodes for targets and don't have target ids on transform nodes, so
this is not required now.

BUG=723036
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2900153002
Cr-Commit-Position: refs/heads/master@{#474079}

[modify] https://crrev.com/190125cd098bf1a71b7186b4278f6104aa0dbe6c/cc/trees/property_tree_builder.cc

Project Member

Comment 2 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbc951ded1697aef6fb274375740d89e66953d18

commit fbc951ded1697aef6fb274375740d89e66953d18
Author: jaydasika <jaydasika@chromium.org>
Date: Wed May 24 04:22:52 2017

cc : Create effect nodes for non axis aligned clips

We currently create effect node (and render surface) if there
is a clip and the transform to the previous render target is not axis
aligned. But, when we stop deciding whether to create a render surface
during property tree building, we won't know if the transform to the
previous render surface is axis aligned. With this CL, we create
effect nodes if thre is a non axis aligned transform between clips.
Transform to previous render surface might be axis aligned
even if there is some ancestor between the clips that has a non axis
aligned transform. This implies, we might create an unnecessary effect
node in that case.

BUG=723036
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2885233002
Cr-Commit-Position: refs/heads/master@{#474161}

[modify] https://crrev.com/fbc951ded1697aef6fb274375740d89e66953d18/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/fbc951ded1697aef6fb274375740d89e66953d18/cc/trees/property_tree_builder.cc

Comment 3 by vmi...@chromium.org, Aug 16 2017

Owner: chrishtr@chromium.org
Re-assigning jaydasika's issues.  Chris could you please triage?
Owner: trchen@chromium.org
Owner: chrishtr@chromium.org
I'm leaving the team, thus re-assigning bugs.

Sign in to add a comment