Move render surface creation decision to compositor thread |
||||
Issue descriptionWe currently decide whether to create a render surface or nor during cc property tree building on the main thread (PropertyTreeBuilder::ShouldCreateRenderSurface)
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbc951ded1697aef6fb274375740d89e66953d18 commit fbc951ded1697aef6fb274375740d89e66953d18 Author: jaydasika <jaydasika@chromium.org> Date: Wed May 24 04:22:52 2017 cc : Create effect nodes for non axis aligned clips We currently create effect node (and render surface) if there is a clip and the transform to the previous render target is not axis aligned. But, when we stop deciding whether to create a render surface during property tree building, we won't know if the transform to the previous render surface is axis aligned. With this CL, we create effect nodes if thre is a non axis aligned transform between clips. Transform to previous render surface might be axis aligned even if there is some ancestor between the clips that has a non axis aligned transform. This implies, we might create an unnecessary effect node in that case. BUG=723036 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2885233002 Cr-Commit-Position: refs/heads/master@{#474161} [modify] https://crrev.com/fbc951ded1697aef6fb274375740d89e66953d18/cc/trees/layer_tree_host_common_unittest.cc [modify] https://crrev.com/fbc951ded1697aef6fb274375740d89e66953d18/cc/trees/property_tree_builder.cc
,
Aug 16 2017
Re-assigning jaydasika's issues. Chris could you please triage?
,
Jun 5 2018
,
Sep 13
I'm leaving the team, thus re-assigning bugs. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, May 23 2017