New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723033 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR



Sign in to add a comment

playcanvas.as site crashes on Galaxy S6

Project Member Reported by dbbrooks@chromium.org, May 16 2017

Issue description

Chrome Version: 60.0.3096.5
VR Services: 1.5.153389785
OS: Android M
Device: Galaxy S6

What steps will reproduce the problem?
(1) go to https://playcanv.as/p/sAsiDvtC/
(2) press VR button
(3) place device into cardboard headset
(4) look around and press click button to move around environment.

What is the expected result? Continuously works

What happens instead? After a short time or a few clicks, the page crashes. Shows the "Aw, snap!" page. One time Chrome crashed (crash ID below) - but Chrome didn't crash again. However, the page crash happens every time.

Crash ID: 2fd7215170000000
 
If this is only happening on the S6, my guess is that this is the same as Issue 682482, which is a general WebGL bug. Can't seem to find the JavaScript snippet where the GL attributes are set, though.
Labels: -Pri-3 M-60 Pri-1
Owner: mthiesse@chromium.org
Status: Assigned (was: Untriaged)
The one crash ID he gave is a browser process crash.

Thread 102 CRASHED [SIGSEGV @ 0x00000008 ] MAGIC SIGNATURE THREAD
0x0000007f78f968a4	(libchrome.so -vr_shell_renderer.cc:856 )	vr_shell::VrShellRenderer::Flush()
0x0000007f78f9694c	(libchrome.so -vr_shell_renderer.cc:841 )	vr_shell::VrShellRenderer::GetControllerRenderer()
0x0000007f78f90d18	(libchrome.so -vr_shell_gl.cc:1257 )	vr_shell::VrShellGl::SetControllerModel(std::__ndk1::unique_ptr<vr_shell::VrControllerModel, std::__ndk1::default_delete<vr_shell::VrControllerModel> >)
0x0000007f78f8d080	(libchrome.so -bind_internal.h:214 )	base::internal::Invoker<base::internal::BindState<void (vr_shell::VrShellGl::*)(std::__ndk1::unique_ptr<vr_shell::VrControllerModel, std::__ndk1::default_delete<vr_shell::VrControllerModel> >), base::WeakPtr<vr_shell::VrShellGl>, base::internal::PassedWrapper<std::__ndk1::unique_ptr<vr_shell::VrControllerModel, std::__ndk1::default_delete<vr_shell::VrControllerModel> > > >, void ()>::Run(base::internal::BindStateBase*)
0x0000007f766c5a00	(libchrome.so -callback.h:91 )	base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*)
0x0000007f766e325c	(libchrome.so -message_loop.cc:404 )	base::MessageLoop::RunTask(base::PendingTask*)
0x0000007f766e37a4	(libchrome.so -message_loop.cc:415 )	base::MessageLoop::DeferOrRunPendingTask(base::PendingTask)
0x0000007f766e3cd4	(libchrome.so -message_loop.cc:503 )	base::MessageLoop::DoWork()
0x0000007f766e50ac	(libchrome.so -message_pump_default.cc:33 )	base::MessagePumpDefault::Run(base::MessagePump::Delegate*)
0x0000007f766e2ba4	(libchrome.so -message_loop.cc:368 )	base::MessageLoop::RunHandler()
0x0000007f767036d8	(libchrome.so -run_loop.cc:105 )	base::RunLoop::Run()
0x0000007f7672ba50	(libchrome.so -thread.cc:338 )	base::Thread::ThreadMain()
0x0000007f7672647c	(libchrome.so -platform_thread_posix.cc:71 )	ThreadFunc
0x0000007faa634fa0	(libc.so + 0x00065fa0 )
Owner: acondor@google.com
Initial thoughts: This is almost certainly because we delay gl initialization on pre-daydream devices until we get a surface, so the controller model was probably actually ready before gl was initialized.

We should both delay setting up the controller renderer until GL is initialized, and we should probably not load the controller model at all on non-daydream devices.
Project Member

Comment 4 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb02e40644d21597ca5394189294d3bbdf337452

commit fb02e40644d21597ca5394189294d3bbdf337452
Author: acondor <acondor@google.com>
Date: Fri May 19 17:05:03 2017

VR: Loading DD controller model after GL is initialized

Also, the model is only loaded in Daydream-ready devices.

BUG= 723033 

Review-Url: https://codereview.chromium.org/2891243002
Cr-Commit-Position: refs/heads/master@{#473219}

[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/browser/android/vr_shell/vr_controller_model.cc
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/browser/android/vr_shell/vr_controller_model.h
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/browser/android/vr_shell/vr_shell_renderer.cc

Project Member

Comment 5 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb02e40644d21597ca5394189294d3bbdf337452

commit fb02e40644d21597ca5394189294d3bbdf337452
Author: acondor <acondor@google.com>
Date: Fri May 19 17:05:03 2017

VR: Loading DD controller model after GL is initialized

Also, the model is only loaded in Daydream-ready devices.

BUG= 723033 

Review-Url: https://codereview.chromium.org/2891243002
Cr-Commit-Position: refs/heads/master@{#473219}

[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/browser/android/vr_shell/vr_controller_model.cc
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/browser/android/vr_shell/vr_controller_model.h
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/fb02e40644d21597ca5394189294d3bbdf337452/chrome/browser/android/vr_shell/vr_shell_renderer.cc

Comment 6 by acondor@google.com, May 19 2017

Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)
This is still occurring with 61.0.3122.0. VR Core 1.6.156467194

Crash ID: 91db75ce98000000 Crash report uploaded on Wednesday, June 7, 2017 at 10:05:36 AM

Status: Fixed (was: Assigned)
turns out comment #7 is an unrelated crash. logged bug 730812
Components: Blink>WebXR

Sign in to add a comment